You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by janebeckman <gi...@git.apache.org> on 2017/08/30 00:47:33 UTC

[GitHub] incubator-hawq-docs pull request #129: Update for current implementation of ...

GitHub user janebeckman opened a pull request:

    https://github.com/apache/incubator-hawq-docs/pull/129

    Update for current implementation of max_connections

    Revisions were made to max_connections and seg_max_connections, especially with new defaults. This updates to reflect that usage

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/janebeckman/incubator-hawq-docs feature/max_connections

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq-docs/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #129
    
----
commit 27109b7282554e04cd8f7fbdd55543b35b2d037d
Author: Jane Beckman <jb...@pivotal.io>
Date:   2017-08-28T23:23:38Z

    Updates to concurrent connection configuration

commit 0409c14da8c02aa2d3ae9feceeb3bd854350ebbf
Author: Jane Beckman <jb...@pivotal.io>
Date:   2017-08-29T17:15:03Z

    Revision to hawq init

commit b61c1901ef3e7f2d1227f3e5c2353a6503f73278
Author: Jane Beckman <jb...@pivotal.io>
Date:   2017-08-29T21:03:17Z

    Clarify default values.

commit 8eabdc0ed010fde4bd6f50d0a4e8bd594cec926b
Author: Jane Beckman <jb...@pivotal.io>
Date:   2017-08-29T21:09:49Z

    Fix xref.

commit 07b1f24480c885bb8ea6f2ba084e9e6b3944028e
Author: Jane Beckman <jb...@pivotal.io>
Date:   2017-08-29T21:22:57Z

    Add seg_max_connections entry

commit d8a11a5b6191fb919150046afe48fe221c7f149a
Author: Jane Beckman <jb...@pivotal.io>
Date:   2017-08-30T00:13:24Z

    Add xref entry

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq-docs pull request #129: Update for current implementation of ...

Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq-docs/pull/129#discussion_r135990726
  
    --- Diff: markdown/clientaccess/client_auth.html.md.erb ---
    @@ -99,27 +99,25 @@ This example shows how to edit the `pg_hba.conf` file of the master to allow rem
     
     HAWQ allocates some resources on a per-connection basis, so setting the maximum number of connections allowed is recommended.
     
    -To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter on master or the `seg_max_connections` server configuration parameter on segments. These parameters are *local* parameters, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
    +To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter. This parameter is a *local* parameter, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
     
    -When you set `max_connections`, you must also set the dependent parameter `max_prepared_transactions`. This value must be at least as large as the value of `max_connections`, and all HAWQ instances should be set to the same value.
    +When you set `max_connections`, you can also set the value for the maximum concurrent connections for the segments by using `seg_max_connections`. Setting this parameter overrides the value of `max_connections` on the segment instances.
     
     Example `$GPHOME/etc/hawq-site.xml` configuration:
     
     ``` xml
       <property>
           <name>max_connections</name>
    -      <value>500</value>
    +      <value>200</value>
    --- End diff --
    
    It's ok, but I think better to be 1280 as the default value we used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq-docs pull request #129: Update for current implementation of ...

Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq-docs/pull/129#discussion_r135990205
  
    --- Diff: markdown/clientaccess/client_auth.html.md.erb ---
    @@ -99,27 +99,25 @@ This example shows how to edit the `pg_hba.conf` file of the master to allow rem
     
     HAWQ allocates some resources on a per-connection basis, so setting the maximum number of connections allowed is recommended.
     
    -To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter on master or the `seg_max_connections` server configuration parameter on segments. These parameters are *local* parameters, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
    +To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter. This parameter is a *local* parameter, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
    --- End diff --
    
    The previous one seems better:
    To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter on master or the `seg_max_connections` server configuration parameter on segments.
    
    Except that I think we don't need to mention it's a *local* parameter. We don't need to set it in 'hawq-site.xml' unless we want one specify node to be different than others.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq-docs pull request #129: Update for current implementation of ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-hawq-docs/pull/129


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq-docs pull request #129: Update for current implementation of ...

Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq-docs/pull/129#discussion_r135999105
  
    --- Diff: markdown/clientaccess/client_auth.html.md.erb ---
    @@ -99,27 +99,25 @@ This example shows how to edit the `pg_hba.conf` file of the master to allow rem
     
     HAWQ allocates some resources on a per-connection basis, so setting the maximum number of connections allowed is recommended.
     
    -To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter on master or the `seg_max_connections` server configuration parameter on segments. These parameters are *local* parameters, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
    +To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter. This parameter is a *local* parameter, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
     
    -When you set `max_connections`, you must also set the dependent parameter `max_prepared_transactions`. This value must be at least as large as the value of `max_connections`, and all HAWQ instances should be set to the same value.
    +When you set `max_connections`, you can also set the value for the maximum concurrent connections for the segments by using `seg_max_connections`. Setting this parameter overrides the value of `max_connections` on the segment instances.
     
     Example `$GPHOME/etc/hawq-site.xml` configuration:
     
     ``` xml
       <property>
           <name>max_connections</name>
    -      <value>500</value>
    +      <value>200</value>
    --- End diff --
    
    I am ok with default value changes, as Radar said, if we mentioned the best practice value as 1280 for this guc, maybe it is better to directly change to 1280 to reflect what we recommended. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq-docs pull request #129: Update for current implementation of ...

Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq-docs/pull/129#discussion_r135990959
  
    --- Diff: markdown/clientaccess/client_auth.html.md.erb ---
    @@ -99,27 +99,25 @@ This example shows how to edit the `pg_hba.conf` file of the master to allow rem
     
     HAWQ allocates some resources on a per-connection basis, so setting the maximum number of connections allowed is recommended.
     
    -To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter on master or the `seg_max_connections` server configuration parameter on segments. These parameters are *local* parameters, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
    +To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter. This parameter is a *local* parameter, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
     
    -When you set `max_connections`, you must also set the dependent parameter `max_prepared_transactions`. This value must be at least as large as the value of `max_connections`, and all HAWQ instances should be set to the same value.
    +When you set `max_connections`, you can also set the value for the maximum concurrent connections for the segments by using `seg_max_connections`. Setting this parameter overrides the value of `max_connections` on the segment instances.
     
     Example `$GPHOME/etc/hawq-site.xml` configuration:
     
     ``` xml
       <property>
           <name>max_connections</name>
    -      <value>500</value>
    +      <value>200</value>
       </property>
       <property>
    -      <name>max_prepared_transactions</name>
    +      <name>seg_max_connectionss</name>
    --- End diff --
    
    As I mentioned above, this should better to be 3000 as our default value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq-docs pull request #129: Update for current implementation of ...

Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq-docs/pull/129#discussion_r135990618
  
    --- Diff: markdown/clientaccess/client_auth.html.md.erb ---
    @@ -99,27 +99,25 @@ This example shows how to edit the `pg_hba.conf` file of the master to allow rem
     
     HAWQ allocates some resources on a per-connection basis, so setting the maximum number of connections allowed is recommended.
     
    -To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter on master or the `seg_max_connections` server configuration parameter on segments. These parameters are *local* parameters, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
    +To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter. This parameter is a *local* parameter, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
     
    -When you set `max_connections`, you must also set the dependent parameter `max_prepared_transactions`. This value must be at least as large as the value of `max_connections`, and all HAWQ instances should be set to the same value.
    +When you set `max_connections`, you can also set the value for the maximum concurrent connections for the segments by using `seg_max_connections`. Setting this parameter overrides the value of `max_connections` on the segment instances.
    --- End diff --
    
    'seg_max_connections' does not overwrite 'max_connections', they are separate GUCs. 
    
    'max_connections' will only affect master node's max connections.
    'seg_max_connections' only affect segment nodes's max connections.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq-docs pull request #129: Update for current implementation of ...

Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq-docs/pull/129#discussion_r135999117
  
    --- Diff: markdown/clientaccess/client_auth.html.md.erb ---
    @@ -99,27 +99,25 @@ This example shows how to edit the `pg_hba.conf` file of the master to allow rem
     
     HAWQ allocates some resources on a per-connection basis, so setting the maximum number of connections allowed is recommended.
     
    -To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter on master or the `seg_max_connections` server configuration parameter on segments. These parameters are *local* parameters, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
    +To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter. This parameter is a *local* parameter, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
     
    -When you set `max_connections`, you must also set the dependent parameter `max_prepared_transactions`. This value must be at least as large as the value of `max_connections`, and all HAWQ instances should be set to the same value.
    +When you set `max_connections`, you can also set the value for the maximum concurrent connections for the segments by using `seg_max_connections`. Setting this parameter overrides the value of `max_connections` on the segment instances.
     
     Example `$GPHOME/etc/hawq-site.xml` configuration:
     
     ``` xml
       <property>
           <name>max_connections</name>
    -      <value>500</value>
    +      <value>200</value>
       </property>
       <property>
    -      <name>max_prepared_transactions</name>
    +      <name>seg_max_connectionss</name>
    --- End diff --
    
    As above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq-docs pull request #129: Update for current implementation of ...

Posted by jinyismilodon <gi...@git.apache.org>.
Github user jinyismilodon commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq-docs/pull/129#discussion_r135998540
  
    --- Diff: markdown/clientaccess/client_auth.html.md.erb ---
    @@ -99,27 +99,25 @@ This example shows how to edit the `pg_hba.conf` file of the master to allow rem
     
     HAWQ allocates some resources on a per-connection basis, so setting the maximum number of connections allowed is recommended.
     
    -To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter on master or the `seg_max_connections` server configuration parameter on segments. These parameters are *local* parameters, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
    +To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter. This parameter is a *local* parameter, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
     
    -When you set `max_connections`, you must also set the dependent parameter `max_prepared_transactions`. This value must be at least as large as the value of `max_connections`, and all HAWQ instances should be set to the same value.
    +When you set `max_connections`, you can also set the value for the maximum concurrent connections for the segments by using `seg_max_connections`. Setting this parameter overrides the value of `max_connections` on the segment instances.
     
     Example `$GPHOME/etc/hawq-site.xml` configuration:
     
     ``` xml
       <property>
           <name>max_connections</name>
    -      <value>500</value>
    +      <value>200</value>
    --- End diff --
    
    I find we mentioned the best practice setting is 1280, so I agree with Radar if we can directly set it to 1280 to reflect what we recommended.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---