You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by mattf-horton <gi...@git.apache.org> on 2017/12/19 10:24:29 UTC
[GitHub] metron pull request #875: METRON-1373 RAT failure for metron-interface/metro...
GitHub user mattf-horton opened a pull request:
https://github.com/apache/metron/pull/875
METRON-1373 RAT failure for metron-interface/metron-alerts
## Contributor Comments
Please see https://issues.apache.org/jira/browse/METRON-1373 and https://issues.apache.org/jira/browse/METRON-1163
This extends a fix already accepted in 0.4.1, for a file that got renamed and therefore needs an additional exclusion.
This is the patch for master, which is 5 commits beyond 0.4.2. We would like to stay with the known stable RC candidate contents, so this fix will be separately committed to 0.4.2. If by chance it is rejected here, it will be reverted there.
Test procedure: Please note that this issue can ONLY be seen if one unrolls a tarball (as from the dist repository) rather than cloning from github. So test this fix with the RC2.
To reproduce, do the following:
```
mkdir workdir; cd workdir
wget https://dist.apache.org/repos/dist/dev/metron/0.4.2-RC1/apache-metron-0.4.2-rc1.tar.gz
tar xvzf apache-metron-0.4.2-rc1.tar.gz
cd apache-metron-0.4.2-rc1
mvn clean
mvn install -DskipTests
```
When it comes to metron-alerts module, apache-rat-plugin should error, complaining about:
```
Files with unapproved licenses:
.../metron-interface/metron-alerts/dist/styles. f56deed131e58bd7ee04.bundle.css
```
To test the patch, repeat the test, changing "RC1" to "RC2" and "rc1" to "rc2" in all instances.
## Pull Request Checklist
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [in pro] Have you ensured that the full suite of tests and checks have been executed in the root metron folder
- [NA] Have you written or updated unit tests and or integration tests to verify your changes?
- [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [in pro] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [NA] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattf-horton/metron METRON-1373
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/875.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #875
----
commit 29961049c4863baf043e9e3fb0e9d0704177cdbd
Author: mattf-horton <mf...@hortonworks.com>
Date: 2017-12-19T10:03:42Z
METRON-1373 RAT failure for metron-interface/metron-alerts
----
---
[GitHub] metron pull request #875: METRON-1373 RAT failure for metron-interface/metro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/875
---
[GitHub] metron issue #875: METRON-1373 RAT failure for metron-interface/metron-alert...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/875
Ran up through
```bash
mvn clean && time mvn -q -T 2C -DskipTests install && time mvn -q -T 2C surefire:test@unit-tests && time mvn -q surefire:test@integration-tests && time mvn -q test --projects metron-interface/metron-config && time build_utils/verify_licenses.sh
```
Worked fine. I'm +1
---
[GitHub] metron issue #875: METRON-1373 RAT failure for metron-interface/metron-alert...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/875
Is it sensible to exclude `dist/styles.*.bundles.css`? It seems that this file changes its name.
---
[GitHub] metron issue #875: METRON-1373 RAT failure for metron-interface/metron-alert...
Posted by mattf-horton <gi...@git.apache.org>.
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/875
Thanks, @ottobackwards . @cestella , I'm concerned that, when this happens we should actually recheck the licensing, since this is a 3rd-party package we have no assurances about. Still I admit that if this happens a third time I'll be strongly tempted to just wildcard it.
---