You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2023/03/24 13:49:56 UTC

[GitHub] [arrow] felipecrv commented on pull request #34697: GH-34696: [C++] Check REE arrays have no null buffer in Validate()

felipecrv commented on PR #34697:
URL: https://github.com/apache/arrow/pull/34697#issuecomment-1482833193

   Thank you for fixing this @wjones127. 
   
   > Alternatively, should we be raising here?
   > 
   > https://github.com/apache/arrow/blob/5bbaf6bade2232a0d60e912defb97579a11db83f/cpp/src/arrow/array/validate.cc#L492-L494
   
   @wjones127 as RUN_END_ENCODED is a new type, we could add this layout validation in this switch without breaking existing code as REEs are not used yet. This is our chance :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org