[PR] Move MinutesTask output under build/dist/ so minutes pages reach production [grails-static-website]

["jamesfredley (via GitHub)" <gi...@apache.org>]

jamesfredley opened a new pull request, #488:
URL: https://github.com/apache/grails-static-website/pull/488

   ## Summary
   
   `MinutesTask.renderMinutes` writes rendered foundation/minutes pages to `outputDir.dir('foundation/minutes')`, which resolves to `build/foundation/minutes/` because `siteExt.outputDir` is conventioned to the project's build directory. **The publish workflow only ships `build/dist/` to the `asf-site-production` branch**, so anything the build emits outside `build/dist/` is invisible to production. Result: foundation/minutes pages have not received build updates from `./gradlew build` since this divergence was introduced; the live foundation/minutes pages on `grails.apache.org` are stale, rendered by some earlier version of the build that put them in the right place.
   
   ## Context
   
   Every other rendering task in this project writes underneath `build/dist/`:
   
   | Task | Output |
   |---|---|
   | `RenderSiteTask` | `outputDir.dir('dist')` |
   | `BlogTask` | `outputDir.dir('dist/blog')` |
   | `PluginsTask` | `outputDir.dir('dist')`, `outputDir.dir('dist/plugins/tags')`, `outputDir.dir('dist/plugins/owners')` |
   | `BlogTask` (asset copy) | `outputDir.dir('dist/images')` |
   | `MinutesTask` (asset copy) | `outputDir.dir('dist/images')` |
   | **`MinutesTask` (HTML render)** | **`outputDir.dir('foundation/minutes')` ← the bug** |
   
   ## Fix
   
   Change the destination directory from `'foundation/minutes'` to `'dist/foundation/minutes'`. The downstream `renderRss` call uses `outputDir.parentFile` resolved against the same target, so the RSS feed correspondingly moves from `build/foundation/minutes.xml` to `build/dist/foundation/minutes.xml`, lining up with how `BlogTask` emits `build/dist/rss.xml` from `build/dist/blog/`.
   
   ## Verification
   
   ```bash
   ./gradlew clean build --no-configuration-cache
   ```
   
   - `6` `.html` minutes pages appear under `build/dist/foundation/minutes/` (5 individual + 1 index).
   - The minutes RSS feed appears at `build/dist/foundation/minutes.xml`.
   - The previous `build/foundation/minutes/` tree is gone.
   - Regression check: 15 root pages, 125 blog posts, 214 plugins tag pages, 109 plugins owner pages all still render.
   
   ## Out of scope
   
   The minutes pages still need PR #486 merged (to expand the `[%PARTIAL:...]` tokens) and PR #487 merged (to populate `[%ogurl]`) before they render with full site chrome and correct social cards. That ordering is fine; **this PR is the prerequisite that makes the pages reach production at all**. Without this fix, the partials and ogurl improvements never ship to live minutes pages.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move MinutesTask output under build/dist/ so minutes pages reach production [grails-static-website]

["jamesfredley (via GitHub)" <gi...@apache.org>]

jamesfredley merged PR #488:
URL: https://github.com/apache/grails-static-website/pull/488


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org