You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/12 01:12:31 UTC

[GitHub] [incubator-pinot] apucher opened a new pull request #5848: tolerate DATE_TIME and COMPLEX fields

apucher opened a new pull request #5848:
URL: https://github.com/apache/incubator-pinot/pull/5848


   ## Description
   Fixes a forward compatibility issue with DATE_TIME fields in the data generator
   
   ## Upgrade Notes
   Does this PR prevent a zero down-time upgrade?
   **no**
   
   Does this PR fix a zero-downtime upgrade introduced earlier?
   **no**
   
   Does this PR otherwise need attention when creating release notes? Things to consider:
   **no**
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] npawar commented on pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

Posted by GitBox <gi...@apache.org>.
npawar commented on pull request #5848:
URL: https://github.com/apache/incubator-pinot/pull/5848#issuecomment-672446619


   it should be fine to ignore the field for now. Eventually we want to handle it just like TIME case


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] apucher commented on pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

Posted by GitBox <gi...@apache.org>.
apucher commented on pull request #5848:
URL: https://github.com/apache/incubator-pinot/pull/5848#issuecomment-672447672


   @Jackie-Jiang we already do when using the pattern data generator. the crappy old code is around for backwards compatibility only. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] apucher merged pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

Posted by GitBox <gi...@apache.org>.
apucher merged pull request #5848:
URL: https://github.com/apache/incubator-pinot/pull/5848


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] apucher commented on pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

Posted by GitBox <gi...@apache.org>.
apucher commented on pull request #5848:
URL: https://github.com/apache/incubator-pinot/pull/5848#issuecomment-672448160


   we may actually consider removing it. afaik there's no active use of it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on pull request #5848:
URL: https://github.com/apache/incubator-pinot/pull/5848#issuecomment-672440092


   @npawar Please take a look and see whether we should support generating data for date time fields


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org