You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Stefano Lenzi <ki...@interfree.it> on 2007/08/08 14:24:27 UTC
[FELIX-219] Applying the patch
Hi All,
I'd like to know if anyone of you have spent some time on the patch
FELIX-219 available on JIRA. IMHO we should apply it, but before doing
that on my own I'd like to get some feedback from you :)
Please note that the above patch affects also the OBR bundle and it
changes the XML schema used by OBR, but I think that will be easy to fix
if you don't like that part.
Ciao,
Stefano "Kismet" Lenzi
P.S.: I think that could be nice if we extend the idea so that the
deploy phase of the maven-bundle-plugin add the bundle in a remote OBR
repository.
Re: [FELIX-219] Applying the patch
Posted by Stuart McCulloch <st...@jayway.net>.
On 08/08/07, Stefano Lenzi <ki...@interfree.it> wrote:
>
> Hi All,
>
> I'd like to know if anyone of you have spent some time on the patch
> FELIX-219 available on JIRA. IMHO we should apply it, but before doing
> that on my own I'd like to get some feedback from you :)
I've only looked over the patch so far - not had enough time to look
into merging it with Maxime's (equally valuable) OBR plugin work.
IMHO this is something the bundle plugin should definitely provide,
but it's also something we should do right - that may mean spending
longer than normal on merging the patch, but I wouldn't like to rush
into applying a patch without considering all the options.
But if you're thinking of testing out the patch locally, then go for it :)
Please note that the above patch affects also the OBR bundle and it
> changes the XML schema used by OBR, but I think that will be easy to fix
> if you don't like that part.
>
> Ciao,
> Stefano "Kismet" Lenzi
>
> P.S.: I think that could be nice if we extend the idea so that the
> deploy phase of the maven-bundle-plugin add the bundle in a remote OBR
> repository.
>
that's also a possibility - the bundle-plugin defines its own custom
lifecycle
--
Cheers, Stuart
Re: [FELIX-219] Applying the patch
Posted by Stefano Lenzi <ki...@interfree.it>.
Clement Escoffier wrote:
> Hello,
>
>> -----Message d'origine-----
>> De : Stefano Lenzi [mailto:kismet@interfree.it]
>> Envoyé : vendredi 17 août 2007 18:47
>> À : dev@felix.apache.org
>> Cc : Maxime Vincent
>> Objet : Re: [FELIX-219] Applying the patch
>>
>> Stefano Lenzi wrote:
>>> Clement Escoffier wrote:
>>>> Hello,
>> [cut]
>>>>
>>>> For sure, using Castor seems to me the right approach. But first, we
>>>> need to
>>>> write the OBR XML Schema (Castor input)
>>> I'm going to write it :)
>>>
>> I'm trying to define the XML Schema but there is a problem in using XML
>> Schema to implement the parser for the OBRv2 XML, in fact the problem
>> is
>> that the OBRv2 RFC
>> (http://www2.osgi.org/download/rfc-0112_BundleRepository.pdf) do not
>> does not define any official tag for:
>> - source
>> - documentation
>> - size
>> - license
>> - etc.
>
>
> Maxime uses :
> <source>URI</source> (used the SCM element of the pom file)
> <documentation>URI</documentation> (use the URL element of the pom file)
> <size>size in bytes</size>
> <licence>URI</licence> (gathered by using bindex and the pom file (licences
> URI are separated by ';')
>
>
>> So there is not way to create a XML Schema for such tag, which at the
>> moment are handled manually :S
>
> I am not sure if these conventions are corrects (according to the spec),
> however we never use it really these tags (only for resource describing).
The problem is the spec allow any TAG for metadata and the spec do not
define the tag name for metadata information. For example: a resource
may use the tag <bundle-docurl> to store the link to documentation, or
it could use <length> for define the size of the bundle.
IMO, I think that the definition of a common set of tags should be
proposed as part of OBR-RFC, in order to avoid incompatibility of
metadata information.
Ciao,
Stefano "Kismet" Lenzi
RE: [FELIX-219] Applying the patch
Posted by Clement Escoffier <cl...@gmail.com>.
Hello,
> -----Message d'origine-----
> De : Stefano Lenzi [mailto:kismet@interfree.it]
> Envoyé : vendredi 17 août 2007 18:47
> À : dev@felix.apache.org
> Cc : Maxime Vincent
> Objet : Re: [FELIX-219] Applying the patch
>
> Stefano Lenzi wrote:
> > Clement Escoffier wrote:
> >> Hello,
> [cut]
> >>
> >>
> >> For sure, using Castor seems to me the right approach. But first, we
> >> need to
> >> write the OBR XML Schema (Castor input)
> >
> > I'm going to write it :)
> >
>
> I'm trying to define the XML Schema but there is a problem in using XML
> Schema to implement the parser for the OBRv2 XML, in fact the problem
> is
> that the OBRv2 RFC
> (http://www2.osgi.org/download/rfc-0112_BundleRepository.pdf) do not
> does not define any official tag for:
> - source
> - documentation
> - size
> - license
> - etc.
Maxime uses :
<source>URI</source> (used the SCM element of the pom file)
<documentation>URI</documentation> (use the URL element of the pom file)
<size>size in bytes</size>
<licence>URI</licence> (gathered by using bindex and the pom file (licences
URI are separated by ';')
>
> So there is not way to create a XML Schema for such tag, which at the
> moment are handled manually :S
I am not sure if these conventions are corrects (according to the spec),
however we never use it really these tags (only for resource describing).
Clement
Re: [FELIX-219] Applying the patch
Posted by Stefano Lenzi <ki...@interfree.it>.
Stefano Lenzi wrote:
> Clement Escoffier wrote:
>> Hello,
[cut]
>>
>>
>> For sure, using Castor seems to me the right approach. But first, we
>> need to
>> write the OBR XML Schema (Castor input)
>
> I'm going to write it :)
>
I'm trying to define the XML Schema but there is a problem in using XML
Schema to implement the parser for the OBRv2 XML, in fact the problem is
that the OBRv2 RFC
(http://www2.osgi.org/download/rfc-0112_BundleRepository.pdf) do not
does not define any official tag for:
- source
- documentation
- size
- license
- etc.
So there is not way to create a XML Schema for such tag, which at the
moment are handled manually :S
What do you think?
Ciao,
Stefano "Kismet" Lenzi
Re: [FELIX-219] Applying the patch
Posted by Stuart McCulloch <st...@jayway.net>.
On 29/08/2007, Clement Escoffier <cl...@gmail.com> wrote:
>
>
>
> > -----Message d'origine-----
> > De: mcculls@gmail.com [mailto:mcculls@gmail.com] De la part de Stuart
> > McCulloch
> > Envoyé: mardi 28 août 2007 12:54
> > À: dev@felix.apache.org
> > Objet: Re: [FELIX-219] Applying the patch
> >
> > On 28/08/07, Stefano Lenzi <ki...@interfree.it> wrote:
> > >
> > > Clement Escoffier wrote:
> > > >
> > > >> -----Message d'origine-----
> > > >> De : Stefano Lenzi [mailto:kismet@interfree.it]
> > > >> Envoyé : vendredi 17 août 2007 12:18
> > > >> À : dev@felix.apache.org
> > > >> Cc : Maxime Vincent
> > > >> Objet : Re: [FELIX-219] Applying the patch
> > > >>
> > > >> Clement Escoffier wrote:
> > > >>> Hello,
> > > >>>
> > > >>>> -----Message d'origine-----
> > > >>>> De : Stefano Lenzi [mailto:kismet@interfree.it]
> > > >>>> Envoyé : jeudi 16 août 2007 11:48
> > > >>>> À : dev@felix.apache.org
> > > >>>> Objet : Re: [FELIX-219] Applying the patch
> > > >>>>
> > > >>>> Clement Escoffier wrote:
> > > >>>>> Hello
> > > >>>>>
> > > >>>>> Maxime plug-in is available here :
> > > >>>>> http://clement.plop-
> > > >>>> plop.net/index.php?option=com_content&task=view&id=26&It
> > > >>>>> emid=37
> > > >>>>>
> > > >>>>> (it is a long URL due to the CMS I use (Joomla), say me if you
> > have
> > > >>>> issues
> > > >>>>> to access it).
> > > >>>>>
> > > >>>>> Sources are available at :
> > > >>>>> http://clement.plop-plop.net/downloads/obr/tool.obr.plugin.zip
> > > >>>> I looked at the plugin at it looks interesting, I have some
> > question
> > > >>>> about it:
> > > >>>> - Do you plan to move such plugin in felix?
> > > >>> I plan too. We need to finish tests before :-) and ask if it is
> > > >> accepted.
> > > >>> We need to improve locks when several peoples upload at the same
> > > >> time, check
> > > >>> XML file consistency ...
> > > >> I think that such feature may be left for version 1.1, because if
> > each
> > > >> user use it's own file it works great :)
> > > >>
> > > >>>> - There is any maven repository for your plugin?
> > > >>> No, that one of the problems.
> > > >> If you want I can publish the plugin on a public non-default maven
> > > >> repository....
> > > >> ..we had only to improve the POM in order to use dependency and to
> > add
> > > >> LICENSE information at least.
> > > >>
> > >
> > > What about the above questions?
> > >
> > > BTW, I'm planning to put a patched version of maven-bundle-plugin
> > which
> > > uses your plugin in my felix sandbox.
> > >
> > >
> > > >>
> > > >> Can I access to your SVN version of the software?
> > > >
> > > > No :-(, the security policy of a my laboratory is a little strict.
> > There
> > > is
> > > > no way to use the SVN repo externally (at home I cannot use it and
> > need
> > > to
> > > > be in my office to use it).
> > >
> > > If you can't give us access to the code but you are think to donate
> > the
> > > software to Felix, you (I can do that if you are busy) can move the
> > > sources to your Felix sandbox so that anyone can look at the code and
> > > improve it and later we can move the code to the Felix trunc area.
> >
> >
> > +1 for moving it to the sandbox - for some reason clement's site is not
> > accessible from malaysia...
> >
>
> Strange things. I know it is not accessible from China, but no from
> Malaysia.
interesting, it's now accessible - possibly a routing problem with our local
isp!
About the move, we are discussing it with Maxime (French administration ...)
>
> Clement
>
>
> > Ciao,
> > > Stefano "Kismet" Lenzi
> > >
> >
> > --
> > Cheers, Stuart
>
>
--
Cheers, Stuart
Re: [FELIX-219] Applying the patch
Posted by Niclas Hedhman <ni...@hedhman.org>.
On Tuesday 28 August 2007 18:54, Stuart McCulloch wrote:
> +1 for moving it to the sandbox - for some reason clement's site is not
> accessible from malaysia...
It is from my house... we can check in the office tomorrow.
Cheers
Niclas
Re: [FELIX-219] Applying the patch
Posted by Stefano Lenzi <ki...@interfree.it>.
Clement Escoffier wrote:
>
>> -----Message d'origine-----
>> De : mcculls@gmail.com [mailto:mcculls@gmail.com] De la part de Stuart
>> McCulloch
>> Envoyé : mardi 28 août 2007 12:54
>> À : dev@felix.apache.org
>> Objet : Re: [FELIX-219] Applying the patch
>>
>> On 28/08/07, Stefano Lenzi <ki...@interfree.it> wrote:
>>> Clement Escoffier wrote:
>>>>> -----Message d'origine-----
>>>>> De : Stefano Lenzi [mailto:kismet@interfree.it]
>>>>> Envoyé : vendredi 17 août 2007 12:18
>>>>> À : dev@felix.apache.org
>>>>> Cc : Maxime Vincent
>>>>> Objet : Re: [FELIX-219] Applying the patch
>>>>>
>>>>> Clement Escoffier wrote:
>>>>>> Hello,
>>>>>>
>>>>>>> -----Message d'origine-----
>>>>>>> De : Stefano Lenzi [mailto:kismet@interfree.it]
>>>>>>> Envoyé : jeudi 16 août 2007 11:48
>>>>>>> À : dev@felix.apache.org
>>>>>>> Objet : Re: [FELIX-219] Applying the patch
>>>>>>>
>>>>>>> Clement Escoffier wrote:
>>>>>>>> Hello
>>>>>>>>
>>>>>>>> Maxime plug-in is available here :
>>>>>>>> http://clement.plop-
>>>>>>> plop.net/index.php?option=com_content&task=view&id=26&It
>>>>>>>> emid=37
>>>>>>>>
>>>>>>>> (it is a long URL due to the CMS I use (Joomla), say me if you
>> have
>>>>>>> issues
>>>>>>>> to access it).
>>>>>>>>
>>>>>>>> Sources are available at :
>>>>>>>> http://clement.plop-plop.net/downloads/obr/tool.obr.plugin.zip
>>>>>>> I looked at the plugin at it looks interesting, I have some
>> question
>>>>>>> about it:
>>>>>>> - Do you plan to move such plugin in felix?
>>>>>> I plan too. We need to finish tests before :-) and ask if it is
>>>>> accepted.
>>>>>> We need to improve locks when several peoples upload at the same
>>>>> time, check
>>>>>> XML file consistency ...
>>>>> I think that such feature may be left for version 1.1, because if
>> each
>>>>> user use it's own file it works great :)
>>>>>
>>>>>>> - There is any maven repository for your plugin?
>>>>>> No, that one of the problems.
>>>>> If you want I can publish the plugin on a public non-default maven
>>>>> repository....
>>>>> ..we had only to improve the POM in order to use dependency and to
>> add
>>>>> LICENSE information at least.
>>>>>
>>> What about the above questions?
>>>
>>> BTW, I'm planning to put a patched version of maven-bundle-plugin
>> which
>>> uses your plugin in my felix sandbox.
>>>
>>>
>>>>> Can I access to your SVN version of the software?
>>>> No :-(, the security policy of a my laboratory is a little strict.
>> There
>>> is
>>>> no way to use the SVN repo externally (at home I cannot use it and
>> need
>>> to
>>>> be in my office to use it).
>>> If you can't give us access to the code but you are think to donate
>> the
>>> software to Felix, you (I can do that if you are busy) can move the
>>> sources to your Felix sandbox so that anyone can look at the code and
>>> improve it and later we can move the code to the Felix trunc area.
>>
>> +1 for moving it to the sandbox - for some reason clement's site is not
>> accessible from malaysia...
>>
>
> Strange things. I know it is not accessible from China, but no from
> Malaysia.
> About the move, we are discussing it with Maxime (French administration ...)
WAIT!! Do move the code to the sandbox so :S
I'm wondering if you sent to the AFSF all the required documentation or
if you have to sign and fax some more doc :S
Have you created the software on behalf of a company and/or government
organizations?
Anyone more expert in the topic should say its opinion :S
>
> Clement
>
>
>> Ciao,
>>> Stefano "Kismet" Lenzi
>>>
>> --
>> Cheers, Stuart
>
>
>
RE: [FELIX-219] Applying the patch
Posted by Clement Escoffier <cl...@gmail.com>.
> -----Message d'origine-----
> De : mcculls@gmail.com [mailto:mcculls@gmail.com] De la part de Stuart
> McCulloch
> Envoyé : mardi 28 août 2007 12:54
> À : dev@felix.apache.org
> Objet : Re: [FELIX-219] Applying the patch
>
> On 28/08/07, Stefano Lenzi <ki...@interfree.it> wrote:
> >
> > Clement Escoffier wrote:
> > >
> > >> -----Message d'origine-----
> > >> De : Stefano Lenzi [mailto:kismet@interfree.it]
> > >> Envoyé : vendredi 17 août 2007 12:18
> > >> À : dev@felix.apache.org
> > >> Cc : Maxime Vincent
> > >> Objet : Re: [FELIX-219] Applying the patch
> > >>
> > >> Clement Escoffier wrote:
> > >>> Hello,
> > >>>
> > >>>> -----Message d'origine-----
> > >>>> De : Stefano Lenzi [mailto:kismet@interfree.it]
> > >>>> Envoyé : jeudi 16 août 2007 11:48
> > >>>> À : dev@felix.apache.org
> > >>>> Objet : Re: [FELIX-219] Applying the patch
> > >>>>
> > >>>> Clement Escoffier wrote:
> > >>>>> Hello
> > >>>>>
> > >>>>> Maxime plug-in is available here :
> > >>>>> http://clement.plop-
> > >>>> plop.net/index.php?option=com_content&task=view&id=26&It
> > >>>>> emid=37
> > >>>>>
> > >>>>> (it is a long URL due to the CMS I use (Joomla), say me if you
> have
> > >>>> issues
> > >>>>> to access it).
> > >>>>>
> > >>>>> Sources are available at :
> > >>>>> http://clement.plop-plop.net/downloads/obr/tool.obr.plugin.zip
> > >>>> I looked at the plugin at it looks interesting, I have some
> question
> > >>>> about it:
> > >>>> - Do you plan to move such plugin in felix?
> > >>> I plan too. We need to finish tests before :-) and ask if it is
> > >> accepted.
> > >>> We need to improve locks when several peoples upload at the same
> > >> time, check
> > >>> XML file consistency ...
> > >> I think that such feature may be left for version 1.1, because if
> each
> > >> user use it's own file it works great :)
> > >>
> > >>>> - There is any maven repository for your plugin?
> > >>> No, that one of the problems.
> > >> If you want I can publish the plugin on a public non-default maven
> > >> repository....
> > >> ..we had only to improve the POM in order to use dependency and to
> add
> > >> LICENSE information at least.
> > >>
> >
> > What about the above questions?
> >
> > BTW, I'm planning to put a patched version of maven-bundle-plugin
> which
> > uses your plugin in my felix sandbox.
> >
> >
> > >>
> > >> Can I access to your SVN version of the software?
> > >
> > > No :-(, the security policy of a my laboratory is a little strict.
> There
> > is
> > > no way to use the SVN repo externally (at home I cannot use it and
> need
> > to
> > > be in my office to use it).
> >
> > If you can't give us access to the code but you are think to donate
> the
> > software to Felix, you (I can do that if you are busy) can move the
> > sources to your Felix sandbox so that anyone can look at the code and
> > improve it and later we can move the code to the Felix trunc area.
>
>
> +1 for moving it to the sandbox - for some reason clement's site is not
> accessible from malaysia...
>
Strange things. I know it is not accessible from China, but no from
Malaysia.
About the move, we are discussing it with Maxime (French administration ...)
Clement
> Ciao,
> > Stefano "Kismet" Lenzi
> >
>
> --
> Cheers, Stuart
Re: [FELIX-219] Applying the patch
Posted by Stuart McCulloch <st...@jayway.net>.
On 28/08/07, Stefano Lenzi <ki...@interfree.it> wrote:
>
> Clement Escoffier wrote:
> >
> >> -----Message d'origine-----
> >> De : Stefano Lenzi [mailto:kismet@interfree.it]
> >> Envoyé : vendredi 17 août 2007 12:18
> >> À : dev@felix.apache.org
> >> Cc : Maxime Vincent
> >> Objet : Re: [FELIX-219] Applying the patch
> >>
> >> Clement Escoffier wrote:
> >>> Hello,
> >>>
> >>>> -----Message d'origine-----
> >>>> De : Stefano Lenzi [mailto:kismet@interfree.it]
> >>>> Envoyé : jeudi 16 août 2007 11:48
> >>>> À : dev@felix.apache.org
> >>>> Objet : Re: [FELIX-219] Applying the patch
> >>>>
> >>>> Clement Escoffier wrote:
> >>>>> Hello
> >>>>>
> >>>>> Maxime plug-in is available here :
> >>>>> http://clement.plop-
> >>>> plop.net/index.php?option=com_content&task=view&id=26&It
> >>>>> emid=37
> >>>>>
> >>>>> (it is a long URL due to the CMS I use (Joomla), say me if you have
> >>>> issues
> >>>>> to access it).
> >>>>>
> >>>>> Sources are available at :
> >>>>> http://clement.plop-plop.net/downloads/obr/tool.obr.plugin.zip
> >>>> I looked at the plugin at it looks interesting, I have some question
> >>>> about it:
> >>>> - Do you plan to move such plugin in felix?
> >>> I plan too. We need to finish tests before :-) and ask if it is
> >> accepted.
> >>> We need to improve locks when several peoples upload at the same
> >> time, check
> >>> XML file consistency ...
> >> I think that such feature may be left for version 1.1, because if each
> >> user use it's own file it works great :)
> >>
> >>>> - There is any maven repository for your plugin?
> >>> No, that one of the problems.
> >> If you want I can publish the plugin on a public non-default maven
> >> repository....
> >> ..we had only to improve the POM in order to use dependency and to add
> >> LICENSE information at least.
> >>
>
> What about the above questions?
>
> BTW, I'm planning to put a patched version of maven-bundle-plugin which
> uses your plugin in my felix sandbox.
>
>
> >>
> >> Can I access to your SVN version of the software?
> >
> > No :-(, the security policy of a my laboratory is a little strict. There
> is
> > no way to use the SVN repo externally (at home I cannot use it and need
> to
> > be in my office to use it).
>
> If you can't give us access to the code but you are think to donate the
> software to Felix, you (I can do that if you are busy) can move the
> sources to your Felix sandbox so that anyone can look at the code and
> improve it and later we can move the code to the Felix trunc area.
+1 for moving it to the sandbox - for some reason clement's site is not
accessible from malaysia...
Ciao,
> Stefano "Kismet" Lenzi
>
--
Cheers, Stuart
Re: [FELIX-219] Applying the patch
Posted by Stefano Lenzi <ki...@interfree.it>.
Clement Escoffier wrote:
>
[cut]
>
> No there is no (accessible) Maven repo on which downloading the plugin. Feel
> free to publish it on a non-standard maven repo.
> (just send the URL). The licence is ASL.
>
> Clement
I'll let you know the URL :)
Stefano "Kismet" Lenzi
RE: [FELIX-219] Applying the patch
Posted by Clement Escoffier <cl...@gmail.com>.
> -----Message d'origine-----
> De : Stefano Lenzi [mailto:kismet@interfree.it]
> Envoyé : mardi 28 août 2007 12:12
> À : dev@felix.apache.org
> Objet : Re: [FELIX-219] Applying the patch
>
> Clement Escoffier wrote:
> >
> >> -----Message d'origine-----
> >> De : Stefano Lenzi [mailto:kismet@interfree.it]
> >> Envoyé : vendredi 17 août 2007 12:18
> >> À : dev@felix.apache.org
> >> Cc : Maxime Vincent
> >> Objet : Re: [FELIX-219] Applying the patch
> >>
> >> Clement Escoffier wrote:
> >>> Hello,
> >>>
> >>>> -----Message d'origine-----
> >>>> De : Stefano Lenzi [mailto:kismet@interfree.it]
> >>>> Envoyé : jeudi 16 août 2007 11:48
> >>>> À : dev@felix.apache.org
> >>>> Objet : Re: [FELIX-219] Applying the patch
> >>>>
> >>>> Clement Escoffier wrote:
> >>>>> Hello
> >>>>>
> >>>>> Maxime plug-in is available here :
> >>>>> http://clement.plop-
> >>>> plop.net/index.php?option=com_content&task=view&id=26&It
> >>>>> emid=37
> >>>>>
> >>>>> (it is a long URL due to the CMS I use (Joomla), say me if you
> have
> >>>> issues
> >>>>> to access it).
> >>>>>
> >>>>> Sources are available at :
> >>>>> http://clement.plop-plop.net/downloads/obr/tool.obr.plugin.zip
> >>>> I looked at the plugin at it looks interesting, I have some
> question
> >>>> about it:
> >>>> - Do you plan to move such plugin in felix?
> >>> I plan too. We need to finish tests before :-) and ask if it is
> >> accepted.
> >>> We need to improve locks when several peoples upload at the same
> >> time, check
> >>> XML file consistency ...
> >> I think that such feature may be left for version 1.1, because if
> each
> >> user use it's own file it works great :)
> >>
> >>>> - There is any maven repository for your plugin?
> >>> No, that one of the problems.
> >> If you want I can publish the plugin on a public non-default maven
> >> repository....
> >> ..we had only to improve the POM in order to use dependency and to
> add
> >> LICENSE information at least.
> >>
>
> What about the above questions?
>
> BTW, I'm planning to put a patched version of maven-bundle-plugin which
> uses your plugin in my felix sandbox.
>
>
No there is no (accessible) Maven repo on which downloading the plugin. Feel
free to publish it on a non-standard maven repo.
(just send the URL). The licence is ASL.
Clement
> >>
> >> Can I access to your SVN version of the software?
> >
> > No :-(, the security policy of a my laboratory is a little strict.
> There is
> > no way to use the SVN repo externally (at home I cannot use it and
> need to
> > be in my office to use it).
>
> If you can't give us access to the code but you are think to donate the
> software to Felix, you (I can do that if you are busy) can move the
> sources to your Felix sandbox so that anyone can look at the code and
> improve it and later we can move the code to the Felix trunc area.
>
> Ciao,
> Stefano "Kismet" Lenzi
Re: [FELIX-219] Applying the patch
Posted by Stefano Lenzi <ki...@interfree.it>.
Clement Escoffier wrote:
>
>> -----Message d'origine-----
>> De : Stefano Lenzi [mailto:kismet@interfree.it]
>> Envoyé : vendredi 17 août 2007 12:18
>> À : dev@felix.apache.org
>> Cc : Maxime Vincent
>> Objet : Re: [FELIX-219] Applying the patch
>>
>> Clement Escoffier wrote:
>>> Hello,
>>>
>>>> -----Message d'origine-----
>>>> De : Stefano Lenzi [mailto:kismet@interfree.it]
>>>> Envoyé : jeudi 16 août 2007 11:48
>>>> À : dev@felix.apache.org
>>>> Objet : Re: [FELIX-219] Applying the patch
>>>>
>>>> Clement Escoffier wrote:
>>>>> Hello
>>>>>
>>>>> Maxime plug-in is available here :
>>>>> http://clement.plop-
>>>> plop.net/index.php?option=com_content&task=view&id=26&It
>>>>> emid=37
>>>>>
>>>>> (it is a long URL due to the CMS I use (Joomla), say me if you have
>>>> issues
>>>>> to access it).
>>>>>
>>>>> Sources are available at :
>>>>> http://clement.plop-plop.net/downloads/obr/tool.obr.plugin.zip
>>>> I looked at the plugin at it looks interesting, I have some question
>>>> about it:
>>>> - Do you plan to move such plugin in felix?
>>> I plan too. We need to finish tests before :-) and ask if it is
>> accepted.
>>> We need to improve locks when several peoples upload at the same
>> time, check
>>> XML file consistency ...
>> I think that such feature may be left for version 1.1, because if each
>> user use it's own file it works great :)
>>
>>>> - There is any maven repository for your plugin?
>>> No, that one of the problems.
>> If you want I can publish the plugin on a public non-default maven
>> repository....
>> ..we had only to improve the POM in order to use dependency and to add
>> LICENSE information at least.
>>
What about the above questions?
BTW, I'm planning to put a patched version of maven-bundle-plugin which
uses your plugin in my felix sandbox.
>>
>> Can I access to your SVN version of the software?
>
> No :-(, the security policy of a my laboratory is a little strict. There is
> no way to use the SVN repo externally (at home I cannot use it and need to
> be in my office to use it).
If you can't give us access to the code but you are think to donate the
software to Felix, you (I can do that if you are busy) can move the
sources to your Felix sandbox so that anyone can look at the code and
improve it and later we can move the code to the Felix trunc area.
Ciao,
Stefano "Kismet" Lenzi
RE: [FELIX-219] Applying the patch
Posted by Clement Escoffier <cl...@gmail.com>.
Hello,
I am sorry for the delay, I was busy on an internal development.
> -----Message d'origine-----
> De : Stefano Lenzi [mailto:kismet@interfree.it]
> Envoyé : vendredi 17 août 2007 12:18
> À : dev@felix.apache.org
> Cc : Maxime Vincent
> Objet : Re: [FELIX-219] Applying the patch
>
> Clement Escoffier wrote:
> > Hello,
> >
> >> -----Message d'origine-----
> >> De : Stefano Lenzi [mailto:kismet@interfree.it]
> >> Envoyé : jeudi 16 août 2007 11:48
> >> À : dev@felix.apache.org
> >> Objet : Re: [FELIX-219] Applying the patch
> >>
> >> Clement Escoffier wrote:
> >>> Hello
> >>>
> >>> Maxime plug-in is available here :
> >>> http://clement.plop-
> >> plop.net/index.php?option=com_content&task=view&id=26&It
> >>> emid=37
> >>>
> >>> (it is a long URL due to the CMS I use (Joomla), say me if you have
> >> issues
> >>> to access it).
> >>>
> >>> Sources are available at :
> >>> http://clement.plop-plop.net/downloads/obr/tool.obr.plugin.zip
> >> I looked at the plugin at it looks interesting, I have some question
> >> about it:
> >> - Do you plan to move such plugin in felix?
> >
> > I plan too. We need to finish tests before :-) and ask if it is
> accepted.
> > We need to improve locks when several peoples upload at the same
> time, check
> > XML file consistency ...
>
> I think that such feature may be left for version 1.1, because if each
> user use it's own file it works great :)
>
> >
> >> - There is any maven repository for your plugin?
> >
> > No, that one of the problems.
>
> If you want I can publish the plugin on a public non-default maven
> repository....
> ..we had only to improve the POM in order to use dependency and to add
> LICENSE information at least.
>
> >
> >> - What is the license of your plugin?
> >
> > I should be ASL, as a Felix contribution (if it is accepted)
> >
> >> If your answers match the ASF requirement we may proceed in the
> >> following way:
> >> - Modify the maven-bundle-plugin in order to use the goal provided
> by
> >> your plugin
> >> - Modify the code of your plugin in order to use the Castor XML
> code
> >> generator
> >
> > For sure, using Castor seems to me the right approach. But first, we
> need to
> > write the OBR XML Schema (Castor input)
>
> I'm going to write it :)
>
> Can I access to your SVN version of the software?
No :-(, the security policy of a my laboratory is a little strict. There is
no way to use the SVN repo externally (at home I cannot use it and need to
be in my office to use it).
Clement
>
> >
> > Clement
> >
> >
> >
Re: [FELIX-219] Applying the patch
Posted by Stefano Lenzi <ki...@interfree.it>.
Clement Escoffier wrote:
> Hello,
>
>> -----Message d'origine-----
>> De : Stefano Lenzi [mailto:kismet@interfree.it]
>> Envoyé : jeudi 16 août 2007 11:48
>> À : dev@felix.apache.org
>> Objet : Re: [FELIX-219] Applying the patch
>>
>> Clement Escoffier wrote:
>>> Hello
>>>
>>> Maxime plug-in is available here :
>>> http://clement.plop-
>> plop.net/index.php?option=com_content&task=view&id=26&It
>>> emid=37
>>>
>>> (it is a long URL due to the CMS I use (Joomla), say me if you have
>> issues
>>> to access it).
>>>
>>> Sources are available at :
>>> http://clement.plop-plop.net/downloads/obr/tool.obr.plugin.zip
>> I looked at the plugin at it looks interesting, I have some question
>> about it:
>> - Do you plan to move such plugin in felix?
>
> I plan too. We need to finish tests before :-) and ask if it is accepted.
> We need to improve locks when several peoples upload at the same time, check
> XML file consistency ...
I think that such feature may be left for version 1.1, because if each
user use it's own file it works great :)
>
>> - There is any maven repository for your plugin?
>
> No, that one of the problems.
If you want I can publish the plugin on a public non-default maven
repository....
..we had only to improve the POM in order to use dependency and to add
LICENSE information at least.
>
>> - What is the license of your plugin?
>
> I should be ASL, as a Felix contribution (if it is accepted)
>
>> If your answers match the ASF requirement we may proceed in the
>> following way:
>> - Modify the maven-bundle-plugin in order to use the goal provided by
>> your plugin
>> - Modify the code of your plugin in order to use the Castor XML code
>> generator
>
> For sure, using Castor seems to me the right approach. But first, we need to
> write the OBR XML Schema (Castor input)
I'm going to write it :)
Can I access to your SVN version of the software?
>
> Clement
>
>
>
RE: [FELIX-219] Applying the patch
Posted by Clement Escoffier <cl...@gmail.com>.
Hello,
> -----Message d'origine-----
> De : Stefano Lenzi [mailto:kismet@interfree.it]
> Envoyé : jeudi 16 août 2007 11:48
> À : dev@felix.apache.org
> Objet : Re: [FELIX-219] Applying the patch
>
> Clement Escoffier wrote:
> > Hello
> >
> > Maxime plug-in is available here :
> > http://clement.plop-
> plop.net/index.php?option=com_content&task=view&id=26&It
> > emid=37
> >
> > (it is a long URL due to the CMS I use (Joomla), say me if you have
> issues
> > to access it).
> >
> > Sources are available at :
> > http://clement.plop-plop.net/downloads/obr/tool.obr.plugin.zip
>
> I looked at the plugin at it looks interesting, I have some question
> about it:
> - Do you plan to move such plugin in felix?
I plan too. We need to finish tests before :-) and ask if it is accepted.
We need to improve locks when several peoples upload at the same time, check
XML file consistency ...
> - There is any maven repository for your plugin?
No, that one of the problems.
> - What is the license of your plugin?
I should be ASL, as a Felix contribution (if it is accepted)
>
> If your answers match the ASF requirement we may proceed in the
> following way:
> - Modify the maven-bundle-plugin in order to use the goal provided by
> your plugin
> - Modify the code of your plugin in order to use the Castor XML code
> generator
For sure, using Castor seems to me the right approach. But first, we need to
write the OBR XML Schema (Castor input)
Clement
Re: [FELIX-219] Applying the patch
Posted by Stefano Lenzi <ki...@interfree.it>.
Clement Escoffier wrote:
> Hello
>
> Maxime plug-in is available here :
> http://clement.plop-plop.net/index.php?option=com_content&task=view&id=26&It
> emid=37
>
> (it is a long URL due to the CMS I use (Joomla), say me if you have issues
> to access it).
>
> Sources are available at :
> http://clement.plop-plop.net/downloads/obr/tool.obr.plugin.zip
I looked at the plugin at it looks interesting, I have some question
about it:
- Do you plan to move such plugin in felix?
- There is any maven repository for your plugin?
- What is the license of your plugin?
If your answers match the ASF requirement we may proceed in the
following way:
- Modify the maven-bundle-plugin in order to use the goal provided by
your plugin
- Modify the code of your plugin in order to use the Castor XML code
generator
I think that having two plugin for achieve the same goal it's a waste of
time and makes hard time for the new user.
>
> Maxime does not use a parser generator (despite I say him to use one !), so
> using Castor seems to me a good idea.
>
> About OBR V1, it is not in our plan (as the project, where we use the
> plug-in, began after the apparition of OBR V2). However, what will be the
> best between :
> - Supporting OBRv1
We may patch your plugin in order to provide such feature :)
> - a tools translating an OBR V1 file to OBR v2( perhaps it already exists).
I don't know any tools for that but I hope that someone of the community
may know some....
>
> Clement
>
RE: [FELIX-219] Applying the patch
Posted by Clement Escoffier <cl...@gmail.com>.
Hello
Maxime plug-in is available here :
http://clement.plop-plop.net/index.php?option=com_content&task=view&id=26&It
emid=37
(it is a long URL due to the CMS I use (Joomla), say me if you have issues
to access it).
Sources are available at :
http://clement.plop-plop.net/downloads/obr/tool.obr.plugin.zip
Maxime does not use a parser generator (despite I say him to use one !), so
using Castor seems to me a good idea.
About OBR V1, it is not in our plan (as the project, where we use the
plug-in, began after the apparition of OBR V2). However, what will be the
best between :
- Supporting OBRv1
- a tools translating an OBR V1 file to OBR v2( perhaps it already exists).
Clement
> -----Message d'origine-----
> De : Stefano Lenzi [mailto:kismet@interfree.it]
> Envoyé : mardi 14 août 2007 16:52
> À : dev@felix.apache.org
> Objet : Re: [FELIX-219] Applying the patch
>
> Clement Escoffier wrote:
> >> -----Message d'origine-----
> >> De : Richard S. Hall [mailto:heavy@ungoverned.org]
> >> Envoyé : vendredi 10 août 2007 18:13
> >> À : dev@felix.apache.org
> >> Objet : Re: [FELIX-219] Applying the patch
> >>
> >> ...
> >> I think getting support in the bundle plugin for OBR is a good
> thing,
> >> but any changes to OBR and/or the schema would have to be seriously
> >> debated. As far as I know, Maxine's plugin does not require
> >> modifications to OBR...
> >>
> >
> > I confirm, Maxime plug-in does not require modifications to OBR. It
> work
> > fine with the actual OBR bundle (The repository
> > http://plop-plop.net/bundles/obr/repository.xml has been populated by
> using
> > Maxime plug-in). However Tim's plug-in requires an OBR modification
> due to
> > an issue inside Modelo, a tools used to generate the OBR descriptor
> parser.
>
> I wasn't aware of the Maxime plugin-in so I'll be happy if you can
> provide me a link to it :)
>
> Also I agree that we should not change the OBRv2 XML Schema because
> modello-maven-plugin doesn't support it. In fact I was thinking to move
> the code generation from modello-maven-plugin to castor-maven-plugin in
> order to patch the maven-bundle-plugin in order to do not change the
> OBRv2 XML Schema.
>
> What do you think about adding the support for OBRv1?
>
> Ciao,
> Stefano "Kismet" Lenzi
Re: [FELIX-219] Applying the patch
Posted by Stefano Lenzi <ki...@interfree.it>.
Clement Escoffier wrote:
>> -----Message d'origine-----
>> De : Richard S. Hall [mailto:heavy@ungoverned.org]
>> Envoyé : vendredi 10 août 2007 18:13
>> À : dev@felix.apache.org
>> Objet : Re: [FELIX-219] Applying the patch
>>
>> ...
>> I think getting support in the bundle plugin for OBR is a good thing,
>> but any changes to OBR and/or the schema would have to be seriously
>> debated. As far as I know, Maxine's plugin does not require
>> modifications to OBR...
>>
>
> I confirm, Maxime plug-in does not require modifications to OBR. It work
> fine with the actual OBR bundle (The repository
> http://plop-plop.net/bundles/obr/repository.xml has been populated by using
> Maxime plug-in). However Tim's plug-in requires an OBR modification due to
> an issue inside Modelo, a tools used to generate the OBR descriptor parser.
I wasn't aware of the Maxime plugin-in so I'll be happy if you can
provide me a link to it :)
Also I agree that we should not change the OBRv2 XML Schema because
modello-maven-plugin doesn't support it. In fact I was thinking to move
the code generation from modello-maven-plugin to castor-maven-plugin in
order to patch the maven-bundle-plugin in order to do not change the
OBRv2 XML Schema.
What do you think about adding the support for OBRv1?
Ciao,
Stefano "Kismet" Lenzi
RE: [FELIX-219] Applying the patch
Posted by Clement Escoffier <cl...@gmail.com>.
> -----Message d'origine-----
> De : Richard S. Hall [mailto:heavy@ungoverned.org]
> Envoyé : vendredi 10 août 2007 18:13
> À : dev@felix.apache.org
> Objet : Re: [FELIX-219] Applying the patch
>
> ...
> I think getting support in the bundle plugin for OBR is a good thing,
> but any changes to OBR and/or the schema would have to be seriously
> debated. As far as I know, Maxine's plugin does not require
> modifications to OBR...
>
I confirm, Maxime plug-in does not require modifications to OBR. It work
fine with the actual OBR bundle (The repository
http://plop-plop.net/bundles/obr/repository.xml has been populated by using
Maxime plug-in). However Tim's plug-in requires an OBR modification due to
an issue inside Modelo, a tools used to generate the OBR descriptor parser.
Clement
Re: [FELIX-219] Applying the patch
Posted by "Richard S. Hall" <he...@ungoverned.org>.
Stefano Lenzi wrote:
> Hi All,
>
> I'd like to know if anyone of you have spent some time on the patch
> FELIX-219 available on JIRA. IMHO we should apply it, but before doing
> that on my own I'd like to get some feedback from you :)
>
> Please note that the above patch affects also the OBR bundle and it
> changes the XML schema used by OBR, but I think that will be easy to
> fix if you don't like that part.
I think getting support in the bundle plugin for OBR is a good thing,
but any changes to OBR and/or the schema would have to be seriously
debated. As far as I know, Maxine's plugin does not require
modifications to OBR...
-> richard