You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/24 23:15:35 UTC

[GitHub] [ozone] amaliujia opened a new pull request #1735: HDDS-4623. Update CountQuota to NamesapceQuota

amaliujia opened a new pull request #1735:
URL: https://github.com/apache/ozone/pull/1735


   ## What changes were proposed in this pull request?
   
   Use more description words "namespace quota" to replace "count quota".
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-4623
   
   ## How was this patch tested?
   
   UT
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] captainzmc commented on a change in pull request #1735: HDDS-4623. Update CountQuota to NamesapceQuota

Posted by GitBox <gi...@apache.org>.
captainzmc commented on a change in pull request #1735:
URL: https://github.com/apache/ozone/pull/1735#discussion_r548780848



##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java
##########
@@ -432,7 +432,7 @@ public void clearSpaceQuota() throws IOException {
    *
    * @throws IOException
    */
-  public void clearCountQuota() throws IOException {
+  public void clearNamespaceQuota() throws IOException {

Review comment:
       The method description also needs to be update.

##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneVolume.java
##########
@@ -300,7 +300,7 @@ public void clearSpaceQuota() throws IOException {
    *
    * @throws IOException
    */
-  public void clearCountQuota() throws IOException {
+  public void clearNamespaceQuota() throws IOException {

Review comment:
       Same as above

##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/ClearSpaceQuotaOptions.java
##########
@@ -30,14 +30,14 @@
 
   @CommandLine.Option(names = {"--namespace-quota"},
       description = "clear count quota")

Review comment:
       update description.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] amaliujia commented on pull request #1735: HDDS-4623. Update CountQuota to NamesapceQuota

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1735:
URL: https://github.com/apache/ozone/pull/1735#issuecomment-751130159


   R: @captainzmc 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] amaliujia commented on pull request #1735: HDDS-4623. Update CountQuota to NamesapceQuota

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1735:
URL: https://github.com/apache/ozone/pull/1735#issuecomment-751186348


   @captainzmc  
   
   comments addressed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] captainzmc merged pull request #1735: HDDS-4623. Update CountQuota to NamesapceQuota

Posted by GitBox <gi...@apache.org>.
captainzmc merged pull request #1735:
URL: https://github.com/apache/ozone/pull/1735


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org