[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3920: Fix fragile unit test in NetworkNodeUnitTest

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #3920: Fix fragile unit test in NetworkNodeUnitTest
URL: https://github.com/apache/trafficcontrol/pull/3920#discussion_r323844441
 
 

 ##########
 File path: traffic_router/core/src/test/java/com/comcast/cdn/traffic_control/traffic_router/core/loc/NetworkNodeUnitTest.java
 ##########
 @@ -188,7 +188,7 @@ public void itRejectsInvalidIpV4Network() throws Exception {
             "\"customerName\": \"Kabletown\"," +
             "\"coverageZones\": {" +
             "\"us-co-denver\": {" +
-            "\"network\": [\"192.168.55.258/24\",\"192.168.6.0/24\",\"192.168.0.0/16\"]," +
+            "\"network\": [\"192.168.55.0/40\",\"192.168.6.0/24\",\"192.168.0.0/16\"]," +
 
 Review comment:
   So 258 is an invalid IP address but /40 is an invalid IPv4 mask length. Does `192.168.55.0/24` fix the test? Or even something in `192.0.2.0/24`, which is really the reserved "test" range for IPv4 addresses?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services