You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Kamuela Lau (JIRA)" <ji...@apache.org> on 2018/10/09 05:14:00 UTC
[jira] [Commented] (SOLR-12367) When adding a model referencing a
non-existent feature the error message is very ambiguous
[ https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642809#comment-16642809 ]
Kamuela Lau commented on SOLR-12367:
------------------------------------
I have attached a new patch, which includes some minor refractoring from the old patch, as well as a "fix" for the issue noted in the comments; there is now a different error message for the case when an int/long is entered in weights instead of a float/double.
> When adding a model referencing a non-existent feature the error message is very ambiguous
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
> Affects Versions: 7.3.1
> Reporter: Georg Sorst
> Priority: Minor
> Attachments: SOLR-12367.patch, SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous error message is thrown, something like "Model type does not exist org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store' --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0}}}}
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org