You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/08/10 09:05:15 UTC
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 7:05 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Summary (updated)
-----------------
Maintenance Primitives: Added updateUnavailability to master.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629
src/master/master.hpp 28356e4ca24312b8be0138a34805b3d9035a99a3
src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63
src/tests/master_tests.cpp a4703afc331244a9e959c48652342f31ef787288
src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2
Diff: https://reviews.apache.org/r/37175/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review95156
-----------------------------------------------------------
Ship it!
src/master/master.hpp (line 475)
<https://reviews.apache.org/r/37175/#comment149996>
MachineInfo
src/master/master.cpp (line 4038)
<https://reviews.apache.org/r/37175/#comment149997>
MachineInfo
src/master/master.cpp (line 4066)
<https://reviews.apache.org/r/37175/#comment149992>
Maybe have a check for:
`Try<Duration> duration = Druation::create(unavailability.get().duration());`
- Joseph Wu
On Aug. 10, 2015, 12:05 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 12:05 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629
> src/master/master.hpp 28356e4ca24312b8be0138a34805b3d9035a99a3
> src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63
> src/tests/master_tests.cpp a4703afc331244a9e959c48652342f31ef787288
> src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Sept. 14, 2015, 12:37 a.m., Qian Zhang wrote:
> > src/master/master.cpp, lines 4131-4134
> > <https://reviews.apache.org/r/37175/diff/7/?file=1071163#file1071163line4131>
> >
> > I think we have done this in Master::Http::maintenanceSchedule(), so why we do it again here? Maybe remove the duplicated code from Master::Http::maintenanceSchedule()?
You are right! Thanks for catching this :-)
Fixed in updated review.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review98790
-----------------------------------------------------------
On Sept. 14, 2015, 12:46 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 12:46 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
> src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review98790
-----------------------------------------------------------
src/master/master.cpp (lines 4131 - 4134)
<https://reviews.apache.org/r/37175/#comment155393>
I think we have done this in Master::Http::maintenanceSchedule(), so why we do it again here? Maybe remove the duplicated code from Master::Http::maintenanceSchedule()?
- Qian Zhang
On Sept. 14, 2015, 4:33 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 4:33 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
> src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review98798
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
> src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 12:46 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
Diff: https://reviews.apache.org/r/37175/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/
-----------------------------------------------------------
(Updated Sept. 13, 2015, 8:33 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
Diff: https://reviews.apache.org/r/37175/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Sept. 2, 2015, 10:04 p.m., Joseph Wu wrote:
> > include/mesos/master/allocator.hpp, lines 138-141
> > <https://reviews.apache.org/r/37175/diff/6/?file=1062494#file1062494line138>
> >
> > Consider Doxygen-ification.
I don't want to start another debate around "mixed vs not mixed doxygen comments"; so we can doxygenify this whole file in a separate review :-)
Thanks for looking out though!
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review97527
-----------------------------------------------------------
On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
> src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review97527
-----------------------------------------------------------
Ship it!
include/mesos/master/allocator.hpp (lines 138 - 141)
<https://reviews.apache.org/r/37175/#comment153481>
Consider Doxygen-ification.
src/master/http.cpp (lines 1448 - 1450)
<https://reviews.apache.org/r/37175/#comment153482>
You'll probably want to delete this line, since `updateUnavailability` does that for us.
src/master/http.cpp (line 1466)
<https://reviews.apache.org/r/37175/#comment153486>
You'll probably want to delete this line, since `updateUnavailability` does that for us.
src/tests/master_maintenance_tests.cpp (lines 360 - 361)
<https://reviews.apache.org/r/37175/#comment153491>
Rebase mistake?
- Joseph Wu
On Sept. 2, 2015, 12:31 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 12:31 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
> src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
> src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
> src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 7:31 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569
Diff: https://reviews.apache.org/r/37175/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review96814
-----------------------------------------------------------
Ship it!
include/mesos/master/allocator.hpp (line 138)
<https://reviews.apache.org/r/37175/#comment152478>
Please document what this function is for!!!!
src/master/allocator/mesos/hierarchical.hpp (line 838)
<https://reviews.apache.org/r/37175/#comment152482>
// Any old maintenace ...
slaves[slaveId].maintenance = None();
// If we have a new unavail ..
if (unavailability.isSome()) {
slaves[slaveId].maintenance = unavailaility.get();
}
src/master/master.cpp (line 3830)
<https://reviews.apache.org/r/37175/#comment152485>
s/ip/IP/
src/master/master.cpp (line 3844)
<https://reviews.apache.org/r/37175/#comment152486>
s/ip/IP/
src/master/master.cpp (line 4164)
<https://reviews.apache.org/r/37175/#comment152480>
s/Note/NOTE/
src/tests/master_maintenance_tests.cpp (line 215)
<https://reviews.apache.org/r/37175/#comment152489>
How about moving this to the test fixture?
src/tests/master_maintenance_tests.cpp (line 217)
<https://reviews.apache.org/r/37175/#comment152484>
Do you need the 'this->' here? My guess is not because this isn't a templated test, but you probably copied this from a templated test.
Also, let's implement 'CreateSlaveFlags' in the test fixture so all tests get this and then we can just call 'StartSlave' without having to pass it any flags.
src/tests/master_maintenance_tests.cpp (line 219)
<https://reviews.apache.org/r/37175/#comment152483>
Newline between these two "thoughts" please.
src/tests/master_maintenance_tests.cpp (line 261)
<https://reviews.apache.org/r/37175/#comment152488>
s/Duration/Time/
src/tests/master_maintenance_tests.cpp (lines 289 - 290)
<https://reviews.apache.org/r/37175/#comment152487>
Can we make a comparison operator for TimeInfo and Time?
- Benjamin Hindman
On Aug. 26, 2015, 2:12 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 2:12 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
> src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
> src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/master_maintenance_tests.cpp PRE-CREATION
> src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 2:12 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/master_maintenance_tests.cpp PRE-CREATION
src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb
Diff: https://reviews.apache.org/r/37175/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review96370
-----------------------------------------------------------
After the TimeSpec change:
src/master/master.cpp (lines 4139 - 4143)
<https://reviews.apache.org/r/37175/#comment151700>
Should be possible to do something like:
```
Duration start = Seconds(unavailability.get().start().seconds()) + Nanoseconds(unavailability.get().start().nanoseconds());
LOG(INFO) << "..." << start.secs();
```
- Joseph Wu
On Aug. 24, 2015, 7:12 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 7:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629
> src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
> src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/master_maintenance_tests.cpp PRE-CREATION
> src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 2:12 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629
src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/master_maintenance_tests.cpp PRE-CREATION
src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb
Diff: https://reviews.apache.org/r/37175/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Aug. 18, 2015, 9:33 p.m., Joseph Wu wrote:
> > src/master/master.hpp, line 478
> > <https://reviews.apache.org/r/37175/diff/3/?file=1043316#file1043316line478>
> >
> > Why is this return type `Nothing`, instead of `void`?
It was `Nothing` as I was calling this function from the tests before. It needed to be `Nothing` for `dispatch` to work as `Future<void>` is invalid. This is no longer necessary due to your helper functions.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review95783
-----------------------------------------------------------
On Aug. 18, 2015, 6:57 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 6:57 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629
> src/master/http.cpp a73ee17bcef72791b06240a4673f466de582c41b
> src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/master_maintenance_tests.cpp PRE-CREATION
> src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review95783
-----------------------------------------------------------
Ship it!
LGTM except for one little thing:
src/master/master.hpp (line 478)
<https://reviews.apache.org/r/37175/#comment150913>
Why is this return type `Nothing`, instead of `void`?
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 11:57 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629
> src/master/http.cpp a73ee17bcef72791b06240a4673f466de582c41b
> src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/master_maintenance_tests.cpp PRE-CREATION
> src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/
-----------------------------------------------------------
(Updated Aug. 18, 2015, 6:57 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629
src/master/http.cpp a73ee17bcef72791b06240a4673f466de582c41b
src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/master_maintenance_tests.cpp PRE-CREATION
src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c
Diff: https://reviews.apache.org/r/37175/diff/
Testing
-------
Thanks,
Joris Van Remoortere