You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "vtlim (via GitHub)" <gi...@apache.org> on 2023/02/21 19:16:25 UTC
[GitHub] [druid] vtlim commented on a diff in pull request #13819: Add Post Aggregators for Tuple Sketches
vtlim commented on code in PR #13819:
URL: https://github.com/apache/druid/pull/13819#discussion_r1113471425
##########
docs/development/extensions-core/datasketches-tuple.md:
##########
@@ -207,3 +207,39 @@ Returns a human-readable summary of a given ArrayOfDoublesSketch. This is a stri
"field" : <post aggregator that refers to an ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
}
```
+
+
+### Constant ArrayOfDoublesSketch
+
+You can use the this post aggregator to add a Base64-encoded constant ArrayOfDoublesSketch value for use in other post-aggregators.
Review Comment:
```suggestion
This post aggregator adds a Base64-encoded constant ArrayOfDoublesSketch value that you can use in other post aggregators.
```
Not sure if what is meant by "adds". Would it be accurate to say "generates" or "outputs"?
##########
docs/development/extensions-core/datasketches-tuple.md:
##########
@@ -207,3 +207,39 @@ Returns a human-readable summary of a given ArrayOfDoublesSketch. This is a stri
"field" : <post aggregator that refers to an ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
}
```
+
+
+### Constant ArrayOfDoublesSketch
+
+You can use the this post aggregator to add a Base64-encoded constant ArrayOfDoublesSketch value for use in other post-aggregators.
+```json
+{
+ "type" : "arrayOfDoublesSketchConstant",
+ "name": DESTINATION_COLUMN_NAME,
+ "value" : CONSTANT_SKETCH_VALUE
+}
+```
+
+### Base64 Output of ArrayOfDoublesSketch
Review Comment:
```suggestion
### Base64 output of ArrayOfDoublesSketch
```
##########
docs/development/extensions-core/datasketches-tuple.md:
##########
@@ -207,3 +207,39 @@ Returns a human-readable summary of a given ArrayOfDoublesSketch. This is a stri
"field" : <post aggregator that refers to an ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
}
```
+
+
+### Constant ArrayOfDoublesSketch
+
+You can use the this post aggregator to add a Base64-encoded constant ArrayOfDoublesSketch value for use in other post-aggregators.
+```json
+{
+ "type" : "arrayOfDoublesSketchConstant",
+ "name": DESTINATION_COLUMN_NAME,
+ "value" : CONSTANT_SKETCH_VALUE
Review Comment:
```suggestion
"type": "arrayOfDoublesSketchConstant",
"name": DESTINATION_COLUMN_NAME,
"value": CONSTANT_SKETCH_VALUE
```
##########
docs/development/extensions-core/datasketches-tuple.md:
##########
@@ -207,3 +207,39 @@ Returns a human-readable summary of a given ArrayOfDoublesSketch. This is a stri
"field" : <post aggregator that refers to an ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
}
```
+
+
+### Constant ArrayOfDoublesSketch
+
+You can use the this post aggregator to add a Base64-encoded constant ArrayOfDoublesSketch value for use in other post-aggregators.
+```json
+{
+ "type" : "arrayOfDoublesSketchConstant",
+ "name": DESTINATION_COLUMN_NAME,
+ "value" : CONSTANT_SKETCH_VALUE
+}
+```
+
+### Base64 Output of ArrayOfDoublesSketch
+
+You can use the this post aggregator to output an ArrayOfDoublesSketch as Base64-encoded string constant tuple sketch value for use in other post-aggregators.
Review Comment:
```suggestion
This post aggregator outputs an ArrayOfDoublesSketch as a Base64-encoded string storing the constant tuple sketch value that you can use in other post aggregators.
```
##########
docs/development/extensions-core/datasketches-tuple.md:
##########
@@ -207,3 +207,39 @@ Returns a human-readable summary of a given ArrayOfDoublesSketch. This is a stri
"field" : <post aggregator that refers to an ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
}
```
+
+
+### Constant ArrayOfDoublesSketch
+
+You can use the this post aggregator to add a Base64-encoded constant ArrayOfDoublesSketch value for use in other post-aggregators.
+```json
+{
+ "type" : "arrayOfDoublesSketchConstant",
+ "name": DESTINATION_COLUMN_NAME,
+ "value" : CONSTANT_SKETCH_VALUE
+}
+```
+
+### Base64 Output of ArrayOfDoublesSketch
+
+You can use the this post aggregator to output an ArrayOfDoublesSketch as Base64-encoded string constant tuple sketch value for use in other post-aggregators.
+
+```json
+{
+ "type" : "arrayOfDoublesSketchToBase64String",
+ "name": DESTINATION_COLUMN_NAME,
+ "field" : <post aggregator that refers to a ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
+}
+```
+
+### Estimated Metrics values for each column of ArrayOfDoublesSketch
+
+You can use this post aggregator to return a list of estimated values(sum) from a given ArrayOfDoublesSketch. The result will be N double values, where N is the number of double values kept in the sketch per key.
Review Comment:
What does the `(sum)` mean here?
##########
docs/development/extensions-core/datasketches-tuple.md:
##########
@@ -207,3 +207,39 @@ Returns a human-readable summary of a given ArrayOfDoublesSketch. This is a stri
"field" : <post aggregator that refers to an ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
}
```
+
+
+### Constant ArrayOfDoublesSketch
+
+You can use the this post aggregator to add a Base64-encoded constant ArrayOfDoublesSketch value for use in other post-aggregators.
+```json
+{
+ "type" : "arrayOfDoublesSketchConstant",
+ "name": DESTINATION_COLUMN_NAME,
+ "value" : CONSTANT_SKETCH_VALUE
+}
+```
+
+### Base64 Output of ArrayOfDoublesSketch
+
+You can use the this post aggregator to output an ArrayOfDoublesSketch as Base64-encoded string constant tuple sketch value for use in other post-aggregators.
+
+```json
+{
+ "type" : "arrayOfDoublesSketchToBase64String",
+ "name": DESTINATION_COLUMN_NAME,
+ "field" : <post aggregator that refers to a ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
Review Comment:
```suggestion
"type": "arrayOfDoublesSketchToBase64String",
"name": DESTINATION_COLUMN_NAME,
"field": <post aggregator that refers to a ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
```
##########
docs/development/extensions-core/datasketches-tuple.md:
##########
@@ -207,3 +207,39 @@ Returns a human-readable summary of a given ArrayOfDoublesSketch. This is a stri
"field" : <post aggregator that refers to an ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
}
```
+
+
+### Constant ArrayOfDoublesSketch
+
+You can use the this post aggregator to add a Base64-encoded constant ArrayOfDoublesSketch value for use in other post-aggregators.
+```json
+{
+ "type" : "arrayOfDoublesSketchConstant",
+ "name": DESTINATION_COLUMN_NAME,
+ "value" : CONSTANT_SKETCH_VALUE
+}
+```
+
+### Base64 Output of ArrayOfDoublesSketch
+
+You can use the this post aggregator to output an ArrayOfDoublesSketch as Base64-encoded string constant tuple sketch value for use in other post-aggregators.
+
+```json
+{
+ "type" : "arrayOfDoublesSketchToBase64String",
+ "name": DESTINATION_COLUMN_NAME,
+ "field" : <post aggregator that refers to a ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
+}
+```
+
+### Estimated Metrics values for each column of ArrayOfDoublesSketch
+
+You can use this post aggregator to return a list of estimated values(sum) from a given ArrayOfDoublesSketch. The result will be N double values, where N is the number of double values kept in the sketch per key.
+
+```json
+{
+ "type" : "arrayOfDoublesSketchToMetricsEstimate",
+ "name": DESTINATION_COLUMN_NAME,
+ "field" : <post aggregator that refers to a ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
Review Comment:
```suggestion
"type": "arrayOfDoublesSketchToMetricsEstimate",
"name": DESTINATION_COLUMN_NAME,
"field": <post aggregator that refers to a ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
```
##########
docs/development/extensions-core/datasketches-tuple.md:
##########
@@ -207,3 +207,39 @@ Returns a human-readable summary of a given ArrayOfDoublesSketch. This is a stri
"field" : <post aggregator that refers to an ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
}
```
+
+
+### Constant ArrayOfDoublesSketch
+
+You can use the this post aggregator to add a Base64-encoded constant ArrayOfDoublesSketch value for use in other post-aggregators.
+```json
+{
+ "type" : "arrayOfDoublesSketchConstant",
+ "name": DESTINATION_COLUMN_NAME,
+ "value" : CONSTANT_SKETCH_VALUE
+}
+```
+
+### Base64 Output of ArrayOfDoublesSketch
+
+You can use the this post aggregator to output an ArrayOfDoublesSketch as Base64-encoded string constant tuple sketch value for use in other post-aggregators.
+
+```json
+{
+ "type" : "arrayOfDoublesSketchToBase64String",
+ "name": DESTINATION_COLUMN_NAME,
+ "field" : <post aggregator that refers to a ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
+}
+```
+
+### Estimated Metrics values for each column of ArrayOfDoublesSketch
+
+You can use this post aggregator to return a list of estimated values(sum) from a given ArrayOfDoublesSketch. The result will be N double values, where N is the number of double values kept in the sketch per key.
Review Comment:
```suggestion
This post aggregator returns a list of estimated values(sum) from a given ArrayOfDoublesSketch. The result is _N_ double values, where _N_ is the number of double values kept in the sketch per key.
```
##########
docs/development/extensions-core/datasketches-tuple.md:
##########
@@ -207,3 +207,39 @@ Returns a human-readable summary of a given ArrayOfDoublesSketch. This is a stri
"field" : <post aggregator that refers to an ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
}
```
+
+
+### Constant ArrayOfDoublesSketch
+
+You can use the this post aggregator to add a Base64-encoded constant ArrayOfDoublesSketch value for use in other post-aggregators.
+```json
+{
+ "type" : "arrayOfDoublesSketchConstant",
+ "name": DESTINATION_COLUMN_NAME,
+ "value" : CONSTANT_SKETCH_VALUE
+}
+```
+
+### Base64 Output of ArrayOfDoublesSketch
+
+You can use the this post aggregator to output an ArrayOfDoublesSketch as Base64-encoded string constant tuple sketch value for use in other post-aggregators.
+
+```json
+{
+ "type" : "arrayOfDoublesSketchToBase64String",
+ "name": DESTINATION_COLUMN_NAME,
+ "field" : <post aggregator that refers to a ArrayOfDoublesSketch (fieldAccess or another post aggregator)>
+}
+```
+
+### Estimated Metrics values for each column of ArrayOfDoublesSketch
Review Comment:
```suggestion
### Estimated metrics values for each column of ArrayOfDoublesSketch
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org