[GitHub] [solr] madrob commented on a change in pull request #729: SOLR-16074 WIP

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #729:
URL: https://github.com/apache/solr/pull/729#discussion_r819976837



##########
File path: gradle/validation/forbidden-apis/commons-io.commons-io.all.txt
##########
@@ -0,0 +1,2 @@
+@defaultMessage Use org.apache.commons.io.file.PathUtils#deleteDirectory(java.nio.file.Path) instead

Review comment:
       Can you move the last few lines of defaults.all.txt to keep all the commons io stuff together?

##########
File path: solr/core/src/test/org/apache/solr/rest/schema/analysis/TestManagedSynonymFilterFactory.java
##########
@@ -64,7 +65,7 @@ private void after() throws Exception {
       jetty = null;
     }
     if (null != tmpSolrHome) {
-      FileUtils.deleteDirectory(tmpSolrHome);
+      PathUtils.deleteDirectory(tmpSolrHome.toPath());

Review comment:
       This one could also be declared as a path, I think

##########
File path: solr/modules/ltr/src/test/org/apache/solr/ltr/TestRerankBase.java
##########
@@ -198,7 +199,7 @@ protected static void aftertest() throws Exception {
       jetty = null;
     }
     if (null != tmpSolrHome) {
-      FileUtils.deleteDirectory(tmpSolrHome);
+      PathUtils.deleteDirectory(tmpSolrHome.toPath());

Review comment:
       If we change tmpSolrHome from File to Path than that cleans up a bunch of other crusty bits like this too. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org