You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "maobaolong (via GitHub)" <gi...@apache.org> on 2024/08/15 04:14:21 UTC
[PR] [#2048] feat(coordinator): Introduce dashboard page in dashboard web ui [incubator-uniffle]
maobaolong opened a new pull request, #2049:
URL: https://github.com/apache/incubator-uniffle/pull/2049
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Introduce dashboard page in dashboard web ui to show the version, start time and other information about dashboard.
### Why are the changes needed?
Fix: #2048
### Does this PR introduce _any_ user-facing change?
Dashboard UI
### How was this patch tested?
<img width="1435" alt="image" src="https://github.com/user-attachments/assets/410cae37-ecf3-47ea-a769-a290514dec45">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2048] feat(coordinator): Introduce dashboard page in dashboard web ui [incubator-uniffle]
Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #2049:
URL: https://github.com/apache/incubator-uniffle/pull/2049#issuecomment-2303888583
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2048] feat(coordinator): Introduce dashboard page in dashboard web ui [incubator-uniffle]
Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #2049:
URL: https://github.com/apache/incubator-uniffle/pull/2049#issuecomment-2296687384
Isn’t it too monotonous to make a separate page display version and a startup time for the dashboard?
My humble opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2048] feat(coordinator): Introduce dashboard page in dashboard web ui [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2049:
URL: https://github.com/apache/incubator-uniffle/pull/2049#issuecomment-2290580717
## Test Results
2 792 files ±0 2 792 suites ±0 5h 49m 36s :stopwatch: - 2m 7s
988 tests ±0 987 :white_check_mark: +1 1 :zzz: ±0 0 :x: - 1
12 403 runs ±0 12 388 :white_check_mark: +1 15 :zzz: ±0 0 :x: - 1
Results for commit 8f1ee63f. ± Comparison against base commit 8dfa2a7e.
[test-results]:data:application/gzip;base64,H4sIAFCGvWYC/03NSw7CIBhG0a00jB0APxZwM6a8EmIfhsKoce8ClsqE5B7Ix4Gcn+2OHgPlkt4GtCcf+zYpTNFvaxEs+Zgp38fyQgrR6rknrSvxP738OxO5wE1+zoAvsCFs4ZSQ1rJJKMNwZhslFOpPPztX7w261dr9qN6WxcccSDhi7QjOTIoClpoJw50Cmg9GhNZAuLEgFPp8AYxQsGcSAQAA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2048] feat(coordinator): Introduce dashboard page in dashboard web ui [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong closed pull request #2049: [#2048] feat(coordinator): Introduce dashboard page in dashboard web ui
URL: https://github.com/apache/incubator-uniffle/pull/2049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2048] feat(coordinator): Introduce dashboard page in dashboard web ui [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #2049:
URL: https://github.com/apache/incubator-uniffle/pull/2049#issuecomment-2295584376
Could you help review this @yl09099 @xianjingfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2048] feat(coordinator): Introduce dashboard page in dashboard web ui [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #2049:
URL: https://github.com/apache/incubator-uniffle/pull/2049#issuecomment-2297822566
<img width="2426" alt="image" src="https://github.com/user-attachments/assets/3dd2df15-4045-4b74-b02d-e5e88b9df359">
I add config table to dashboard page, PTAL @yl09099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2048] feat(coordinator): Introduce dashboard page in dashboard web ui [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #2049:
URL: https://github.com/apache/incubator-uniffle/pull/2049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2048] feat(coordinator): Introduce dashboard page in dashboard web ui [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #2049:
URL: https://github.com/apache/incubator-uniffle/pull/2049#issuecomment-2304491401
Thanks @maobaolong @yl09099 @xianjingfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2048] feat(coordinator): Introduce dashboard page in dashboard web ui [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #2049:
URL: https://github.com/apache/incubator-uniffle/pull/2049#issuecomment-2297770781
@yl09099 Thanks for your reply. I do agree with your opinion for now, the main motivation of this PR is displaying the version and start time of dashboard process in the dashboard ui, but I can make it display more information in the dashboard page, e.g. config table. I believe it can be better if we add a config table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2048] feat(coordinator): Introduce dashboard page in dashboard web ui [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong closed pull request #2049: [#2048] feat(coordinator): Introduce dashboard page in dashboard web ui
URL: https://github.com/apache/incubator-uniffle/pull/2049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org