You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/11 00:29:09 UTC
[GitHub] [fineract] francisguchie opened a new pull request #1661: FINERACT-1330 check balance at transaction date also do not violate o…
francisguchie opened a new pull request #1661:
URL: https://github.com/apache/fineract/pull/1661
…verdaft settings
A detailed explanations is give here https://issues.apache.org/jira/browse/FINERACT-1330
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1661: FINERACT-1330 check balance at transaction date also do not violate o…
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1661:
URL: https://github.com/apache/fineract/pull/1661#issuecomment-798527005
@vorburger
> @francisguchie this seems to have a Spotbugs violation you'll need to fix.
This is is work in progress already
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1661: FINERACT-1330 check balance at transaction date also do not violate o…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1661:
URL: https://github.com/apache/fineract/pull/1661#issuecomment-821906552
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1661: FINERACT-1330 check balance at transaction date also do not violate o…
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1661:
URL: https://github.com/apache/fineract/pull/1661#issuecomment-798509592
@francisguchie this seems to have a Spotbugs violation you'll need to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1661: FINERACT-1330 check balance at transaction date also do not violate o…
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1661:
URL: https://github.com/apache/fineract/pull/1661#issuecomment-798559788
> @francisguchie this seems to have a Spotbugs violation you'll need to fix.
I hope its fixed now @vorburger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie closed pull request #1661: FINERACT-1330 check balance at transaction date also do not violate o…
Posted by GitBox <gi...@apache.org>.
francisguchie closed pull request #1661:
URL: https://github.com/apache/fineract/pull/1661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1661: FINERACT-1330 check balance at transaction date also do not violate o…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1661:
URL: https://github.com/apache/fineract/pull/1661#issuecomment-844597706
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie closed pull request #1661: FINERACT-1330 check balance at transaction date also do not violate o…
Posted by GitBox <gi...@apache.org>.
francisguchie closed pull request #1661:
URL: https://github.com/apache/fineract/pull/1661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie closed pull request #1661: FINERACT-1330 check balance at transaction date also do not violate o…
Posted by GitBox <gi...@apache.org>.
francisguchie closed pull request #1661:
URL: https://github.com/apache/fineract/pull/1661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #1661: FINERACT-1330 check balance at transaction date also do not violate o…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1661:
URL: https://github.com/apache/fineract/pull/1661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1661: FINERACT-1330 check balance at transaction date also do not violate o…
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1661:
URL: https://github.com/apache/fineract/pull/1661#issuecomment-822525338
I will re-create the PR as its going stale
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org