[GitHub] [camel-k] squakez commented on a diff in pull request #4568: feat(trait): Add maven profile to Integration in builder trait

["squakez (via GitHub)" <gi...@apache.org>]

squakez commented on code in PR #4568:
URL: https://github.com/apache/camel-k/pull/4568#discussion_r1262323564


##########
pkg/builder/project.go:
##########
@@ -191,3 +194,14 @@ func injectDependencies(ctx *builderContext) error {
 func sanitizeDependencies(ctx *builderContext) error {
 	return camel.SanitizeIntegrationDependencies(ctx.Maven.Project.Dependencies)
 }
+
+func injectProfile(ctx *builderContext) error {

Review Comment:
   Instead of injecting the profile (which could be seen as dangerous against the immutability of the project provided) I wonder if it would be possible to have instead the profile called in the `./mvnw package -P custom-profile.xml` being the custom-profile.xml created from the configmap/secret (as I think we do the same for the settings.xml).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org