You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2011/05/18 15:14:50 UTC
[Bug 6591] New: 3.3.2rc1 fails t/trusted_path.t tests 69, 72, 75, 78
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
Bug #: 6591
Summary: 3.3.2rc1 fails t/trusted_path.t tests 69, 72, 75, 78
Product: Spamassassin
Version: 3.3.1
Platform: All
OS/Version: All
Status: NEW
Severity: blocker
Priority: P2
Component: Regression Tests
AssignedTo: dev@spamassassin.apache.org
ReportedBy: sidney@sidney.com
Classification: Unclassified
Created attachment 4892
--> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4892
log TEST_VERBOSE=1 output of the test
I am only seeing this failure in builds from the 3.3.2rc1 tarball.
I do not get these failures in svn trunk or in svn branches/3.3
I do get these failures identically on a Macbook running Mac OS 10.6.7 32-bit
with perl 5.12.3, and on a box running Fedora 14 64-bit also with perl 5.12.3.
I also tested the Macbook on the same network as the Fedora machine and on a
completely different one to eliminate the possibility of the local
network/firewall/etc. setup being a factor.
I am attaching the result of
make test TEST_FILES=t/trust_path.t TEST_VERBOSE=1 &> ~/tmp/bug332trusted.log
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
--- Comment #10 from Mark Martinec <Ma...@ijs.si> 2011-05-18 19:18:42 UTC ---
Ok, so here it goes:
Tests t/trust_path.t and the t/originating_ip_hdr.t (Bug 6500) were
failing in the distribution package because the default configuration
(the 'originating_ip_headers' directives) were only present in
rules (rules/10_default_prefs.cf) in trunk/branch, but not in the
package tarball.
I attempted to solve the problem by adding the directive
'originating_ip_headers X-Originating-IP' directly into the affected
tests (also the Bug 6500 commits) - which worked ok for a tarball,
but started failing in the trunk, because of another bug:
the X-Originating-IP was now being counted twice, because it was
inserted twice in the list, by rules/10_default_prefs.cf and by
a test.
The proposed solution:
- instead of having 'originating_ip_headers X-Originating-IP'
in each affected test, it is simpler to just add it to
t/data/01_test_rules.cf (reverting both commits),
benefiting future similar cases;
- avoid the duplication by fixing the Conf.pm, which now
only adds originating header field names to the list
if they are not already listed there.
trunk:
Bug 6591: 3.3.2rc1 fails t/trusted_path.t tests 69, 72, 75, 78
Sending lib/Mail/SpamAssassin/Conf.pm
Sending t/data/01_test_rules.cf
Sending t/originating_ip_hdr.t
Sending t/trust_path.t
Committed revision 1124386.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] 3.3.2rc1 fails t/trusted_path.t tests 69, 72, 75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2011-05-18 13:25:57 UTC ---
Looks like the same issue as in Bug 6500 comment 12,
no local rules in the package.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
--- Comment #9 from Kevin A. McGrail <km...@pccc.com> 2011-05-18 18:43:40 UTC ---
(In reply to comment #8)
> Actually we are dealing with two bugs here, the other one just revealed
> itself. Working on it...
Roger that. I don't see a make test issue so will wait to be enlightened ;-)
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 votes for 3.3.2 |needs 2 votes for 3.3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
--- Comment #11 from Sidney Markowitz <si...@sidney.com> 2011-05-18 19:30:55 UTC ---
Are you proposing this for inclusion in 3.3.2? So far I'm not following if this
is a bug in a test or a bug that is revealed by a test.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #16 from Kevin A. McGrail <km...@pccc.com> 2011-05-28 09:02:47 UTC ---
trunk commits for revision 1124270 and 1124386 applied in that order to 3.3
branch
passes make test with long/net tests enabled otherwise test is skipped.
Sending lib/Mail/SpamAssassin/Conf.pm
Sending t/data/01_test_rules.cf
Sending t/originating_ip_hdr.t
Sending t/trust_path.t
Transmitting file data ....
Committed revision 1128573.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
--- Comment #3 from Sidney Markowitz <si...@sidney.com> 2011-05-18 14:30:41 UTC ---
Still seeing the error.
The two lines copy pasted from my t/trusted_path.t file
"clear_msa_networks\n",
"originating_ip_headers X-Originating-IP\n";
The result of on of the failed tests
netset warn: netset: cannot exclude 1.0.0.0/8 as it has already been included
ok 66
ok 67
ok 68
not ok 69
conf: -------------------------------------------------------------------
add_header all Untrusted _RELAYSUNTRUSTED_
add_header all Trusted _RELAYSTRUSTED_
clear_trusted_networks
clear_internal_networks
clear_msa_networks
trusted_networks 1/8
hdr sample: -------------------------------------------------------------------
Received: from sender.net (1.1.1.1) by receiver.net
with SMTP; 10 Nov 2005 00:00:00 -0000
X-Originating-IP: 2.2.2.2
------------------------------------------------------------------------------
expected: Trusted: [ ip=1.1.1.1 rdns=sender.net helo=sender.net by=receiver.net
ident= envfrom= intl=1 id= auth= msa=0 ] Untrusted: [ ip=2.2.2.2 rdns= helo=
by= ident= envfrom= intl=0 id= auth= msa=0 ]
got : Trusted: [ ip=1.1.1.1 rdns=sender.net helo=sender.net by=receiver.net
ident= envfrom= intl=1 id= auth= msa=0 ] Untrusted:
# Failed test 69 in t/trust_path.t at line 695 fail #23
ok 70
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
--- Comment #6 from Sidney Markowitz <si...@sidney.com> 2011-05-18 18:25:59 UTC ---
That works. Is your comment #5 stating a problem that has to be fixed?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|3.3.2rc1 fails |[review] 3.3.2rc1 fails
|t/trusted_path.t tests 69, |t/trusted_path.t tests 69,
|72, 75, 78 |72, 75, 78
Status Whiteboard| |needs 2 votes for 3.3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
--- Comment #12 from Mark Martinec <Ma...@ijs.si> 2011-05-18 19:41:12 UTC ---
> Are you proposing this for inclusion in 3.3.2? So far I'm not following
> if this is a bug in a test or a bug that is revealed by a test.
Yes, I'm proposing this for inclusion in 3.3.2, please review/vote.
Half of the change (trunk: svn diff -c1124386) is just reverting
previous two commits which attempted to solve the real problem
in two tests, and adding instead the missing default to
t/data/01_test_rules.cf, which will be seen by all tests,
both in a tarball and in SVN.
Simpler solution, less changes needed for tests.
The fix to Conf.pm (avoiding duplicates) is new, and fixes an
issue where somehow an 'originating_ip_headers' directive
with the same parameters is seen more than once for whatever
reason.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] 3.3.2rc1 fails t/trusted_path.t tests 69, 72, 75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
Sidney Markowitz <si...@sidney.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sidney@sidney.com
Version|3.3.1 |3.3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes for 3.3.2 |needs 1 votes for 3.3.2
--- Comment #14 from Kevin A. McGrail <km...@pccc.com> 2011-05-19 00:58:59 UTC ---
(In reply to comment #13)
> Created attachment 4896 [details]
> proposed fix
>
> For ease of inspection, the proposed patch (after first
> reverting the 3.3 r1100008 of Bug 6500) is attached.
>
> In short:
> - makes sure the originating_ip_headers defaults are seen
> by tests even in the absence of a rules directory;
> - makes sure that redundant originating_ip_headers do not
> cause havoc (like they did with the most recent jenkins failure)
Passes tests for me as well. +1 for trunk & 3.3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
--- Comment #4 from Mark Martinec <Ma...@ijs.si> 2011-05-18 14:42:43 UTC ---
> Still seeing the error.
> The two lines copy pasted from my t/trusted_path.t file
> "clear_msa_networks\n",
A dot, not a comma!
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
--- Comment #8 from Mark Martinec <Ma...@ijs.si> 2011-05-18 18:40:17 UTC ---
Actually we are dealing with two bugs here, the other one just revealed
itself. Working on it...
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] 3.3.2rc1 fails t/trusted_path.t tests 69, 72, 75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.3.2
--- Comment #2 from Mark Martinec <Ma...@ijs.si> 2011-05-18 14:05:29 UTC ---
> Looks like the same issue as in Bug 6500 comment 12,
> no local rules in the package.
Indeed, a default for originating_ip_headers is in the
rules/10_default_prefs.cf, which is not present in a
distributed package.
The fix to t/trust_path.t is much like in Bug 6500 comment 12:
- "clear_msa_networks\n";
+ "clear_msa_networks\n".
+ "originating_ip_headers X-Originating-IP\n";
trunk:
Bug 6591: 3.3.2rc1 fails t/trusted_path.t tests 69, 72, 75, 78
Sending t/trust_path.t
Committed revision 1124270.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Re: [Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69,
72, 75, 78
Posted by Mark Martinec <Ma...@ijs.si>.
On 2011-05-25 9:38, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
> Status Whiteboard|needs 1 votes for 3.3.2 |ready to commit for 3.3.2
> looks fine to me, +1 for trunk& 3.3.2
FYI, I won't be around much for the rest of the week, so this may
have to wait for a few days, or someone else doing it if in a hurry.
(being at a conference)
Mark
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
Henrik Krohns <he...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hege@hege.li
Status Whiteboard|needs 1 votes for 3.3.2 |ready to commit for 3.3.2
--- Comment #15 from Henrik Krohns <he...@hege.li> 2011-05-25 07:38:18 UTC ---
looks fine to me, +1 for trunk & 3.3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
--- Comment #5 from Mark Martinec <Ma...@ijs.si> 2011-05-18 18:23:45 UTC ---
I see, the IP address from an X-Originating-IP header field gets inserted
into the list of trace fields twice (including a fabricated Received).
Not sure where this turned sour ...
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
Status Whiteboard|needs 2 votes for 3.3.2 |needs 1 votes for 3.3.2
--- Comment #7 from Kevin A. McGrail <km...@pccc.com> 2011-05-18 18:29:07 UTC ---
(In reply to comment #2)
> > Looks like the same issue as in Bug 6500 comment 12,
> > no local rules in the package.
>
> Indeed, a default for originating_ip_headers is in the
> rules/10_default_prefs.cf, which is not present in a
> distributed package.
>
> The fix to t/trust_path.t is much like in Bug 6500 comment 12:
>
> - "clear_msa_networks\n";
> + "clear_msa_networks\n".
> + "originating_ip_headers X-Originating-IP\n";
>
>
> trunk:
> Bug 6591: 3.3.2rc1 fails t/trusted_path.t tests 69, 72, 75, 78
> Sending t/trust_path.t
> Committed revision 1124270.
I am able to recreate the issue and this patch works for me patching 3.3.2rc1.
+1 for trunk and 3.3.2.
Regards,
KAM
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6591] [review] 3.3.2rc1 fails t/trusted_path.t tests 69, 72,
75, 78
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6591
--- Comment #13 from Mark Martinec <Ma...@ijs.si> 2011-05-18 22:46:18 UTC ---
Created attachment 4896
--> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4896
proposed fix
For ease of inspection, the proposed patch (after first
reverting the 3.3 r1100008 of Bug 6500) is attached.
In short:
- makes sure the originating_ip_headers defaults are seen
by tests even in the absence of a rules directory;
- makes sure that redundant originating_ip_headers do not
cause havoc (like they did with the most recent jenkins failure)
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.