[GitHub] [gobblin] hanghangliu commented on a diff in pull request #3556: [GOBBLIN-1702] fix helix job wait completion bug when job goes to STOPPING state

[GitBox <gi...@apache.org>]

hanghangliu commented on code in PR #3556:
URL: https://github.com/apache/gobblin/pull/3556#discussion_r966630964


##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixUtils.java:
##########
@@ -278,13 +278,16 @@ static void waitJobCompletion(HelixManager helixManager, String workFlowName, St
           case STOPPING:
             log.info("Waiting for job {} to complete... State - {}", jobName, jobState);
             Thread.sleep(TimeUnit.SECONDS.toMillis(1L));
+            if (stoppingStateEndTime == null) {
+              stoppingStateEndTime = jobStartTimeMillis + stoppingStateTimeoutInSeconds * 1000;

Review Comment:
   Done. 
   Log can be traced by line 279 if the job is STOPPING state.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org