You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/02/16 11:08:50 UTC

[GitHub] [parquet-format] martin-g opened a new pull request #167: PARQUET-1980: Add TravisCI job to build and test on ARM64

martin-g opened a new pull request #167:
URL: https://github.com/apache/parquet-format/pull/167


   ### Jira
   
   https://issues.apache.org/jira/browse/PARQUET-1980
   
   ### Commits
   
   - [ X ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - No new functionality 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-format] martin-g commented on pull request #167: PARQUET-1980: Add TravisCI job to build and test on ARM64

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #167:
URL: https://github.com/apache/parquet-format/pull/167#issuecomment-780363348


   Closing this PR since the code is now in Parquet MR!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-format] martin-g commented on pull request #167: PARQUET-1980: Add TravisCI job to build and test on ARM64

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #167:
URL: https://github.com/apache/parquet-format/pull/167#issuecomment-780363087


   Thanks for the reference, @gszadovszky !
   I've added a comment to [PARQUET-1969](https://issues.apache.org/jira/browse/PARQUET-1969?focusedCommentId=17285673&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17285673)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-format] martin-g commented on a change in pull request #167: PARQUET-1980: Add TravisCI job to build and test on ARM64

Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #167:
URL: https://github.com/apache/parquet-format/pull/167#discussion_r576740506



##########
File path: .travis.yml
##########
@@ -31,3 +37,5 @@ before_install:
   - ./configure --disable-gen-erl --disable-gen-hs --without-ruby --without-haskell --without-erlang --without-php --without-nodejs --without-java
   - sudo make install
   - cd ..
+
+script: mvn --batch-mode --show-version clean verify

Review comment:
       This just makes the `script` task explicit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-format] gszadovszky edited a comment on pull request #167: PARQUET-1980: Add TravisCI job to build and test on ARM64

Posted by GitBox <gi...@apache.org>.
gszadovszky edited a comment on pull request #167:
URL: https://github.com/apache/parquet-format/pull/167#issuecomment-779887663


   @martin-g, because of the recent Travis issue we have decided to move to Github Actions. We've already done with the transition in parquet-mr and it is on the way for parquet-format as well. See #166 for details.
   
   Another thing is that the parquet-format builds are only for verification purposes. The generated java classes are deprecated here and will be removed in a later release. We have moved the java related code generation to the parquet-mr module parquet-format-structures.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-format] martin-g closed pull request #167: PARQUET-1980: Add TravisCI job to build and test on ARM64

Posted by GitBox <gi...@apache.org>.
martin-g closed pull request #167:
URL: https://github.com/apache/parquet-format/pull/167


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-format] gszadovszky commented on pull request #167: PARQUET-1980: Add TravisCI job to build and test on ARM64

Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #167:
URL: https://github.com/apache/parquet-format/pull/167#issuecomment-779887663


   @martin-g, because of the recent Travis issue we have decided to move to Github Actions. We've already done with the transition in parquet-mr and it is on the way for parquet-format as well. See #166 for details.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org