You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/11 15:24:26 UTC

[GitHub] [arrow-datafusion] Jimexist commented on pull request #307: fix 305 by using a scalar uint as param for zero param functions

Jimexist commented on pull request #307:
URL: https://github.com/apache/arrow-datafusion/pull/307#issuecomment-838675808


   > I think this code is ok. It would be nice to have unit tests, but I think #303  will add sufficient converage.
   > 
   > 
   > 
   > It would be nice to add some additional documentation about this as it is "not obvious" to a casual reader. 
   > 
   > 
   > 
   > Thank you @Jimexist 
   
   I'll try to add comments in the next pull request - is that okay?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org