You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2015/04/13 23:20:05 UTC

Re: svn commit: r1673204 - /subversion/trunk/subversion/libsvn_fs_fs/dag.c

rhuijben@apache.org wrote on Mon, Apr 13, 2015 at 14:28:39 -0000:
> -      *has_props = (noderev->prop_rep->expanded_size > 4);
> +      *has_props = (noderev->prop_rep->expanded_size > 4
> +                    || (noderev->prop_rep->expanded_size == 0
> +                        && noderev->prop_rep->size > 4));

Having to remember, on every use of EXPANDED_SIZE, to check if it's zero
is madness.  Is there a good reason not to make the deserializer
function handle this?  If needed, by inventing a getter or a new struct
member that doesn't have this quirk?