[jira] [Commented] (OAK-5013) Introduce observation filter extension mechanism to Oak

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611158#comment-15611158 ] 

Michael Dürig commented on OAK-5013:
------------------------------------

+1 to this approach. One thing I'd like to clarify a bit more is the write through behaviour. Even the {{JackrabbitEventFilter}} doesn't clearly say what the effect of setting a property on the filter is. Does it modify a filter that has already been passed to the observation manager? I guess not as "A storage object for event filter configuration" seems to imply. But let's be extra clear here. 

> Introduce observation filter extension mechanism to Oak
> -------------------------------------------------------
>
>                 Key: OAK-5013
>                 URL: https://issues.apache.org/jira/browse/OAK-5013
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: jcr
>    Affects Versions: 1.5.12
>            Reporter: Stefan Egli
>            Assignee: Stefan Egli
>             Fix For: 1.5.13
>
>         Attachments: OAK-5013.patch
>
>
> During [discussions|http://markmail.org/thread/fyngo4dwb7fvlqdj] regarding extending JackrabbitEventFilter an interesting suggestion by [~mduerig] came up that we could extend the JackrabbitEventFilter in oak explicitly, rather than modifying it in Jackrabbit each time we add something oak-specific.
> We should introduce a builder/interface pair in oak to reflect that. 
> Users that would like to use such oak-specific extensions would wrap a JackrabbitEventFilter and get an OakEventFilter that contains enabling these extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)