svn commit: r601028 - in /myfaces/tobago/trunk/tobago-tool: maven-theme-plugin/src/main/java/org/apache/myfaces/tobago/maven/plugin/ tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/

[bo...@apache.org]

Author: bommel
Date: Tue Dec  4 10:24:02 2007
New Revision: 601028

URL: http://svn.apache.org/viewvc?rev=601028&view=rev
Log:
fixed some findbugs errors

Modified:
    myfaces/tobago/trunk/tobago-tool/maven-theme-plugin/src/main/java/org/apache/myfaces/tobago/maven/plugin/UnPackThemeMojo.java
    myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/FacesConfigAnnotationVisitor.java
    myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/TaglibAnnotationVisitor.java
    myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/TobagoAnnotationVisitor.java

Modified: myfaces/tobago/trunk/tobago-tool/maven-theme-plugin/src/main/java/org/apache/myfaces/tobago/maven/plugin/UnPackThemeMojo.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-tool/maven-theme-plugin/src/main/java/org/apache/myfaces/tobago/maven/plugin/UnPackThemeMojo.java?rev=601028&r1=601027&r2=601028&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-tool/maven-theme-plugin/src/main/java/org/apache/myfaces/tobago/maven/plugin/UnPackThemeMojo.java (original)
+++ myfaces/tobago/trunk/tobago-tool/maven-theme-plugin/src/main/java/org/apache/myfaces/tobago/maven/plugin/UnPackThemeMojo.java Tue Dec  4 10:24:02 2007
@@ -30,6 +30,7 @@
 import java.io.FileInputStream;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Locale;
 import java.util.zip.ZipInputStream;
 import java.util.zip.ZipEntry;
 
@@ -150,7 +151,7 @@
 
   private void unpack(File file, File location)
       throws MojoExecutionException, NoSuchArchiverException {
-    String archiveExt = FileUtils.getExtension(file.getAbsolutePath()).toLowerCase();
+    String archiveExt = FileUtils.getExtension(file.getAbsolutePath()).toLowerCase(Locale.ENGLISH);
     try {
       UnArchiver unArchiver = archiverManager.getUnArchiver(archiveExt);
       unArchiver.setSourceFile(file);

Modified: myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/FacesConfigAnnotationVisitor.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/FacesConfigAnnotationVisitor.java?rev=601028&r1=601027&r2=601028&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/FacesConfigAnnotationVisitor.java (original)
+++ myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/FacesConfigAnnotationVisitor.java Tue Dec  4 10:24:02 2007
@@ -62,6 +62,7 @@
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
+import java.util.Locale;
 
 /*
  * Created by IntelliJ IDEA.
@@ -201,7 +202,7 @@
         writer =
             getEnv().getFiler().createTextFile(Filer.Location.SOURCE_TREE, "", new File(targetFacesConfigFile), null);
 
-        StringWriter facesConfig = new StringWriter();
+        StringWriter facesConfig = new StringWriter(1024);
         Format format = Format.getPrettyFormat();
         format.setLineSeparator(SEPARATOR);
         XMLOutputter out = new XMLOutputter(format);
@@ -371,7 +372,7 @@
     if (componentAttribute != null) {
       String simpleName = d.getSimpleName();
       if (simpleName.startsWith("set")) {
-        String attributeStr = simpleName.substring(3, 4).toLowerCase() + simpleName.substring(4);
+        String attributeStr = simpleName.substring(3, 4).toLowerCase(Locale.ENGLISH) + simpleName.substring(4);
         String methodStr;
         if (componentAttribute.type().length == 1
             && (componentAttribute.type()[0].equals(Boolean.class.getName())

Modified: myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/TaglibAnnotationVisitor.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/TaglibAnnotationVisitor.java?rev=601028&r1=601027&r2=601028&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/TaglibAnnotationVisitor.java (original)
+++ myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/TaglibAnnotationVisitor.java Tue Dec  4 10:24:02 2007
@@ -52,6 +52,7 @@
 import java.util.Collection;
 import java.util.HashSet;
 import java.util.Set;
+import java.util.Locale;
 
 /*
  * Created: Mar 22, 2005 8:18:35 PM
@@ -377,7 +378,7 @@
       String simpleName = d.getSimpleName();
       if (simpleName.startsWith("set")) {
         Element attribute = document.createElement("attribute");
-        String attributeStr = simpleName.substring(3, 4).toLowerCase() + simpleName.substring(4);
+        String attributeStr = simpleName.substring(3, 4).toLowerCase(Locale.ENGLISH) + simpleName.substring(4);
         checkAttributeDuplicates(attributeStr);
         addLeafTextElement(attributeStr, "name", attribute, document);
 

Modified: myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/TobagoAnnotationVisitor.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/TobagoAnnotationVisitor.java?rev=601028&r1=601027&r2=601028&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/TobagoAnnotationVisitor.java (original)
+++ myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/TobagoAnnotationVisitor.java Tue Dec  4 10:24:02 2007
@@ -42,6 +42,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.io.Writer;
+import java.util.Locale;
 
 /*
  * Created: Apr 27, 2005 4:45:44 PM
@@ -138,7 +139,7 @@
       String simpleName = d.getSimpleName();
       if (simpleName.startsWith("set")) {
         Element attribute = document.createElement("attribute");
-        addLeafTextElement(simpleName.substring(3, 4).toLowerCase()
+        addLeafTextElement(simpleName.substring(3, 4).toLowerCase(Locale.ENGLISH)
             + simpleName.substring(4), "name", attribute, document);
         addLeafTextElement(Boolean.toString(tagAttribute.required()), "required", attribute, document);
         addLeafTextElement(Boolean.toString(tagAttribute.rtexprvalue()), "rtexprvalue", attribute, document);