You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by John Dilley <jo...@citrix.com> on 2014/08/01 15:43:41 UTC
Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to be
connected before verication
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/
-----------------------------------------------------------
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-7223
https://issues.apache.org/jira/browse/CLOUDSTACK-7223
Repository: cloudstack-git
Description
-------
This change waits for the system VM agent state to be up in the testcases that stop/reboot/destroy system VMs before verifying that they are functioning properly.
Diffs
-----
test/integration/smoke/test_ssvm.py ac4079e
Diff: https://reviews.apache.org/r/24182/diff/
Testing
-------
Tested against KVM advanced zone
Thanks,
John Dilley
Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to
be connected before verication
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On Aug. 4, 2014, 4:35 a.m., Santhosh Edukulla wrote:
> > John,
> >
> > 1. Just mark the open issues as resolved.
> > 2. As well, mention the branch information to which it need to be applied.
> >
> > Santhosh
Hi John,
Sorry, iam getting trailing whitespace errors as below, while applying patch. Going ahead, once we create a patch, may be we can just check to apply it once to avoid these errors.
/home/santhosh/softwares/cs_new_master/cloudstack/.git/rebase-apply/patch:15: trailing whitespace.
/home/santhosh/softwares/cs_new_master/cloudstack/.git/rebase-apply/patch:60: trailing whitespace.
/home/santhosh/softwares/cs_new_master/cloudstack/.git/rebase-apply/patch:117: trailing whitespace.
warning: 3 lines add whitespace errors.
Santhosh
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/#review49443
-----------------------------------------------------------
On Aug. 4, 2014, 6:19 a.m., John Dilley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24182/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 6:19 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7223
> https://issues.apache.org/jira/browse/CLOUDSTACK-7223
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This change waits for the system VM agent state to be up in the testcases that stop/reboot/destroy system VMs before verifying that they are functioning properly.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_ssvm.py ac4079e
>
> Diff: https://reviews.apache.org/r/24182/diff/
>
>
> Testing
> -------
>
> Tested against KVM advanced zone
>
>
> Thanks,
>
> John Dilley
>
>
Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to
be connected before verication
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/#review49443
-----------------------------------------------------------
Ship it!
John,
1. Just mark the open issues as resolved.
2. As well, mention the branch information to which it need to be applied.
Santhosh
- Santhosh Edukulla
On Aug. 1, 2014, 7:13 p.m., John Dilley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24182/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2014, 7:13 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7223
> https://issues.apache.org/jira/browse/CLOUDSTACK-7223
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This change waits for the system VM agent state to be up in the testcases that stop/reboot/destroy system VMs before verifying that they are functioning properly.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_ssvm.py ac4079e
>
> Diff: https://reviews.apache.org/r/24182/diff/
>
>
> Testing
> -------
>
> Tested against KVM advanced zone
>
>
> Thanks,
>
> John Dilley
>
>
Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to
be connected before verication
Posted by John Dilley <jo...@citrix.com>.
> On Aug. 4, 2014, 2:56 p.m., Rohit Yadav wrote:
> > Thanks for the patch, is this already merged into master and respective branch?
Not yet - Santhosh asked for a patch that didn't have the whitespace issues.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/#review49455
-----------------------------------------------------------
On Aug. 4, 2014, 2:50 p.m., John Dilley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24182/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 2:50 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7223
> https://issues.apache.org/jira/browse/CLOUDSTACK-7223
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This change waits for the system VM agent state to be up in the testcases that stop/reboot/destroy system VMs before verifying that they are functioning properly.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_ssvm.py ac4079e
>
> Diff: https://reviews.apache.org/r/24182/diff/
>
>
> Testing
> -------
>
> Tested against KVM advanced zone
>
>
> Thanks,
>
> John Dilley
>
>
Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to
be connected before verication
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/#review49455
-----------------------------------------------------------
Thanks for the patch, is this already merged into master and respective branch?
- Rohit Yadav
On Aug. 4, 2014, 2:50 p.m., John Dilley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24182/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 2:50 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7223
> https://issues.apache.org/jira/browse/CLOUDSTACK-7223
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This change waits for the system VM agent state to be up in the testcases that stop/reboot/destroy system VMs before verifying that they are functioning properly.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_ssvm.py ac4079e
>
> Diff: https://reviews.apache.org/r/24182/diff/
>
>
> Testing
> -------
>
> Tested against KVM advanced zone
>
>
> Thanks,
>
> John Dilley
>
>
Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to
be connected before verication
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/#review49457
-----------------------------------------------------------
Commit 0c77b2007e3918b10a8de560b2f63bd0f0f2cbdd in cloudstack's branch refs/heads/master from John Dilley
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0c77b20 ]
CLOUDSTACK-7223: Wait for system VM agent state to be up before verification
Signed-off-by: Santhosh Edukulla <sa...@gmail.com>
- ASF Subversion and Git Services
On Aug. 4, 2014, 2:50 p.m., John Dilley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24182/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 2:50 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7223
> https://issues.apache.org/jira/browse/CLOUDSTACK-7223
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This change waits for the system VM agent state to be up in the testcases that stop/reboot/destroy system VMs before verifying that they are functioning properly.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_ssvm.py ac4079e
>
> Diff: https://reviews.apache.org/r/24182/diff/
>
>
> Testing
> -------
>
> Tested against KVM advanced zone
>
>
> Thanks,
>
> John Dilley
>
>
Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to
be connected before verication
Posted by John Dilley <jo...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 2:50 p.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Updated diff with whitespace issues fixed
Bugs: CLOUDSTACK-7223
https://issues.apache.org/jira/browse/CLOUDSTACK-7223
Repository: cloudstack-git
Description
-------
This change waits for the system VM agent state to be up in the testcases that stop/reboot/destroy system VMs before verifying that they are functioning properly.
Diffs (updated)
-----
test/integration/smoke/test_ssvm.py ac4079e
Diff: https://reviews.apache.org/r/24182/diff/
Testing
-------
Tested against KVM advanced zone
Thanks,
John Dilley
Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to
be connected before verication
Posted by John Dilley <jo...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 6:19 a.m.)
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-7223
https://issues.apache.org/jira/browse/CLOUDSTACK-7223
Repository: cloudstack-git
Description
-------
This change waits for the system VM agent state to be up in the testcases that stop/reboot/destroy system VMs before verifying that they are functioning properly.
Diffs
-----
test/integration/smoke/test_ssvm.py ac4079e
Diff: https://reviews.apache.org/r/24182/diff/
Testing
-------
Tested against KVM advanced zone
Thanks,
John Dilley
Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to
be connected before verication
Posted by John Dilley <jo...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/
-----------------------------------------------------------
(Updated Aug. 1, 2014, 7:13 p.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Addressed issues from first review, and also fixed an issue in existing code which could lead to an endless loop
Bugs: CLOUDSTACK-7223
https://issues.apache.org/jira/browse/CLOUDSTACK-7223
Repository: cloudstack-git
Description
-------
This change waits for the system VM agent state to be up in the testcases that stop/reboot/destroy system VMs before verifying that they are functioning properly.
Diffs (updated)
-----
test/integration/smoke/test_ssvm.py ac4079e
Diff: https://reviews.apache.org/r/24182/diff/
Testing
-------
Tested against KVM advanced zone
Thanks,
John Dilley
Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to
be connected before verication
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/#review49340
-----------------------------------------------------------
test/integration/smoke/test_ssvm.py
<https://reviews.apache.org/r/24182/#comment86336>
Then, we can remove this sleep. Applies at other places as well.
test/integration/smoke/test_ssvm.py
<https://reviews.apache.org/r/24182/#comment86337>
This is good actually, but can we make this code, a util\lib, such that this repetition can be avoided. That way others can reuse it and lines of code will reduce. You can decide the signature for that util.
test/integration/smoke/test_ssvm.py
<https://reviews.apache.org/r/24182/#comment86338>
just check the length of list to be empty other wise we may get index out of range error and do a lower conversion string comparison.
- Santhosh Edukulla
On Aug. 1, 2014, 1:43 p.m., John Dilley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24182/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2014, 1:43 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7223
> https://issues.apache.org/jira/browse/CLOUDSTACK-7223
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This change waits for the system VM agent state to be up in the testcases that stop/reboot/destroy system VMs before verifying that they are functioning properly.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_ssvm.py ac4079e
>
> Diff: https://reviews.apache.org/r/24182/diff/
>
>
> Testing
> -------
>
> Tested against KVM advanced zone
>
>
> Thanks,
>
> John Dilley
>
>