You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/11 12:50:32 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request, #3988: perf-regression: add integration tests #3982
aldettinger opened a new pull request, #3988:
URL: https://github.com/apache/camel-quarkus/pull/3988
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3988: perf-regression: add integration tests #3982
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #3988:
URL: https://github.com/apache/camel-quarkus/pull/3988#issuecomment-1216419388
@jamesnetherton @ppalaga With `mvn clean verify`, we could early detect potential breakage in the `perf-regression` tool before using it during the release.
How could we run those integration tests for each PR during CI checks ? I guess trying to list `perf-regression` in a test group is a bad idea ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3988: perf-regression: add integration tests #3982
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #3988:
URL: https://github.com/apache/camel-quarkus/pull/3988#issuecomment-1217556822
Looks good to me, it's ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #3988: perf-regression: add integration tests #3982
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on PR #3988:
URL: https://github.com/apache/camel-quarkus/pull/3988#issuecomment-1216428715
> How could we run those integration tests for each PR during CI checks
Probably best to add it as another task here:
https://github.com/apache/camel-quarkus/blob/main/.github/workflows/ci-build.yaml#L196
The overhead is probably minimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3988: perf-regression: add integration tests #3982
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #3988:
URL: https://github.com/apache/camel-quarkus/pull/3988#issuecomment-1211946904
Please do not merge. It is needed to check whether it build on CI and how to run `mvn clean verify` on perf-regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #3988: perf-regression: add integration tests #3982
Posted by GitBox <gi...@apache.org>.
aldettinger merged PR #3988:
URL: https://github.com/apache/camel-quarkus/pull/3988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org