You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codyml (via GitHub)" <gi...@apache.org> on 2023/01/27 15:24:52 UTC
[GitHub] [superset] codyml opened a new pull request, #22889: fix(fab): Fix regression on FAB dropdowns
codyml opened a new pull request, #22889:
URL: https://github.com/apache/superset/pull/22889
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR removes some global CSS that conflicts with FAB dropdowns. FAB version was bumped in https://github.com/apache/superset/pull/22580, and the new version includes markup that certain global CSS styles in `superset.less` now apply to, causing a visual bug with dropdown menus. The global CSS was introduced in https://github.com/apache/superset/pull/3241 to style the `VisualizeModal` component. This component was removed in https://github.com/apache/superset/pull/5523, so I believe these global styles are no longer used anywhere in the app (though if anyone knows otherwise, definitely let me know).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
After:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- Confirm that FAB views' dropdowns look and work correctly:
- `/rowlevelsecurityfiltersmodelview/add`
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #22889: fix(fab): Fix regression on FAB dropdowns
Posted by "codyml (via GitHub)" <gi...@apache.org>.
codyml commented on PR #22889:
URL: https://github.com/apache/superset/pull/22889#issuecomment-1406686727
For added context, here's what the dropdown looked like before the FAB upgrade:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22889: fix(fab): Fix regression on FAB dropdowns
Posted by github-actions.
github-actions[bot] commented on PR #22889:
URL: https://github.com/apache/superset/pull/22889#issuecomment-1406755221
@jinghua-qa Ephemeral environment spinning up at http://54.213.11.254:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml merged pull request #22889: fix(fab): Fix regression on FAB dropdowns
Posted by "codyml (via GitHub)" <gi...@apache.org>.
codyml merged PR #22889:
URL: https://github.com/apache/superset/pull/22889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #22889: fix(fab): Fix regression on FAB dropdowns
Posted by "codyml (via GitHub)" <gi...@apache.org>.
codyml commented on PR #22889:
URL: https://github.com/apache/superset/pull/22889#issuecomment-1406747881
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22889: fix(fab): Fix regression on FAB dropdowns
Posted by github-actions.
github-actions[bot] commented on PR #22889:
URL: https://github.com/apache/superset/pull/22889#issuecomment-1410886912
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] andrey-zayats commented on pull request #22889: fix(fab): Fix regression on FAB dropdowns
Posted by "andrey-zayats (via GitHub)" <gi...@apache.org>.
andrey-zayats commented on PR #22889:
URL: https://github.com/apache/superset/pull/22889#issuecomment-1410638826
QA verified the fix. LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #22889: fix(fab): Fix regression on FAB dropdowns
Posted by "jinghua-qa (via GitHub)" <gi...@apache.org>.
jinghua-qa commented on PR #22889:
URL: https://github.com/apache/superset/pull/22889#issuecomment-1406751355
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #22889: fix(fab): Fix regression on FAB dropdowns
Posted by "codyml (via GitHub)" <gi...@apache.org>.
codyml commented on PR #22889:
URL: https://github.com/apache/superset/pull/22889#issuecomment-1410788919
> QA verified the fix. LGTM! But dropdown color and selected tile colors is different (PR vs Prod).
Thanks! Will tackle the color changes in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22889: fix(fab): Fix regression on FAB dropdowns
Posted by github-actions.
github-actions[bot] commented on PR #22889:
URL: https://github.com/apache/superset/pull/22889#issuecomment-1406748338
@codyml Ephemeral environment creation is currently limited to committers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org