[GitHub] [phoenix] dbwong edited a comment on pull request #1353: PHOENIX-6587 Disallow specifying explicit pre-split on salted tables

[GitBox <gi...@apache.org>]

dbwong edited a comment on pull request #1353:
URL: https://github.com/apache/phoenix/pull/1353#issuecomment-972552271


   > > Do we already prevent create table on preexisting table with salt set?
   > 
   > I wouldn't want to prevent that. Copying/Loading a Phoenix data table with HBase tools into a cluster, and then running _create table_ to re-create the Phoenix metadata is a supported and standard procedure, (even if I have seen people messing that up.)
   > 
   > I haven't tested it, but as we're not creating a new HBase table, we probably either error out, or just ignore the pre-split points in this case. I'm going to try out what happens in this case.
   
   I know we had a case in pre-production where we got region boundaries that overlapped the salt boundaries via restore or manual create table ontop of existing table.  This led to wrong results due to phoenix's explicit assumption on the salted boundaries.  Maybe a better approach for this worry is to check during create table that the table is split sanely if its salted etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org