You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/11/11 17:58:33 UTC
Review Request 40192: Check Unhealthy Hosts During Upgrade Is No
Longer Needed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40192/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
Bugs: AMBARI-13841
https://issues.apache.org/jira/browse/AMBARI-13841
Repository: ambari
Description
-------
*Finalize Upgrade-> Check Unhealthy Hosts*
* Even if hosts in Maintenance mode were deleted from the cluster during Finalize Upgrade Pre-Check, this check was displayed during Finalize Upgrade which is misleading. It says "Upgrade did not succeed on 0 hosts" - see screenshot.
This check is redundant anyway, so it should be removed.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 40f0bd9
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 2b41f62
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java f710580
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3c32a81
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 9caf300
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b8bf32a
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml f4ad9e3
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8173535
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml ae5747a
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 676039c
Diff: https://reviews.apache.org/r/40192/diff/
Testing
-------
mvn clena test
Verified that the check is no longer present on upgrade.
Thanks,
Jonathan Hurley
Re: Review Request 40192: Check Unhealthy Hosts During Upgrade Is No
Longer Needed
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40192/#review106095
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Nov. 11, 2015, 11:58 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40192/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 11:58 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-13841
> https://issues.apache.org/jira/browse/AMBARI-13841
>
>
> Repository: ambari
>
>
> Description
> -------
>
> *Finalize Upgrade-> Check Unhealthy Hosts*
> * Even if hosts in Maintenance mode were deleted from the cluster during Finalize Upgrade Pre-Check, this check was displayed during Finalize Upgrade which is misleading. It says "Upgrade did not succeed on 0 hosts" - see screenshot.
> This check is redundant anyway, so it should be removed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 40f0bd9
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 2b41f62
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java f710580
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3c32a81
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 9caf300
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b8bf32a
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml f4ad9e3
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8173535
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml ae5747a
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 676039c
>
> Diff: https://reviews.apache.org/r/40192/diff/
>
>
> Testing
> -------
>
> mvn clena test
>
> Verified that the check is no longer present on upgrade.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 40192: Check Unhealthy Hosts During Upgrade Is No
Longer Needed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40192/#review106096
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Nov. 11, 2015, 4:58 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40192/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 4:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-13841
> https://issues.apache.org/jira/browse/AMBARI-13841
>
>
> Repository: ambari
>
>
> Description
> -------
>
> *Finalize Upgrade-> Check Unhealthy Hosts*
> * Even if hosts in Maintenance mode were deleted from the cluster during Finalize Upgrade Pre-Check, this check was displayed during Finalize Upgrade which is misleading. It says "Upgrade did not succeed on 0 hosts" - see screenshot.
> This check is redundant anyway, so it should be removed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 40f0bd9
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 2b41f62
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java f710580
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3c32a81
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 9caf300
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b8bf32a
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml f4ad9e3
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8173535
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml ae5747a
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 676039c
>
> Diff: https://reviews.apache.org/r/40192/diff/
>
>
> Testing
> -------
>
> mvn clena test
>
> Verified that the check is no longer present on upgrade.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 40192: Check Unhealthy Hosts During Upgrade Is No
Longer Needed
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40192/#review106109
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Nov. 11, 2015, 4:58 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40192/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 4:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-13841
> https://issues.apache.org/jira/browse/AMBARI-13841
>
>
> Repository: ambari
>
>
> Description
> -------
>
> *Finalize Upgrade-> Check Unhealthy Hosts*
> * Even if hosts in Maintenance mode were deleted from the cluster during Finalize Upgrade Pre-Check, this check was displayed during Finalize Upgrade which is misleading. It says "Upgrade did not succeed on 0 hosts" - see screenshot.
> This check is redundant anyway, so it should be removed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 40f0bd9
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 2b41f62
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java f710580
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3c32a81
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 9caf300
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b8bf32a
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml f4ad9e3
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8173535
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml ae5747a
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 676039c
>
> Diff: https://reviews.apache.org/r/40192/diff/
>
>
> Testing
> -------
>
> mvn clena test
>
> Verified that the check is no longer present on upgrade.
>
>
> Thanks,
>
> Jonathan Hurley
>
>