You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xuxin930 (via GitHub)" <gi...@apache.org> on 2023/10/18 13:14:39 UTC

[PR] archive:revert using archive full path name and replenish CLEAN AROBJS [nuttx]

xuxin930 opened a new pull request, #10973:
URL: https://github.com/apache/nuttx/pull/10973

   ## Summary
   the `P` option is not a POSIX standard and will not perform the replace operation,
   this will cause the size of the target static library to become larger.
   
   let's workaround using other implementaion in the Application.mk of apps in https://github.com/apache/nuttx-apps/pull/2138
   
   the new implementation defines `AROJBS`, which is a renamed object file participating in the archive.
   so these files need to be deleted in the `CLEAN` macro.
   
   ## Impact
   Depends on (merge after): https://github.com/apache/nuttx-apps/pull/2138
   
   ## Testing
   CI Build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] archive:revert using archive full path name and replenish CLEAN AROBJS [nuttx]

Posted by "xuxin930 (via GitHub)" <gi...@apache.org>.
xuxin930 closed pull request #10973: archive:revert using archive full path name and replenish CLEAN AROBJS
URL: https://github.com/apache/nuttx/pull/10973


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] archive:revert using archive full path name and replenish CLEAN AROBJS [nuttx]

Posted by "xuxin930 (via GitHub)" <gi...@apache.org>.
xuxin930 commented on code in PR #10973:
URL: https://github.com/apache/nuttx/pull/10973#discussion_r1369588969


##########
tools/Config.mk:
##########
@@ -589,7 +589,7 @@ define CLEAN
 endef
 else
 define CLEAN
-	$(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp $(OBJS) $(BIN) $(BIN).lock $(EXTRA)
+	$(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp $(AROBJS) $(OBJS) $(BIN) $(BIN).lock $(EXTRA)

Review Comment:
   > if AROBJS just use for application build, please move this change into rule of application clean
   
   DONE
   in https://github.com/apache/nuttx-apps/pull/2138
   closed this PR with duplicate modification https://github.com/apache/nuttx/pull/11007



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] archive:revert using archive full path name and replenish CLEAN AROBJS [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #10973:
URL: https://github.com/apache/nuttx/pull/10973#discussion_r1369494969


##########
tools/Config.mk:
##########
@@ -589,7 +589,7 @@ define CLEAN
 endef
 else
 define CLEAN
-	$(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp $(OBJS) $(BIN) $(BIN).lock $(EXTRA)
+	$(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp $(AROBJS) $(OBJS) $(BIN) $(BIN).lock $(EXTRA)

Review Comment:
   if AROBJS just use for application build, please move this change into rule of application clean



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] archive:revert using archive full path name and replenish CLEAN AROBJS [nuttx]

Posted by "xuxin930 (via GitHub)" <gi...@apache.org>.
xuxin930 commented on PR #10973:
URL: https://github.com/apache/nuttx/pull/10973#issuecomment-1776481148

   Duplicate modification with https://github.com/apache/nuttx/pull/11007 
   closed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] archive:revert using archive full path name and replenish CLEAN AROBJS [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #10973:
URL: https://github.com/apache/nuttx/pull/10973#issuecomment-1775309518

   @xuxin930 ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] archive:revert using archive full path name and replenish CLEAN AROBJS [nuttx]

Posted by "xuxin930 (via GitHub)" <gi...@apache.org>.
xuxin930 closed pull request #10973: archive:revert using archive full path name and replenish CLEAN AROBJS
URL: https://github.com/apache/nuttx/pull/10973


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org