You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flume.apache.org by Ashish Paliwal <pa...@gmail.com> on 2015/03/15 08:47:18 UTC

Review Request 32084: Fix for FLUME-2632 High CPU on KafkaSink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32084/
-----------------------------------------------------------

Review request for Flume.


Bugs: FLUME-2632
    https://issues.apache.org/jira/browse/FLUME-2632


Repository: flume-git


Description
-------

Added backoff when channel is empty and added counters


Diffs
-----

  flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java eada17c 
  flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/TestKafkaSink.java 80f764f 

Diff: https://reviews.apache.org/r/32084/diff/


Testing
-------

Modified testEmptyChannel as per new condition


Thanks,

Ashish Paliwal

Re: Review Request 32084: Fix for FLUME-2632 High CPU on KafkaSink

Posted by Johny Rufus John <jr...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32084/#review76738
-----------------------------------------------------------


+1, looks consistnt with other implementations

- Johny Rufus John


On March 15, 2015, 7:47 a.m., Ashish Paliwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32084/
> -----------------------------------------------------------
> 
> (Updated March 15, 2015, 7:47 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: FLUME-2632
>     https://issues.apache.org/jira/browse/FLUME-2632
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Added backoff when channel is empty and added counters
> 
> 
> Diffs
> -----
> 
>   flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java eada17c 
>   flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/TestKafkaSink.java 80f764f 
> 
> Diff: https://reviews.apache.org/r/32084/diff/
> 
> 
> Testing
> -------
> 
> Modified testEmptyChannel as per new condition
> 
> 
> Thanks,
> 
> Ashish Paliwal
> 
>