You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by hw...@apache.org on 2010/03/24 21:42:22 UTC

svn commit: r927176 - in /subversion/trunk/subversion/libsvn_wc: lock.c lock.h

Author: hwright
Date: Wed Mar 24 20:42:22 2010
New Revision: 927176

URL: http://svn.apache.org/viewvc?rev=927176&view=rev
Log:
Remove an unneeded function.

* subversion/libsvn_wc/lock.c,
  subversion/libsvn_wc/lock.h
  (svn_wc__adm_extend_lock_to_tree): Remove.

Modified:
    subversion/trunk/subversion/libsvn_wc/lock.c
    subversion/trunk/subversion/libsvn_wc/lock.h

Modified: subversion/trunk/subversion/libsvn_wc/lock.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/lock.c?rev=927176&r1=927175&r2=927176&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/lock.c (original)
+++ subversion/trunk/subversion/libsvn_wc/lock.c Wed Mar 24 20:42:22 2010
@@ -1595,17 +1595,6 @@ extend_lock_cb(const char *local_abspath
 }
 
 svn_error_t *
-svn_wc__adm_extend_lock_to_tree(svn_wc__db_t *db,
-                                const char *adm_abspath,
-                                apr_pool_t *pool)
-{
-  return svn_error_return(
-      svn_wc__internal_walk_children(db, adm_abspath, FALSE,
-                                     extend_lock_cb, db, svn_depth_infinity,
-                                     NULL, NULL, pool));
-}
-
-svn_error_t *
 svn_wc__adm_open_in_context(svn_wc_adm_access_t **adm_access,
                             svn_wc_context_t *wc_ctx,
                             const char *path,

Modified: subversion/trunk/subversion/libsvn_wc/lock.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/lock.h?rev=927176&r1=927175&r2=927176&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/lock.h (original)
+++ subversion/trunk/subversion/libsvn_wc/lock.h Wed Mar 24 20:42:22 2010
@@ -106,16 +106,6 @@ svn_error_t *svn_wc__write_check(svn_wc_
                                  const char *local_abspath,
                                  apr_pool_t *scratch_pool);
 
-/* Ensure DB has a lock and for an entire WC tree (all the way
-   to its leaf nodes).  While locking a tree up front using
-   LEVELS_TO_LOCK of -1 is a more appropriate operation, this function
-   can be used to extend the depth of a lock via a tree-crawl after a
-   lock is taken out.  Use POOL for temporary allocations. */
-svn_error_t *svn_wc__adm_extend_lock_to_tree(svn_wc__db_t *db,
-                                             const char* adm_abspath,
-                                             apr_pool_t *pool);
-
-
 /* Return the working copy database associated with this access baton. */
 svn_wc__db_t *
 svn_wc__adm_get_db(const svn_wc_adm_access_t *adm_access);



Re: svn commit: r927176 - in /subversion/trunk/subversion/libsvn_wc: lock.c lock.h

Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
On Mar 24, 2010, at 10:29 PM, Greg Stein wrote:

> On Wed, Mar 24, 2010 at 16:42,  <hw...@apache.org> wrote:
>> ...
>> +++ subversion/trunk/subversion/libsvn_wc/lock.c Wed Mar 24 20:42:22 2010
>> @@ -1595,17 +1595,6 @@ extend_lock_cb(const char *local_abspath
>>  }
>> 
>>  svn_error_t *
>> -svn_wc__adm_extend_lock_to_tree(svn_wc__db_t *db,
>> -                                const char *adm_abspath,
>> -                                apr_pool_t *pool)
>> -{
>> -  return svn_error_return(
>> -      svn_wc__internal_walk_children(db, adm_abspath, FALSE,
>> -                                     extend_lock_cb, db, svn_depth_infinity,
>> -                                     NULL, NULL, pool));
> 
> Don't you want to remove extend_lock_cb(), too? :-P

I was distracted at the time I committed this. :)

r927258.

-Hyrum

Re: svn commit: r927176 - in /subversion/trunk/subversion/libsvn_wc: lock.c lock.h

Posted by Greg Stein <gs...@gmail.com>.
On Wed, Mar 24, 2010 at 16:42,  <hw...@apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/lock.c Wed Mar 24 20:42:22 2010
> @@ -1595,17 +1595,6 @@ extend_lock_cb(const char *local_abspath
>  }
>
>  svn_error_t *
> -svn_wc__adm_extend_lock_to_tree(svn_wc__db_t *db,
> -                                const char *adm_abspath,
> -                                apr_pool_t *pool)
> -{
> -  return svn_error_return(
> -      svn_wc__internal_walk_children(db, adm_abspath, FALSE,
> -                                     extend_lock_cb, db, svn_depth_infinity,
> -                                     NULL, NULL, pool));

Don't you want to remove extend_lock_cb(), too? :-P

>...

Cheers,
-g