You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/04/30 23:22:52 UTC
[GitHub] [geode] alb3rtobr opened a new pull request #6420: GEODE-9230: Remove magic numbers in GfshParserAutoCompletionIntegrati…
alb3rtobr opened a new pull request #6420:
URL: https://github.com/apache/geode/pull/6420
…onTest
`GfshParserAutoCompletionIntegrationTest` uses magic numbers in some tests. They depend on the number of possible parameters of `start server` command.
That means that when a new parameter is added to the `start server` command, some tests verifying the gfsh autocompletion feature are impacted, which has no sense.
The number of parameters can be calculated instead of hardcoded in order to remove this dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] alb3rtobr commented on pull request #6420: GEODE-9230: Remove magic numbers in GfshParserAutoCompletionIntegrati…
Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #6420:
URL: https://github.com/apache/geode/pull/6420#issuecomment-831768868
Code is ready but checks failed due to flaky test, so I have added an empty commit to get all tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal merged pull request #6420: GEODE-9230: Remove magic numbers in GfshParserAutoCompletionIntegrati…
Posted by GitBox <gi...@apache.org>.
onichols-pivotal merged pull request #6420:
URL: https://github.com/apache/geode/pull/6420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] alb3rtobr commented on pull request #6420: GEODE-9230: Remove magic numbers in GfshParserAutoCompletionIntegrati…
Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #6420:
URL: https://github.com/apache/geode/pull/6420#issuecomment-832131889
CI failed due to distributed test `org.apache.geode.management.AEQManagementDUnitTest.testCreateAEQWithDispatcherInPausedStateAndResumeAndVerifyUsingMBean` which is listed in the latest mass test report
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org