You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/29 07:43:21 UTC

[GitHub] [shardingsphere] cilfm opened a new pull request #10217: Update SQLServerDatabaseType.java fix#10126

cilfm opened a new pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217


   modify sqlserver database type condition
   
   Fixes #10126 
   
   Changes proposed in this pull request:
   -
   -
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] cilfm commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
cilfm commented on a change in pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r623748167



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/database/type/dialect/SQLServerDatabaseType.java
##########
@@ -41,7 +41,7 @@ public QuoteCharacter getQuoteCharacter() {
     
     @Override
     public Collection<String> getJdbcUrlPrefixes() {
-        return Collections.singletonList("jdbc:microsoft:sqlserver:");
+        return Collections.singletonList("jdbc:sqlserver:");

Review comment:
       You're right. I'm not thoughtful. I've submitted code that matches both cases at the same time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r624659440



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/database/type/dialect/SQLServerDatabaseTypeTest.java
##########
@@ -40,7 +42,7 @@ public void assertGetName() {
     
     @Test
     public void assertGetJdbcUrlPrefixes() {
-        assertThat(new SQLServerDatabaseType().getJdbcUrlPrefixes(), is(Collections.singletonList("jdbc:microsoft:sqlserver:")));
+    	assertThat(new SQLServerDatabaseType().getJdbcUrlPrefixes(), is(new ArrayList<String>(Arrays.asList("jdbc:microsoft:sqlserver:", "jdbc:sqlserver:"))));

Review comment:
       Hi, please keep two spaces here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] cilfm commented on pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
cilfm commented on pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#issuecomment-835740086


   I don't think it's necessary to add the current version. On the one hand, we can use SQL92 parser, on the other hand, it's not common to use other sqlserver drivers


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] cilfm commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
cilfm commented on a change in pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r627020589



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/database/type/dialect/SQLServerDatabaseTypeTest.java
##########
@@ -40,7 +42,7 @@ public void assertGetName() {
     
     @Test
     public void assertGetJdbcUrlPrefixes() {
-        assertThat(new SQLServerDatabaseType().getJdbcUrlPrefixes(), is(Collections.singletonList("jdbc:microsoft:sqlserver:")));
+    	assertThat(new SQLServerDatabaseType().getJdbcUrlPrefixes(), is(new ArrayList<String>(Arrays.asList("jdbc:microsoft:sqlserver:", "jdbc:sqlserver:"))));

Review comment:
       ouch~
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r622996004



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/database/type/dialect/SQLServerDatabaseType.java
##########
@@ -41,7 +41,7 @@ public QuoteCharacter getQuoteCharacter() {
     
     @Override
     public Collection<String> getJdbcUrlPrefixes() {
-        return Collections.singletonList("jdbc:microsoft:sqlserver:");
+        return Collections.singletonList("jdbc:sqlserver:");

Review comment:
       Hi @cilfm ,
   Glad to see your PR here.
   If your modification is an option for sqlserver's jdbc, I mean the pevious jdbc is still correct in some case, we can consider `microsoft?`. 
   Plus, it is required to add a test in its unit test class.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r627899427



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/database/type/DatabaseTypeRecognizerTest.java
##########
@@ -126,7 +126,7 @@ private DataSource mockDataSource(final DatabaseType databaseType) throws SQLExc
                 url = "jdbc:postgresql://localhost:5432/test";
                 break;
             case "SQL92":
-                url = "jdbc:sqlserver://127.0.0.1;DatabaseName=test";

Review comment:
       Hi why do you swap this URL?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] cilfm commented on pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
cilfm commented on pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#issuecomment-833424260


   I have removed the unused import -java.util.Collections


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r624659438



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/database/type/dialect/SQLServerDatabaseTypeTest.java
##########
@@ -40,7 +42,7 @@ public void assertGetName() {
     
     @Test
     public void assertGetJdbcUrlPrefixes() {
-        assertThat(new SQLServerDatabaseType().getJdbcUrlPrefixes(), is(Collections.singletonList("jdbc:microsoft:sqlserver:")));
+    	assertThat(new SQLServerDatabaseType().getJdbcUrlPrefixes(), is(new ArrayList<String>(Arrays.asList("jdbc:microsoft:sqlserver:", "jdbc:sqlserver:"))));

Review comment:
       Hi, please keep two blank spaces here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] cilfm commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
cilfm commented on a change in pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r628852915



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/database/type/DatabaseTypeRecognizerTest.java
##########
@@ -126,7 +126,7 @@ private DataSource mockDataSource(final DatabaseType databaseType) throws SQLExc
                 url = "jdbc:postgresql://localhost:5432/test";
                 break;
             case "SQL92":
-                url = "jdbc:sqlserver://127.0.0.1;DatabaseName=test";

Review comment:
       Because press the new matching pattern jdbc:sqlserver Return type SQLServer instead of SQL92




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] cilfm commented on pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
cilfm commented on pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#issuecomment-833611540


   This version is complete, but I found that there are several different driver packages for Java connection to SQL server, and their prefixes are different jdbc:sqlserver 、 jdbc:microsoft :sqlserver、 jdbc:jtds :sqlserver、 jdbc:odbc And so on. 
   If someone encounters this problem again in the future, I suggest replacing the driver package. Current version support jdbc:sqlserver and jdbc:microsoft:sqlserver
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#issuecomment-833340554


   Hi @cilfm ,
   The Travis CI build failed, could you give it a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#issuecomment-833629481


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10217?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10217](https://codecov.io/gh/apache/shardingsphere/pull/10217?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fccdba1) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d4b434290cdd252fcf8a7e08b9915d59f505489a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d4b4342) will **decrease** coverage by `0.18%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/10217/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/10217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #10217      +/-   ##
   ============================================
   - Coverage     68.12%   67.93%   -0.19%     
   - Complexity      680      683       +3     
   ============================================
     Files          1696     1706      +10     
     Lines         29111    29266     +155     
     Branches       5214     5263      +49     
   ============================================
   + Hits          19831    19881      +50     
   - Misses         7761     7845      +84     
   - Partials       1519     1540      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...a/database/type/dialect/SQLServerDatabaseType.java](https://codecov.io/gh/apache/shardingsphere/pull/10217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhYmFzZS90eXBlL2RpYWxlY3QvU1FMU2VydmVyRGF0YWJhc2VUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...and/query/binary/bind/PostgreSQLComBindPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/10217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9Qb3N0Z3JlU1FMQ29tQmluZFBhY2tldC5qYXZh) | `49.09% <0.00%> (-36.63%)` | `0.00% <0.00%> (ø%)` | |
   | [...broadcast/ShardingTableBroadcastRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS90eXBlL2Jyb2FkY2FzdC9TaGFyZGluZ1RhYmxlQnJvYWRjYXN0Um91dGluZ0VuZ2luZS5qYXZh) | `72.30% <0.00%> (-27.70%)` | `0.00% <0.00%> (ø%)` | |
   | [...e/registry/listener/metadata/MetaDataListener.java](https://codecov.io/gh/apache/shardingsphere/pull/10217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9saXN0ZW5lci9tZXRhZGF0YS9NZXRhRGF0YUxpc3RlbmVyLmphdmE=) | `40.00% <0.00%> (-25.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...or/statement/impl/SQL92DDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL3N0YXRlbWVudC9pbXBsL1NRTDkyRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `65.00% <0.00%> (-12.50%)` | `1.00% <0.00%> (ø%)` | |
   | [...dingsphere/sql/parser/sql/common/util/SQLUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/10217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3V0aWwvU1FMVXRpbC5qYXZh) | `29.50% <0.00%> (-5.11%)` | `0.00% <0.00%> (ø%)` | |
   | [...sitor/statement/impl/SQL92StatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL3N0YXRlbWVudC9pbXBsL1NRTDkyU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `73.91% <0.00%> (-2.68%)` | `1.00% <0.00%> (ø%)` | |
   | [...itor/statement/impl/OracleStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `69.33% <0.00%> (-2.57%)` | `1.00% <0.00%> (ø%)` | |
   | [...r/statement/impl/SQLServerStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWxzZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3Fsc2VydmVyL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvU1FMU2VydmVyU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `66.97% <0.00%> (-2.51%)` | `1.00% <0.00%> (ø%)` | |
   | [...protocol/PostgreSQLNumericBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/10217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMTnVtZXJpY0JpbmFyeVByb3RvY29sVmFsdWUuamF2YQ==) | `77.77% <0.00%> (-2.23%)` | `1.00% <0.00%> (ø%)` | |
   | ... and [134 more](https://codecov.io/gh/apache/shardingsphere/pull/10217/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10217?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10217?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d4b4342...fccdba1](https://codecov.io/gh/apache/shardingsphere/pull/10217?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #10217: Update SQLServerDatabaseType.java fix#10126

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#issuecomment-834037483


   > jdbc:jtds :sqlserver、 jdbc:odbc
   
   Hi @cilfm Thanks for your kind reminder. So do you think we still need to add two of JDBC patterns to SQLServerDatabaseType?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org