You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Nathan Mittler (JIRA)" <ji...@apache.org> on 2007/04/18 21:35:34 UTC
[jira] Created: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Pull out generic libraries from activemq-cpp namespace
------------------------------------------------------
Key: AMQCPP-103
URL: https://issues.apache.org/activemq/browse/AMQCPP-103
Project: ActiveMQ C++ Client
Issue Type: Improvement
Reporter: Nathan Mittler
Assigned To: Nathan Mittler
Fix For: 2.1
Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (AMQCPP-103) Pull out generic
libraries from activemq-cpp namespace
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39205 ]
Timothy Bish edited comment on AMQCPP-103 at 6/3/07 11:58 AM:
--------------------------------------------------------------
I created a first cut of decaf in trunk, it builds, runs unit tests, etc.
was:
I create a first cut of decaf in trunk, it builds, runs unit tests, etc.
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assignee: Timothy Bish
> Fix For: 2.1
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39254 ]
Timothy Bish commented on AMQCPP-103:
-------------------------------------
Ok, patches are applied. Also got all the unit tests ported over from AMQCPP things are shaping up nicely.
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assignee: Timothy Bish
> Fix For: 2.2
>
> Attachments: vs2005-decaf-v1.diff
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39247 ]
Timothy Bish commented on AMQCPP-103:
-------------------------------------
Done.
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assignee: Timothy Bish
> Fix For: 2.2
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Albert Strasheim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39248 ]
Albert Strasheim commented on AMQCPP-103:
-----------------------------------------
Not to be too picky ;), but the directory you added was called vc2005-build, as opposed to vs2005-build?
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assignee: Timothy Bish
> Fix For: 2.2
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish reassigned AMQCPP-103:
-----------------------------------
Assignee: Timothy Bish (was: Nathan Mittler)
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assignee: Timothy Bish
> Fix For: 2.1
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Albert Strasheim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Albert Strasheim updated AMQCPP-103:
------------------------------------
Attachment: vs2005-decaf-v1.diff
First try at Visual Studio 2005 build files.
I had to make a small fix to ServerSocket.cpp.
I also had to move the code in the headers of Boolean, Integer and Long into .cpp files to get the unit tests to link against the DLL version of the library. I'm not quite sure why this is necessary, but I couldn't find anything obvious via Google, so I went with the easy option (just move it).
All tests pass for all the builds.
There is one warning that might warrant a quick look:
1>..\src\main\decaf\io\ByteArrayInputStream.cpp(66) : warning C4996: 'std::copy': Function call with parameters that may be unsafe - this call relies on the caller to check that the passed values are correct. To disable this warning, use -D_SCL_SECURE_NO_WARNINGS. See documentation on how to use Visual C++ 'Checked Iterators'
1> C:\Program Files\Microsoft Visual Studio 8\VC\include\xutility(2370) : see declaration of 'std::copy'
I don't think all calls to std::copy necessarily cause this warning to be emitted, so it might be that there is something not quite right in the ByteArrayInputStream code.
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assignee: Timothy Bish
> Fix For: 2.2
>
> Attachments: vs2005-decaf-v1.diff
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39205 ]
Timothy Bish commented on AMQCPP-103:
-------------------------------------
I create a first cut of decaf in trunk, it builds, runs unit tests, etc.
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assignee: Timothy Bish
> Fix For: 2.1
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Albert Strasheim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39039 ]
Albert Strasheim commented on AMQCPP-103:
-----------------------------------------
I think it would be useful if the Decaf build supported building it as a shared library/DLL.
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assigned To: Nathan Mittler
> Fix For: 2.1
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39261 ]
Timothy Bish commented on AMQCPP-103:
-------------------------------------
I tweaked the ByteArrayInputStream code so that you shouldn't get a warning now, I hope.
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assignee: Timothy Bish
> Fix For: 2.2
>
> Attachments: vs2005-decaf-v1.diff
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39028 ]
Timothy Bish commented on AMQCPP-103:
-------------------------------------
Also when doing this, since we are aiming for a Java SDK like library we should attempt to mirror the JDK name spaces inside this new library better, we are fairly close right now, but not quite there.
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assigned To: Nathan Mittler
> Fix For: 2.1
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish updated AMQCPP-103:
--------------------------------
Fix Version/s: (was: 2.1)
2.2
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assignee: Timothy Bish
> Fix For: 2.2
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41282#action_41282 ]
Timothy Bish commented on AMQCPP-103:
-------------------------------------
I've run valgrind against the decaf unit test code and corrected several memory leaks in decaf and in its tests. Also I have a working build on Windows, minus a couple of problem methods that I commented out.
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assignee: Timothy Bish
> Fix For: 2.2
>
> Attachments: vs2005-decaf-v1.diff
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39249 ]
Timothy Bish commented on AMQCPP-103:
-------------------------------------
That's what I get for rushing, thanks, fixed now.
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assignee: Timothy Bish
> Fix For: 2.2
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Albert Strasheim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39246 ]
Albert Strasheim commented on AMQCPP-103:
-----------------------------------------
I'm assuming we want the Decaf VS2005 files to live in src/decaf/vs2005-build. If so, could you please add this empty directory to the repository. It'll make it easier for me to generate the patch.
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assignee: Timothy Bish
> Fix For: 2.2
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQCPP-103) Pull out generic libraries from
activemq-cpp namespace
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish resolved AMQCPP-103.
---------------------------------
Resolution: Fixed
The decaf code has been removed from the activemq namespace and is now in its own namespace. The decaf code now uses APR for platform independence except for a few cases where APR lacks functions.
The decaf code has not been removed and placed in its own library at this time in order to expedite the next release of activemq-cpp as we don't have time right now to work through all the DLL issues that we were encountering. The autoconf / automake scripts have been updated to find APR and configure the decaf dependencies. The Visual Studio 2005 projects have also been updated to build the new code and tests.
Once decaf matures more and we have time to investigate pulling the code out to a seperate library we should revisit this issue.
> Pull out generic libraries from activemq-cpp namespace
> ------------------------------------------------------
>
> Key: AMQCPP-103
> URL: https://issues.apache.org/activemq/browse/AMQCPP-103
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Nathan Mittler
> Assignee: Timothy Bish
> Fix For: 2.2
>
> Attachments: vs2005-decaf-v1.diff
>
>
> Since many of the libraries in activemq-cpp are not activemq-specific, we should move them to their own namespace. Eventually, it would be nice for these classes to become their own project, similar to APR. Since the classes mirror Java classes, we're proposing the name "decaf" for the new namespace :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.