You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/05/19 07:11:48 UTC
[GitHub] [bookkeeper] wolfstudy opened a new pull request, #3283: Fix the 3144 revert issue
wolfstudy opened a new pull request, #3283:
URL: https://github.com/apache/bookkeeper/pull/3283
Signed-off-by: xiaolongran <xi...@tencent.com>
### Motivation
In #3144, we reverted the changes of #2686, but after the revert, the self-increment behavior of deletedEntries was also removed, resulting in deletedEntries No assignment, always 0.
In #2686
<img width="1501" alt="image" src="https://user-images.githubusercontent.com/20965307/169231903-1a0bee03-f602-4c61-9c98-6b832f75648f.png">
In #3144
<img width="1352" alt="image" src="https://user-images.githubusercontent.com/20965307/169232028-658a1182-d8c5-4cfa-8f39-2ed7416ee508.png">
### Changes
- Add `++deletedEntries` for removeOffsetFromDeletedLedgers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wolfstudy commented on pull request #3283: Fix the 3144 revert issue
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on PR #3283:
URL: https://github.com/apache/bookkeeper/pull/3283#issuecomment-1195240110
> ping @wolfstudy, Would you please rebase the master to make the CI pass?
Sure, will process
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 merged pull request #3283: Fix the 3144 revert issue
Posted by GitBox <gi...@apache.org>.
hangc0276 merged PR #3283:
URL: https://github.com/apache/bookkeeper/pull/3283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3283: Fix the 3144 revert issue
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3283:
URL: https://github.com/apache/bookkeeper/pull/3283#issuecomment-1193456044
@wolfstudy Would you please rebase the master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3283: Fix the 3144 revert issue
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3283:
URL: https://github.com/apache/bookkeeper/pull/3283#issuecomment-1195238776
ping @wolfstudy, Would you please rebase the master to make the CI pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org