You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/13 13:17:37 UTC
[GitHub] [pulsar] hpa16 opened a new pull request, #16575: [improve][doc] Highlight important tips
hpa16 opened a new pull request, #16575:
URL: https://github.com/apache/pulsar/pull/16575
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Fixes #15892
### Motivation
Improve docs by highlighting important tips for higher impact
### Modifications
Used a tip tag instead of an important tag
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Screenshot
<img width="1779" alt="Screenshot 2022-07-13 at 6 42 56 PM" src="https://user-images.githubusercontent.com/29160872/178742062-c6349ba0-b311-4c99-b519-584877fbd944.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #16575: [improve][doc] Highlight important tips
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #16575:
URL: https://github.com/apache/pulsar/pull/16575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hpa16 commented on pull request #16575: [improve][doc] Highlight important tips
Posted by GitBox <gi...@apache.org>.
hpa16 commented on PR #16575:
URL: https://github.com/apache/pulsar/pull/16575#issuecomment-1183218704
Hi @Anonymitaet, I see that the Connector Admin CLI page has an Important tag nested under a Note. Would you like me to convert that to a Tip too? Attaching a screenshot
<img width="1766" alt="Screenshot 2022-07-13 at 6 07 00 PM" src="https://user-images.githubusercontent.com/29160872/178743651-c1ddefe9-40b3-40d4-90a9-931b9d4943bd.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #16575: [improve][doc] Highlight important tips
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16575:
URL: https://github.com/apache/pulsar/pull/16575#issuecomment-1183859492
> Hi @Anonymitaet, I see that the Connector Admin CLI page has an Important tag nested under a Note. Would you like me to convert that to a Tip too? Attaching a screenshot
>
> <img alt="Screenshot 2022-07-13 at 6 07 00 PM" width="1766" src="https://user-images.githubusercontent.com/29160872/178743651-c1ddefe9-40b3-40d4-90a9-931b9d4943bd.png">
Yes, thanks for your contritbution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org