You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "James Mansion (JIRA)" <qp...@incubator.apache.org> on 2009/03/13 22:38:50 UTC

[jira] Created: (QPID-1737) qpid C++ will not build with WinSDK 7

qpid C++ will not build with WinSDK 7
-------------------------------------

                 Key: QPID-1737
                 URL: https://issues.apache.org/jira/browse/QPID-1737
             Project: Qpid
          Issue Type: Bug
          Components: C++ Broker
    Affects Versions: M4
         Environment: XP 32 bit with latest SDK from Microsoft (SDK 7 beta)
            Reporter: James Mansion


I'm trying to build M4 of AMQP on XP with the Win7 SDK Beta, and I'm seeing that

Manageable::STATUS_INVALID_PARAMETER

is being expanded to:

Manageable::((DWORD )0xC000000DL);

I think this is because src\qpid/sys/windows/uuid.h has included rpc.h and included a lot of the SDK as a result.

STATUS_INVALID_PARAMETER is defined in ntstatus.h and winnt.h.

The include structure is rather Byzantine - I see there's a JIRA to tidy things up, though that is focussed on client applications.

I suspect that one way or another this will bite again even if sufficient 'undefs' are added in the code now.

I know this is Microsoft's bad for namespace pollution, but the practical answer is to change the name of this constant. 


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-1737) qpid C++ will not build with WinSDK 7

Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733837#action_12733837 ] 

Steve Huston commented on QPID-1737:
------------------------------------

This appears to have been resolved, at least on the current trunk, by moving the rpc.h include from uuid.h to uuid.cpp.

James, could you please verify that this build works when you have a chance?


> qpid C++ will not build with WinSDK 7
> -------------------------------------
>
>                 Key: QPID-1737
>                 URL: https://issues.apache.org/jira/browse/QPID-1737
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: M4
>         Environment: XP 32 bit with latest SDK from Microsoft (SDK 7 beta)
>            Reporter: James Mansion
>            Assignee: Steve Huston
>         Attachments: SIP.patch
>
>
> I'm trying to build M4 of AMQP on XP with the Win7 SDK Beta, and I'm seeing that
> Manageable::STATUS_INVALID_PARAMETER
> is being expanded to:
> Manageable::((DWORD )0xC000000DL);
> I think this is because src\qpid/sys/windows/uuid.h has included rpc.h and included a lot of the SDK as a result.
> STATUS_INVALID_PARAMETER is defined in ntstatus.h and winnt.h.
> The include structure is rather Byzantine - I see there's a JIRA to tidy things up, though that is focussed on client applications.
> I suspect that one way or another this will bite again even if sufficient 'undefs' are added in the code now.
> I know this is Microsoft's bad for namespace pollution, but the practical answer is to change the name of this constant. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Closed: (QPID-1737) qpid C++ will not build with WinSDK 7

Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Stitcher closed QPID-1737.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.6

As best I can tell this now builds correctly on Windows and Linux

> qpid C++ will not build with WinSDK 7
> -------------------------------------
>
>                 Key: QPID-1737
>                 URL: https://issues.apache.org/jira/browse/QPID-1737
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: M4
>         Environment: XP 32 bit with latest SDK from Microsoft (SDK 7 beta)
>            Reporter: James Mansion
>            Assignee: Steve Huston
>             Fix For: 0.6
>
>         Attachments: SIP.patch
>
>
> I'm trying to build M4 of AMQP on XP with the Win7 SDK Beta, and I'm seeing that
> Manageable::STATUS_INVALID_PARAMETER
> is being expanded to:
> Manageable::((DWORD )0xC000000DL);
> I think this is because src\qpid/sys/windows/uuid.h has included rpc.h and included a lot of the SDK as a result.
> STATUS_INVALID_PARAMETER is defined in ntstatus.h and winnt.h.
> The include structure is rather Byzantine - I see there's a JIRA to tidy things up, though that is focussed on client applications.
> I suspect that one way or another this will bite again even if sufficient 'undefs' are added in the code now.
> I know this is Microsoft's bad for namespace pollution, but the practical answer is to change the name of this constant. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-1737) qpid C++ will not build with WinSDK 7

Posted by "James Mansion (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Mansion updated QPID-1737:
--------------------------------

    Attachment: SIP.patch

Patch attached - replaces STATUS_INVALID_PARAMETER with STATUS_PARAMETER_INVALID.

> qpid C++ will not build with WinSDK 7
> -------------------------------------
>
>                 Key: QPID-1737
>                 URL: https://issues.apache.org/jira/browse/QPID-1737
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: M4
>         Environment: XP 32 bit with latest SDK from Microsoft (SDK 7 beta)
>            Reporter: James Mansion
>         Attachments: SIP.patch
>
>
> I'm trying to build M4 of AMQP on XP with the Win7 SDK Beta, and I'm seeing that
> Manageable::STATUS_INVALID_PARAMETER
> is being expanded to:
> Manageable::((DWORD )0xC000000DL);
> I think this is because src\qpid/sys/windows/uuid.h has included rpc.h and included a lot of the SDK as a result.
> STATUS_INVALID_PARAMETER is defined in ntstatus.h and winnt.h.
> The include structure is rather Byzantine - I see there's a JIRA to tidy things up, though that is focussed on client applications.
> I suspect that one way or another this will bite again even if sufficient 'undefs' are added in the code now.
> I know this is Microsoft's bad for namespace pollution, but the practical answer is to change the name of this constant. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Reopened: (QPID-1737) qpid C++ will not build with WinSDK 7

Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Huston reopened QPID-1737:
--------------------------------


Reverted on trunk at r758419, and reopened.

> qpid C++ will not build with WinSDK 7
> -------------------------------------
>
>                 Key: QPID-1737
>                 URL: https://issues.apache.org/jira/browse/QPID-1737
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: M4
>         Environment: XP 32 bit with latest SDK from Microsoft (SDK 7 beta)
>            Reporter: James Mansion
>            Assignee: Steve Huston
>         Attachments: SIP.patch
>
>
> I'm trying to build M4 of AMQP on XP with the Win7 SDK Beta, and I'm seeing that
> Manageable::STATUS_INVALID_PARAMETER
> is being expanded to:
> Manageable::((DWORD )0xC000000DL);
> I think this is because src\qpid/sys/windows/uuid.h has included rpc.h and included a lot of the SDK as a result.
> STATUS_INVALID_PARAMETER is defined in ntstatus.h and winnt.h.
> The include structure is rather Byzantine - I see there's a JIRA to tidy things up, though that is focussed on client applications.
> I suspect that one way or another this will bite again even if sufficient 'undefs' are added in the code now.
> I know this is Microsoft's bad for namespace pollution, but the practical answer is to change the name of this constant. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-1737) qpid C++ will not build with WinSDK 7

Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Huston updated QPID-1737:
-------------------------------

    Fix Version/s:     (was: 0.5)

The patch was reverted for M5 (reverted in r758417) - it breaks the Linux build.

Also, the affected token is part of the API for users outside of Apache.

> qpid C++ will not build with WinSDK 7
> -------------------------------------
>
>                 Key: QPID-1737
>                 URL: https://issues.apache.org/jira/browse/QPID-1737
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: M4
>         Environment: XP 32 bit with latest SDK from Microsoft (SDK 7 beta)
>            Reporter: James Mansion
>            Assignee: Steve Huston
>         Attachments: SIP.patch
>
>
> I'm trying to build M4 of AMQP on XP with the Win7 SDK Beta, and I'm seeing that
> Manageable::STATUS_INVALID_PARAMETER
> is being expanded to:
> Manageable::((DWORD )0xC000000DL);
> I think this is because src\qpid/sys/windows/uuid.h has included rpc.h and included a lot of the SDK as a result.
> STATUS_INVALID_PARAMETER is defined in ntstatus.h and winnt.h.
> The include structure is rather Byzantine - I see there's a JIRA to tidy things up, though that is focussed on client applications.
> I suspect that one way or another this will bite again even if sufficient 'undefs' are added in the code now.
> I know this is Microsoft's bad for namespace pollution, but the practical answer is to change the name of this constant. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Resolved: (QPID-1737) qpid C++ will not build with WinSDK 7

Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Huston resolved QPID-1737.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.5
         Assignee: Steve Huston

Patch applied; 0.5: r758356  trunk: r758359

> qpid C++ will not build with WinSDK 7
> -------------------------------------
>
>                 Key: QPID-1737
>                 URL: https://issues.apache.org/jira/browse/QPID-1737
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: M4
>         Environment: XP 32 bit with latest SDK from Microsoft (SDK 7 beta)
>            Reporter: James Mansion
>            Assignee: Steve Huston
>             Fix For: 0.5
>
>         Attachments: SIP.patch
>
>
> I'm trying to build M4 of AMQP on XP with the Win7 SDK Beta, and I'm seeing that
> Manageable::STATUS_INVALID_PARAMETER
> is being expanded to:
> Manageable::((DWORD )0xC000000DL);
> I think this is because src\qpid/sys/windows/uuid.h has included rpc.h and included a lot of the SDK as a result.
> STATUS_INVALID_PARAMETER is defined in ntstatus.h and winnt.h.
> The include structure is rather Byzantine - I see there's a JIRA to tidy things up, though that is focussed on client applications.
> I suspect that one way or another this will bite again even if sufficient 'undefs' are added in the code now.
> I know this is Microsoft's bad for namespace pollution, but the practical answer is to change the name of this constant. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org