You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/12/06 14:09:08 UTC
Review Request 54422: Removed test assumptions about arrival order of
status updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54422/
-----------------------------------------------------------
Review request for mesos and Anand Mazumdar.
Repository: mesos
Description
-------
Task status updates can arrive in any order. Adjusted the code to not
assume a particual order.
Diffs
-----
src/tests/slave_tests.cpp 3d06c3a4a74bbcba4c9b6bdba4258c5aefdab845
Diff: https://reviews.apache.org/r/54422/diff/
Testing
-------
* `make check` on OS X, clang-trunk w/o optimizations
* `SlaveTest.*` in repetation
Thanks,
Benjamin Bannier
Re: Review Request 54422: Removed test assumptions about arrival
order of status updates.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54422/#review159060
-----------------------------------------------------------
Ship it!
Thanks for the cleanup!
- Anand Mazumdar
On Dec. 6, 2016, 2:09 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54422/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 2:09 p.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Task status updates can arrive in any order. Adjusted the code to not
> assume a particual order.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 3d06c3a4a74bbcba4c9b6bdba4258c5aefdab845
>
> Diff: https://reviews.apache.org/r/54422/diff/
>
>
> Testing
> -------
>
> * `make check` on OS X, clang-trunk w/o optimizations
> * `SlaveTest.*` in repetation
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 54422: Removed test assumptions about arrival
order of status updates.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54422/#review158211
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54422]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 6, 2016, 2:09 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54422/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 2:09 p.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Task status updates can arrive in any order. Adjusted the code to not
> assume a particual order.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 3d06c3a4a74bbcba4c9b6bdba4258c5aefdab845
>
> Diff: https://reviews.apache.org/r/54422/diff/
>
>
> Testing
> -------
>
> * `make check` on OS X, clang-trunk w/o optimizations
> * `SlaveTest.*` in repetation
>
>
> Thanks,
>
> Benjamin Bannier
>
>