You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by original-brownbear <gi...@git.apache.org> on 2017/02/19 09:26:33 UTC
[GitHub] kafka pull request #2574: MINOR: Fixed 3 inner classes without instance refe...
GitHub user original-brownbear opened a pull request:
https://github.com/apache/kafka/pull/2574
MINOR: Fixed 3 inner classes without instance reference to be static
* Turned 3 inner classes that weren't static but could be into `static` ones.
* Turned one `public` inner class that wasn't used publicly into a `private`.
Trivial but imo worthwhile to explicitly keep visibility and "staticness" correct in syntax (if only to be nice to the GC) :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/original-brownbear/kafka cleanup-inner-nonstatic
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2574.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2574
----
commit 9b0bf675f46e8a628ecb4ed4a56ba2e4bf184bfc
Author: Armin Braun <me...@obrown.io>
Date: 2017-02-19T09:19:37Z
MINOR: Fixed 3 inner classes without instance reference to be static
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #2574: MINOR: Fixed 3 inner classes without instance refe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/2574
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---