You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/28 22:18:36 UTC

[GitHub] [arrow] aucahuasi commented on a diff in pull request #14747: ARROW-18113: [C++] Use RandomAccessFile::ReadManyAsync for cloud file systems

aucahuasi commented on code in PR #14747:
URL: https://github.com/apache/arrow/pull/14747#discussion_r1034108606


##########
cpp/src/arrow/filesystem/s3fs.h:
##########
@@ -167,6 +168,12 @@ struct ARROW_EXPORT S3Options {
   /// delay between retries.
   std::shared_ptr<S3RetryStrategy> retry_strategy;
 
+  /// Coalesce options for requesting multiple reads at once
+  io::CoalesceOptions coalesceOptions = io::CoalesceOptions::Defaults();

Review Comment:
   thanks, btw I'll use here `io::CoalesceOptions::MakeFromNetworkMetrics(5, 500)` as default value (i.e. `hole_size_limit = 2.5 MiB` and `range_size_limit = 22.5 MiB`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org