You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/20 06:55:05 UTC

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2347: Enable format check for syslog

yamt commented on a change in pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#discussion_r527476356



##########
File path: include/nuttx/compiler.h
##########
@@ -144,6 +144,7 @@
 #  define noinline_function __attribute__ ((noinline))
 
 #  define printflike(a, b) __attribute__((__format__ (__printf__, a, b)))
+#  define sysloglike(a, b) __attribute__((__format__ (__printf__, a, b)))

Review comment:
       i separated them because syslog is not quite printf.
   the implementations in gcc/clang might or might not need to distinguish them. (i guess not. but i dunno.)
   anyway the separation makes the intention clear.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org