You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2009/09/04 23:30:58 UTC
[jira] Commented: (HTTPCORE-205) AbstractMultiworkerIOReactor needs
optional Latch to signal when ready.
[ https://issues.apache.org/jira/browse/HTTPCORE-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751623#action_12751623 ]
Oleg Kalnichevski commented on HTTPCORE-205:
--------------------------------------------
Patrick,
Actually why do care when the worker threads are started at all? What is important that the I/O reactor is ready to accept incoming connections. Why do not you simply use ListenerEndpoint#waitFor() method to wait for a listener to become ready? This, I believe, should eliminate the need for a countdown latch.
For details see
http://hc.apache.org/httpcomponents-core/tutorial/html/nio.html#d0e1207
Oleg
> AbstractMultiworkerIOReactor needs optional Latch to signal when ready.
> -----------------------------------------------------------------------
>
> Key: HTTPCORE-205
> URL: https://issues.apache.org/jira/browse/HTTPCORE-205
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Affects Versions: 4.0.1
> Reporter: Patrick Moore
> Fix For: 4.1
>
> Attachments: AbstractMultiworkerIOReactor.patch
>
>
> AbstractMultiworkerIOReactor may take some time getting ready ( needs to start threads for example ). In order to ensure that it is ready before starting to send requests, a CountDownLatch is needed.
> This is important for our test suites which are launch the reactor and then immediately trying to hit it. ( and failing )
> for (int i = 0; i < this.workerCount; i++) {
> if (this.status != IOReactorStatus.ACTIVE) {
> return;
> }
> this.threads[i].start();
> }
> LINE 303: this.countDownLatch.countDown(); <<<<<<<
> for (;;) {
> int readyCount;
> try {
> readyCount = this.selector.select(this.selectTimeout);
> } catch (InterruptedIOException ex) {
> throw ex;
> } catch (IOException ex) {
> throw new IOReactorException("Unexpected selector failure", ex);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org