You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2026/02/20 11:33:07 UTC
[PR] GH-41624: [C++] Add missing system Boost dependency to bundled Apache Thrift [arrow]
kou opened a new pull request, #49346:
URL: https://github.com/apache/arrow/pull/49346
### Rationale for this change
Some public headers in Apache Thrift depend on Boost. So our bundled Apache Thrift CMake target must depend on Boost. We set it for system Apache Thrift but doesn't for bundled Apache Thrift + system Boost.
### What changes are included in this PR?
* Add `Boost::headers` dependencies to bundled Apache Thrift even when we use system Boost.
* Remove redundant `Boost::headers` dependency from `PARQUET_TEST_LINK_LIBS`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41624: [C++] Add missing system Boost dependency to bundled Apache Thrift [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49346:
URL: https://github.com/apache/arrow/pull/49346#issuecomment-3933379618
:warning: GitHub issue #41624 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41624: [C++] Add missing system Boost dependency to bundled Apache Thrift [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49346:
URL: https://github.com/apache/arrow/pull/49346#issuecomment-3939598497
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b7ed8df53b7f2553578b34f867f4c6c036ca45eb.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/64410692125) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41624: [C++] Add missing system Boost dependency to bundled Apache Thrift [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #49346:
URL: https://github.com/apache/arrow/pull/49346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org