You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/07/17 03:08:38 UTC
[GitHub] [incubator-yunikorn-site] manirajv06 opened a new pull request #64: YUNIKORN-746: Simplify the REST API document
manirajv06 opened a new pull request #64:
URL: https://github.com/apache/incubator-yunikorn-site/pull/64
Doc changes to clearly explain the Old and Newer version API's use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] yangwwei commented on a change in pull request #64: YUNIKORN-746: Simplify the REST API document
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #64:
URL: https://github.com/apache/incubator-yunikorn-site/pull/64#discussion_r671888257
##########
File path: docs/api/scheduler.md
##########
@@ -88,7 +88,9 @@ Displays general information about the partition like name, state, capacity, use
}
```
-## Queues (Newer Version)
+## Queues
+
+### Single Partition
Review comment:
Partition queues
##########
File path: docs/api/scheduler.md
##########
@@ -217,7 +219,9 @@ For the default queue hierarchy (only `root.default` leaf queue exists) a simila
}
```
-## Applications (Newer Version)
+## Applications
+
+### Single Partition
Review comment:
Queue applications
##########
File path: docs/api/scheduler.md
##########
@@ -401,7 +405,9 @@ In the example below there are three allocations belonging to two applications.
]
```
-## Nodes (Newer Version)
+## Nodes
+
+### Single Partition
Review comment:
Partition nodes
##########
File path: docs/api/scheduler.md
##########
@@ -319,7 +323,7 @@ In the example below there are three allocations belonging to two applications.
}
```
-## Applications
+### All Partitions
Review comment:
All applications
##########
File path: docs/api/scheduler.md
##########
@@ -162,7 +164,7 @@ For the default queue hierarchy (only `root.default` leaf queue exists) a simila
}
```
-## Queues
+### All Partitions
Review comment:
All queues
##########
File path: docs/api/scheduler.md
##########
@@ -508,7 +514,7 @@ Here you can see an example response from a 2-node cluster having 3 allocations.
}
```
-## Nodes
+### All Partitions
Review comment:
All nodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] manirajv06 commented on pull request #64: YUNIKORN-746: Simplify the REST API document
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on pull request #64:
URL: https://github.com/apache/incubator-yunikorn-site/pull/64#issuecomment-882069888
Taken care. Pls check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] yangwwei merged pull request #64: YUNIKORN-746: Simplify the REST API document
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #64:
URL: https://github.com/apache/incubator-yunikorn-site/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] yangwwei commented on pull request #64: YUNIKORN-746: Simplify the REST API document
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #64:
URL: https://github.com/apache/incubator-yunikorn-site/pull/64#issuecomment-881811821
hi @manirajv06 thanks for working on this. Can we remove the "Deprecated" and "Newer version" in the doc, and merge them into one section? For queus/apps/nodes, we should only have one section each, and the old/new API can all be explained in each single section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org