[GitHub] [carbondata] QiangCai commented on a change in pull request #3757: [CARBONDATA-3812] Set output metrics for data load spark job

[GitBox <gi...@apache.org>]

QiangCai commented on a change in pull request #3757:
URL: https://github.com/apache/carbondata/pull/3757#discussion_r422760244



##########
File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala
##########
@@ -316,6 +319,7 @@ class NewDataFrameLoaderRDD[K, V](
             carbonLoadModel.getTableName,
             carbonLoadModel.getSegment.getSegmentNo))
         executor.execute(model, loader.storeLocation, recordReaders.toArray)
+        executor.close()

Review comment:
       it already added, but we need to invoke it before upload metrics.
   

##########
File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala
##########
@@ -160,6 +161,7 @@ class NewCarbonDataLoadRDD[K, V](
         executor.execute(model,
           loader.storeLocation,
           recordReaders)
+        executor.close()

Review comment:
       it already added, but we need to invoke it before upload metrics.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org