You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by gi...@git.apache.org on 2017/05/27 02:22:14 UTC

[GitHub] jacobrosenthal opened a new pull request #296: Gap log

jacobrosenthal opened a new pull request #296: Gap log
URL: https://github.com/apache/incubator-mynewt-core/pull/296
 
 
   ble_gap_log_adv  is referencing globals that have not been set yet, instead of what was passed to it. Secondarily, there are ble_gap_log_adv struct members that arent actually used? 
   
   Several ways to fix this. Could log after the globals are set ( and keep them even though theyre unused, maybe someone has a future plan here...) Or reference the passed object only and clean house as I have.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services