You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Ashish Singh <as...@cloudera.com> on 2015/07/18 07:02:08 UTC

Review Request 36593: Patch for KAFKA-2347

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36593/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-2347
    https://issues.apache.org/jira/browse/KAFKA-2347


Repository: kafka


Description
-------

KAFKA-2347: Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api


Diffs
-----

  core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java ca74ca8abf03478b6de4ec1f82fbac379e7603f1 

Diff: https://reviews.apache.org/r/36593/diff/


Testing
-------


Thanks,

Ashish Singh

Re: Review Request 36593: Patch for KAFKA-2347

Posted by Jiangjie Qin <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36593/#review92178
-----------------------------------------------------------

Ship it!


LGTM. Thanks.

- Jiangjie Qin


On July 18, 2015, 5:02 a.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36593/
> -----------------------------------------------------------
> 
> (Updated July 18, 2015, 5:02 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2347
>     https://issues.apache.org/jira/browse/KAFKA-2347
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2347: Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java ca74ca8abf03478b6de4ec1f82fbac379e7603f1 
> 
> Diff: https://reviews.apache.org/r/36593/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>

Re: Review Request 36593: Patch for KAFKA-2347

Posted by Ismael Juma <mi...@juma.me.uk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36593/#review92179
-----------------------------------------------------------


There is a typo in the commit message: "ZookeeperConsuemrConnector". The rest looks good.

- Ismael Juma


On July 18, 2015, 5:02 a.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36593/
> -----------------------------------------------------------
> 
> (Updated July 18, 2015, 5:02 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2347
>     https://issues.apache.org/jira/browse/KAFKA-2347
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2347: Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java ca74ca8abf03478b6de4ec1f82fbac379e7603f1 
> 
> Diff: https://reviews.apache.org/r/36593/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>

Re: Review Request 36593: Patch for KAFKA-2347

Posted by Grant Henke <gr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36593/#review92410
-----------------------------------------------------------

Ship it!


Ship It!

- Grant Henke


On July 18, 2015, 10:14 p.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36593/
> -----------------------------------------------------------
> 
> (Updated July 18, 2015, 10:14 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2347
>     https://issues.apache.org/jira/browse/KAFKA-2347
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2347: Add setConsumerRebalanceListener method to ZookeeperConsumerConnector java api
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java ca74ca8abf03478b6de4ec1f82fbac379e7603f1 
> 
> Diff: https://reviews.apache.org/r/36593/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>

Re: Review Request 36593: Patch for KAFKA-2347

Posted by Ismael Juma <mi...@juma.me.uk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36593/#review92190
-----------------------------------------------------------

Ship it!


Ship It!

- Ismael Juma


On July 18, 2015, 10:14 p.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36593/
> -----------------------------------------------------------
> 
> (Updated July 18, 2015, 10:14 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2347
>     https://issues.apache.org/jira/browse/KAFKA-2347
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2347: Add setConsumerRebalanceListener method to ZookeeperConsumerConnector java api
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java ca74ca8abf03478b6de4ec1f82fbac379e7603f1 
> 
> Diff: https://reviews.apache.org/r/36593/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>

Re: Review Request 36593: Patch for KAFKA-2347

Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36593/#review93352
-----------------------------------------------------------

Ship it!


Ship It!

- Guozhang Wang


On July 18, 2015, 10:14 p.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36593/
> -----------------------------------------------------------
> 
> (Updated July 18, 2015, 10:14 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2347
>     https://issues.apache.org/jira/browse/KAFKA-2347
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2347: Add setConsumerRebalanceListener method to ZookeeperConsumerConnector java api
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java ca74ca8abf03478b6de4ec1f82fbac379e7603f1 
> 
> Diff: https://reviews.apache.org/r/36593/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>

Re: Review Request 36593: Patch for KAFKA-2347

Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36593/
-----------------------------------------------------------

(Updated July 18, 2015, 10:14 p.m.)


Review request for kafka.


Bugs: KAFKA-2347
    https://issues.apache.org/jira/browse/KAFKA-2347


Repository: kafka


Description (updated)
-------

KAFKA-2347: Add setConsumerRebalanceListener method to ZookeeperConsumerConnector java api


Diffs (updated)
-----

  core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java ca74ca8abf03478b6de4ec1f82fbac379e7603f1 

Diff: https://reviews.apache.org/r/36593/diff/


Testing
-------


Thanks,

Ashish Singh