[PR] Avoid rest routes dupes [camel]

["Croway (via GitHub)" <gi...@apache.org>]

Croway opened a new pull request, #13509:
URL: https://github.com/apache/camel/pull/13509

   In the case of a Camel Spring Boot application that defines rest routes in camel-xml-io-dsl, rest routes in java dsl, and rest routes spring beans xml, the rest routes are loaded twice in the context and the application cannot start.
   
   I noticed that rests defined in camel-xml-io-dsl and java route configuration are loaded first, together, without issues, but when the rests defined in the spring beans xml are loaded into the camel context, the getContext().getRestDefinitions() contains both the rests defined in the spring beans xml and the rests defined via java or camel-xml, this is why they are loaded twice, getRests() contains only rests defined in the beans xml dsl.
   
   I'm opening the PR in draft, I'd like to execute more tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CAMEL-20577] Avoid rest routes dupes [camel]

["Croway (via GitHub)" <gi...@apache.org>]

Croway commented on PR #13509:
URL: https://github.com/apache/camel/pull/13509#issuecomment-2007246431

   I'll merge this one, I'm adding tests in camel-spring-boot repository


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CAMEL-20577] Avoid rest routes dupes [camel]

["Croway (via GitHub)" <gi...@apache.org>]

Croway merged PR #13509:
URL: https://github.com/apache/camel/pull/13509


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Avoid rest routes dupes [camel]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #13509:
URL: https://github.com/apache/camel/pull/13509#issuecomment-2000089925

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions to run
   
   * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org