You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/15 17:40:51 UTC

[GitHub] [activemq-artemis] jbertram commented on a change in pull request #3490: ARTEMIS-3175 - implement address setting management-message-attribute…

jbertram commented on a change in pull request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594549339



##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/ICoreMessage.java
##########
@@ -102,10 +102,11 @@
 
    /**
     * @return Returns the message in Map form, useful when encoding to JSON
+    * @param valueSizeLimit
     */
    @Override
-   default Map<String, Object> toMap() {
-      Map map = toPropertyMap();
+   default Map<String, Object> toMap(int valueSizeLimit) {

Review comment:
       IMO you should overload this method, i.e. have `toMap()` and `toMap(int)`. Then the default implementation of `toMap()` can simply invoke `toMap(0)`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org