You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by la...@apache.org on 2019/06/24 05:07:23 UTC
[phoenix] branch master updated: PHOENIX-5351 Speedup
OrphanViewToolIT.
This is an automated email from the ASF dual-hosted git repository.
larsh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/phoenix.git
The following commit(s) were added to refs/heads/master by this push:
new 29e2977 PHOENIX-5351 Speedup OrphanViewToolIT.
29e2977 is described below
commit 29e297748b3599ca1c53ee38d0fc67b63de0d27c
Author: Lars Hofhansl <la...@apache.org>
AuthorDate: Sun Jun 23 22:07:37 2019 -0700
PHOENIX-5351 Speedup OrphanViewToolIT.
---
.../org/apache/phoenix/end2end/OrphanViewToolIT.java | 18 +++++-------------
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/phoenix-core/src/it/java/org/apache/phoenix/end2end/OrphanViewToolIT.java b/phoenix-core/src/it/java/org/apache/phoenix/end2end/OrphanViewToolIT.java
index 7a05d27..32ec586 100644
--- a/phoenix-core/src/it/java/org/apache/phoenix/end2end/OrphanViewToolIT.java
+++ b/phoenix-core/src/it/java/org/apache/phoenix/end2end/OrphanViewToolIT.java
@@ -57,7 +57,6 @@ public class OrphanViewToolIT extends ParallelStatsDisabledIT {
private static final Logger LOGGER = LoggerFactory.getLogger(OrphanViewToolIT.class);
private final boolean isMultiTenant;
- private final boolean columnEncoded;
private static final long fanout = 2;
private static final long childCount = fanout;
@@ -118,16 +117,13 @@ public class OrphanViewToolIT extends ParallelStatsDisabledIT {
private static final String deleteSchemaRows = "DELETE FROM %s WHERE " + TABLE_SCHEM + " %s";
- public OrphanViewToolIT(boolean isMultiTenant, boolean columnEncoded) {
+ public OrphanViewToolIT(boolean isMultiTenant) {
this.isMultiTenant = isMultiTenant;
- this.columnEncoded = columnEncoded;
}
- @Parameters(name="OrphanViewToolIT_multiTenant={0}, columnEncoded={1}") // name is used by failsafe as file name in reports
- public static Collection<Boolean[]> data() {
- return Arrays.asList(new Boolean[][] {
- { false, false }, { false, true },
- { true, false }, { true, true } });
+ @Parameters(name="OrphanViewToolIT_multiTenant={0}") // name is used by failsafe as file name in reports
+ public static Collection<Boolean> data() {
+ return Arrays.asList(false, true);
}
@AfterClass
@@ -146,11 +142,6 @@ public class OrphanViewToolIT extends ParallelStatsDisabledIT {
private String generateDDL(String options, String format) {
StringBuilder optionsBuilder = new StringBuilder(options);
- if (!columnEncoded) {
- if (optionsBuilder.length()!=0)
- optionsBuilder.append(",");
- optionsBuilder.append("COLUMN_ENCODED_BYTES=0");
- }
if (isMultiTenant) {
if (optionsBuilder.length()!=0)
optionsBuilder.append(",");
@@ -216,6 +207,7 @@ public class OrphanViewToolIT extends ParallelStatsDisabledIT {
if (count != lineCount)
LOGGER.debug(count + " != " + lineCount);
assertTrue(count == lineCount);
+ reader.close();
}
private void verifyCountQuery(Connection connection, String query, String schemaName, long count)