You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/23 06:10:48 UTC
[GitHub] [superset] geido opened a new pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
geido opened a new pull request #12229:
URL: https://github.com/apache/superset/pull/12229
### SUMMARY
This PR introduces an entirely new Icon system that uses a combination of the Antd Custom Icon and Emotion while consolidating the usage of icons.
- Use existing Antd icons with the ability to enhance them
- Use custom icons trough the Antd Custom Icon component and the ability to enhance them
- Adds the ability to override any Antd existing icon with a custom one
As an example implementation, the following sections have been changed to use some of the icons under the new icon system:
- Charts lists
- Dashboards lists
- Saved Queries lists
- Datasets lists
- Databases lists
- Explore - Edit Datasource columns
## BEFORE
<img width="1580" alt="charts-list-BEFORE" src="https://user-images.githubusercontent.com/60598000/105756142-847efc80-5f4c-11eb-9ef7-f208feff4467.png">
<img width="1478" alt="dashboard-list-trash-BEFORE" src="https://user-images.githubusercontent.com/60598000/105756148-85b02980-5f4c-11eb-8cbf-78db689203f3.png">
<img width="1113" alt="dashboard-lists-cardview-BEFORE" src="https://user-images.githubusercontent.com/60598000/105756149-8648c000-5f4c-11eb-9656-f0b00ffa3aa3.png">
<img width="1394" alt="databases-lists-BEFORE" src="https://user-images.githubusercontent.com/60598000/105756152-86e15680-5f4c-11eb-89e6-b85312362ca0.png">
<img width="1455" alt="datasets-list-BEFORE" src="https://user-images.githubusercontent.com/60598000/105756154-8779ed00-5f4c-11eb-9e81-8259cae6a2b7.png">
<img width="1330" alt="saved-query-list-trash-BEFORE" src="https://user-images.githubusercontent.com/60598000/105756155-8779ed00-5f4c-11eb-895d-8086b3e4aae1.png">
<img width="871" alt="Screen Shot 2021-02-03 at 17 14 41" src="https://user-images.githubusercontent.com/60598000/106776714-9f382c00-6644-11eb-9d98-58a35fc945d9.png">
## AFTER
<img width="1571" alt="charts-list-AFTER" src="https://user-images.githubusercontent.com/60598000/105756179-91035500-5f4c-11eb-8d61-97a2ae0910ef.png">
<img width="1653" alt="dashboard-list-trash-AFTER" src="https://user-images.githubusercontent.com/60598000/105756183-919beb80-5f4c-11eb-99af-7328462f3675.png">
<img width="1107" alt="dashboard-lists-cardview-AFTER" src="https://user-images.githubusercontent.com/60598000/105756184-92348200-5f4c-11eb-9ffe-ab584db67a68.png">
<img width="1394" alt="databases-lists-AFTER" src="https://user-images.githubusercontent.com/60598000/105756188-92cd1880-5f4c-11eb-8fa3-209999a271c8.png">
<img width="1454" alt="datasets-list-AFTER" src="https://user-images.githubusercontent.com/60598000/105756190-9365af00-5f4c-11eb-9249-fd54df315879.png">
<img width="1327" alt="saved-query-list-trash-AFTER" src="https://user-images.githubusercontent.com/60598000/105756193-9365af00-5f4c-11eb-814e-cd02d18925ae.png">
<img width="867" alt="Screen Shot 2021-02-03 at 20 56 09" src="https://user-images.githubusercontent.com/60598000/106801652-4d9e9a00-6662-11eb-93de-5d57e0f23077.png">
### TEST PLAN
1. Go to any list
2. Hover your mouse on a list item
3. Make sure the trash icon appears and works as intended
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #12229:
URL: https://github.com/apache/superset/pull/12229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
# [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=h1) Report
> Merging [#12229](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=desc) (d2d9159) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **decrease** coverage by `14.12%`.
> The diff coverage is `18.70%`.
[](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12229 +/- ##
===========================================
- Coverage 72.29% 58.17% -14.13%
===========================================
Files 864 481 -383
Lines 44883 16120 -28763
Branches 5403 4124 -1279
===========================================
- Hits 32450 9378 -23072
+ Misses 12224 6742 -5482
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.17% <18.70%> (?)` | |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/components/ListViewCard/index.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL2luZGV4LnRzeA==) | `100.00% <ø> (+5.45%)` | :arrow_up: |
| [superset-frontend/src/components/Icons/index.ts](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaW5kZXgudHM=) | `4.76% <4.76%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | `70.83% <25.00%> (-1.39%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `76.00% <50.00%> (+0.32%)` | :arrow_up: |
| [...set-frontend/src/components/Icons/AntdEnhanced.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvQW50ZEVuaGFuY2VkLnRzeA==) | `75.00% <75.00%> (ø)` | |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <100.00%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `80.18% <100.00%> (+8.52%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `72.63% <100.00%> (-1.25%)` | :arrow_down: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `69.66% <100.00%> (-9.55%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [780 more](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=footer). Last update [9b5e66b...d2d9159](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12229: refactor: Trash icon enhanced to Antd Icon in lists
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
# [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=h1) Report
> Merging [#12229](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=desc) (4cda25b) into [master](https://codecov.io/gh/apache/superset/commit/8c29ba88a48b8eabace9967b30eb33236748280f?el=desc) (8c29ba8) will **increase** coverage by `0.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12229 +/- ##
==========================================
+ Coverage 62.80% 63.38% +0.58%
==========================================
Files 1022 488 -534
Lines 49973 30089 -19884
Branches 4892 0 -4892
==========================================
- Hits 31385 19072 -12313
+ Misses 18388 11017 -7371
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.38% <ø> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [542 more](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=footer). Last update [8c29ba8...4cda25b](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-783633552
> cc @Steejay @mihir174
> Looks great. Only question I have is whether we can we still use custom icons when designers want something new or different?
Indeed! This is built specifically for that, so we can effectively extend/override the AntD icon set, rather than having custom icons that are a bit of an interface mismatch from the AntD icons we'd use elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12229: refactor: Trash icon enhanced to Antd Icon in lists
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
# [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=h1) Report
> Merging [#12229](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=desc) (4cda25b) into [master](https://codecov.io/gh/apache/superset/commit/8c29ba88a48b8eabace9967b30eb33236748280f?el=desc) (8c29ba8) will **increase** coverage by `0.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12229 +/- ##
==========================================
+ Coverage 62.80% 63.38% +0.58%
==========================================
Files 1022 488 -534
Lines 49973 30089 -19884
Branches 4892 0 -4892
==========================================
- Hits 31385 19072 -12313
+ Misses 18388 11017 -7371
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.38% <ø> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [542 more](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=footer). Last update [8c29ba8...4cda25b](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #12229: refactor: Trash icon enhanced to Antd Icon in lists
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767720483
For transparency, Diego and I spoke online, and we agreed to put this in Draft mode while exploring a couple options:
• Re-exporting vanilla AntD icons from the Superset Icon component, so we can get ALL icons from one import.
• Attempting to consolidate the interface for components, either with AntD's `<WhateverIcon />` interface, or our own `<Icon name="WhateverIcon" />` interface.
• Once the interface is conformed, trying to find a way to essentially override an AntD icon, which would allow a component developer to use `AnyVanillaIcon` from AntD, and then when we want to replace it with our own, we would simply _override_ it in our `Icon` component, and not have to go around finding/replacing the scattered implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #12229:
URL: https://github.com/apache/superset/pull/12229#discussion_r566620224
##########
File path: superset-frontend/src/views/CRUD/chart/ChartCard.tsx
##########
@@ -102,22 +102,26 @@ export default function ChartCard({
</Menu.Item>
)}
{canExport && (
- <Menu.Item
- role="button"
- tabIndex={0}
- onClick={() => handleBulkChartExport([chart])}
- >
- <ListViewCard.MenuIcon name="share" /> {t('Export')}
+ <Menu.Item>
+ <div
Review comment:
Curious why this change is needed, only in case it's an indication of things we'll have to do in lots of places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas edited a comment on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-781564115
@junlincc @eschutho @nytai @ktmud @etr2460
With concerns of stability in mind, does anyone see any reason to further hesitate on merging this one in (after a rebase)? It looks like a very positive code quality change to me, so I'm getting an itchy trigger finger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #12229:
URL: https://github.com/apache/superset/pull/12229#discussion_r566625993
##########
File path: superset-frontend/src/components/Icons/index.ts
##########
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import AntdEnhancedIcons from './all/AntdEnhanced';
+import Trash from './all/Trash';
+import Alert from './all/Alert';
+import AlertSolid from './all/AlertSolid';
+import AlertSolidSmall from './all/AlertSolidSmall';
+import Binoculars from './all/Binoculars';
+import Bolt from './all/Bolt';
+import BoltSmall from './all/BoltSmall';
+import BoltSmallRun from './all/BoltSmallRun';
+
Review comment:
I second this, I'd prefer not to touch 3 files (svg, component file, and this file) when adding a new svg icon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
# [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=h1) Report
> Merging [#12229](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=desc) (cbefb3a) into [master](https://codecov.io/gh/apache/superset/commit/32f2c45f93693156f1cf88c2c5223684c31d3f20?el=desc) (32f2c45) will **decrease** coverage by `3.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12229 +/- ##
==========================================
- Coverage 67.01% 63.38% -3.64%
==========================================
Files 1022 489 -533
Lines 50102 30197 -19905
Branches 5191 0 -5191
==========================================
- Hits 33574 19139 -14435
+ Misses 16397 11058 -5339
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.38% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.50% <0.00%> (-25.07%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-13.80%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-5.85%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [545 more](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=footer). Last update [32f2c45...cbefb3a](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12229: refactor: Trash icon enhanced to Antd Icon in lists
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12229: refactor: Trash icon enhanced to Antd Icon in lists
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
# [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=h1) Report
> Merging [#12229](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=desc) (4cda25b) into [master](https://codecov.io/gh/apache/superset/commit/8c29ba88a48b8eabace9967b30eb33236748280f?el=desc) (8c29ba8) will **increase** coverage by `0.57%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12229 +/- ##
==========================================
+ Coverage 62.80% 63.37% +0.57%
==========================================
Files 1022 488 -534
Lines 49973 30104 -19869
Branches 4892 0 -4892
==========================================
- Hits 31385 19079 -12306
+ Misses 18388 11025 -7363
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.37% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [535 more](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=footer). Last update [8c29ba8...4cda25b](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12229: refactor: Trash icon enhanced to Antd Icon in lists
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
# [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=h1) Report
> Merging [#12229](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=desc) (4cda25b) into [master](https://codecov.io/gh/apache/superset/commit/8c29ba88a48b8eabace9967b30eb33236748280f?el=desc) (8c29ba8) will **increase** coverage by `0.97%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12229 +/- ##
==========================================
+ Coverage 62.80% 63.78% +0.97%
==========================================
Files 1022 488 -534
Lines 49973 30104 -19869
Branches 4892 0 -4892
==========================================
- Hits 31385 19201 -12184
+ Misses 18388 10903 -7485
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.78% <ø> (-0.30%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.82% <0.00%> (-2.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.49% <0.00%> (-1.83%)` | :arrow_down: |
| ... and [531 more](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=footer). Last update [8c29ba8...a2237cc](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12229: refactor: Trash icon enhanced to Antd Icon in lists
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767110060
Tested manually across browsers and looks fine 🟢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #12229:
URL: https://github.com/apache/superset/pull/12229#discussion_r566620224
##########
File path: superset-frontend/src/views/CRUD/chart/ChartCard.tsx
##########
@@ -102,22 +102,26 @@ export default function ChartCard({
</Menu.Item>
)}
{canExport && (
- <Menu.Item
- role="button"
- tabIndex={0}
- onClick={() => handleBulkChartExport([chart])}
- >
- <ListViewCard.MenuIcon name="share" /> {t('Export')}
+ <Menu.Item>
+ <div
Review comment:
Curious why this change is needed, only in case it's an indication of things we'll have to do elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
# [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=h1) Report
> Merging [#12229](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=desc) (cbefb3a) into [master](https://codecov.io/gh/apache/superset/commit/32f2c45f93693156f1cf88c2c5223684c31d3f20?el=desc) (32f2c45) will **decrease** coverage by `3.62%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12229 +/- ##
==========================================
- Coverage 67.01% 63.38% -3.63%
==========================================
Files 1022 489 -533
Lines 50102 30199 -19903
Branches 5191 0 -5191
==========================================
- Hits 33574 19141 -14433
+ Misses 16397 11058 -5339
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.38% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-13.80%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-5.85%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [544 more](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=footer). Last update [32f2c45...cbefb3a](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-771390213
This looks like it's ready to go, pending a teensy `lint-fix`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
# [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=h1) Report
> Merging [#12229](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=desc) (a2452c4) into [master](https://codecov.io/gh/apache/superset/commit/b5b0c2c8a2a4300aa6f7a0f1972047fee5dedd08?el=desc) (b5b0c2c) will **decrease** coverage by `2.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12229 +/- ##
==========================================
- Coverage 68.98% 66.87% -2.11%
==========================================
Files 1025 489 -536
Lines 48765 28669 -20096
Branches 5188 0 -5188
==========================================
- Hits 33639 19173 -14466
+ Misses 14992 9496 -5496
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `66.87% <ø> (-0.48%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.85% <0.00%> (-6.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.07%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [533 more](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=footer). Last update [b5b0c2c...a2452c4](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12229:
URL: https://github.com/apache/superset/pull/12229#discussion_r566976345
##########
File path: superset-frontend/src/views/CRUD/chart/ChartCard.tsx
##########
@@ -102,22 +102,26 @@ export default function ChartCard({
</Menu.Item>
)}
{canExport && (
- <Menu.Item
- role="button"
- tabIndex={0}
- onClick={() => handleBulkChartExport([chart])}
- >
- <ListViewCard.MenuIcon name="share" /> {t('Export')}
+ <Menu.Item>
+ <div
Review comment:
@rusackas Antd adds a span around the SVG. There might be cases where related styles affect the span causing the Icon to behave incorrectly. This was one of those cases. As a container DIV was used elsewhere in this file, I went ahead and made it consistent everywhere. By doing so the style override issue gets resolved as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-771390213
This looks like it's ready to go, pending a teensy `lint-fix`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-783545375
cc @steejay @mihir174
Looks great. Only question I have is whether we can we still use custom icons when designers want something new or different?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
rusackas closed pull request #12229:
URL: https://github.com/apache/superset/pull/12229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12229:
URL: https://github.com/apache/superset/pull/12229#discussion_r580233808
##########
File path: superset-frontend/src/components/Icons/index.ts
##########
@@ -0,0 +1,284 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { ReactComponent as AlertIcon } from 'images/icons/alert.svg';
+import { ReactComponent as AlertSolidIcon } from 'images/icons/alert_solid.svg';
+import { ReactComponent as AlertSolidSmallIcon } from 'images/icons/alert_solid_small.svg';
+import { ReactComponent as BinocularsIcon } from 'images/icons/binoculars.svg';
+import { ReactComponent as BoltIcon } from 'images/icons/bolt.svg';
+import { ReactComponent as BoltSmallIcon } from 'images/icons/bolt_small.svg';
+import { ReactComponent as BoltSmallRunIcon } from 'images/icons/bolt_small_run.svg';
+import { ReactComponent as CalendarIcon } from 'images/icons/calendar.svg';
+import { ReactComponent as CancelIcon } from 'images/icons/cancel.svg';
+import { ReactComponent as CancelSolidIcon } from 'images/icons/cancel_solid.svg';
+import { ReactComponent as CancelXIcon } from 'images/icons/cancel-x.svg';
+import { ReactComponent as CardViewIcon } from 'images/icons/card_view.svg';
+import { ReactComponent as CardsIcon } from 'images/icons/cards.svg';
+import { ReactComponent as CardsLockedIcon } from 'images/icons/cards_locked.svg';
+import { ReactComponent as CaretDownIcon } from 'images/icons/caret_down.svg';
+import { ReactComponent as CaretLeftIcon } from 'images/icons/caret_left.svg';
+import { ReactComponent as CaretRightIcon } from 'images/icons/caret_right.svg';
+import { ReactComponent as CaretUpIcon } from 'images/icons/caret_up.svg';
+import { ReactComponent as CertifiedIcon } from 'images/icons/certified.svg';
+import { ReactComponent as CheckIcon } from 'images/icons/check.svg';
+import { ReactComponent as CheckboxHalfIcon } from 'images/icons/checkbox-half.svg';
+import { ReactComponent as CheckboxOffIcon } from 'images/icons/checkbox-off.svg';
+import { ReactComponent as CheckboxOnIcon } from 'images/icons/checkbox-on.svg';
+import { ReactComponent as CircleCheckIcon } from 'images/icons/circle_check.svg';
+import { ReactComponent as CircleCheckSolidIcon } from 'images/icons/circle_check_solid.svg';
+import { ReactComponent as CircleIcon } from 'images/icons/circle.svg';
+import { ReactComponent as ClockIcon } from 'images/icons/clock.svg';
+import { ReactComponent as CloseIcon } from 'images/icons/close.svg';
+import { ReactComponent as CodeIcon } from 'images/icons/code.svg';
+import { ReactComponent as CogIcon } from 'images/icons/cog.svg';
+import { ReactComponent as CollapseIcon } from 'images/icons/collapse.svg';
+import { ReactComponent as ColorPaletteIcon } from 'images/icons/color_palette.svg';
+import { ReactComponent as ComponentsIcon } from 'images/icons/components.svg';
+import { ReactComponent as CopyIcon } from 'images/icons/copy.svg';
+import { ReactComponent as CursorTargeIcon } from 'images/icons/cursor_target.svg';
+import { ReactComponent as DatabaseIcon } from 'images/icons/database.svg';
+import { ReactComponent as DatasetPhysicalIcon } from 'images/icons/dataset_physical.svg';
+import { ReactComponent as DatasetVirtualGreyscaleIcon } from 'images/icons/dataset_virtual_greyscale.svg';
+import { ReactComponent as DatasetVirtualIcon } from 'images/icons/dataset_virtual.svg';
+import { ReactComponent as DownloadIcon } from 'images/icons/download.svg';
+import { ReactComponent as EditAltIcon } from 'images/icons/edit_alt.svg';
+import { ReactComponent as EditIcon } from 'images/icons/edit.svg';
+import { ReactComponent as EmailIcon } from 'images/icons/email.svg';
+import { ReactComponent as ErrorIcon } from 'images/icons/error.svg';
+import { ReactComponent as ErrorSolidIcon } from 'images/icons/error_solid.svg';
+import { ReactComponent as ErrorSolidSmallIcon } from 'images/icons/error_solid_small.svg';
+import { ReactComponent as ExclamationIcon } from 'images/icons/exclamation.svg';
+import { ReactComponent as ExpandIcon } from 'images/icons/expand.svg';
+import { ReactComponent as EyeIcon } from 'images/icons/eye.svg';
+import { ReactComponent as EyeSlashIcon } from 'images/icons/eye_slash.svg';
+import { ReactComponent as FavoriteSelectedIcon } from 'images/icons/favorite-selected.svg';
+import { ReactComponent as FavoriteSmallSelectedIcon } from 'images/icons/favorite_small_selected.svg';
+import { ReactComponent as FavoriteUnselectedIcon } from 'images/icons/favorite-unselected.svg';
+import { ReactComponent as FieldABCIcon } from 'images/icons/field_abc.svg';
+import { ReactComponent as FieldBooleanIcon } from 'images/icons/field_boolean.svg';
+import { ReactComponent as FieldDateIcon } from 'images/icons/field_date.svg';
+import { ReactComponent as FieldDerivedIcon } from 'images/icons/field_derived.svg';
+import { ReactComponent as FieldNumIcon } from 'images/icons/field_num.svg';
+import { ReactComponent as FieldStructIcon } from 'images/icons/field_struct.svg';
+import { ReactComponent as FileIcon } from 'images/icons/file.svg';
+import { ReactComponent as FilterIcon } from 'images/icons/filter.svg';
+import { ReactComponent as FilterSmallIcon } from 'images/icons/filter_small.svg';
+import { ReactComponent as FolderIcon } from 'images/icons/folder.svg';
+import { ReactComponent as FullIcon } from 'images/icons/full.svg';
+import { ReactComponent as FunctionIcon } from 'images/icons/function_x.svg';
+import { ReactComponent as GearIcon } from 'images/icons/gear.svg';
+import { ReactComponent as GridIcon } from 'images/icons/grid.svg';
+import { ReactComponent as ImageIcon } from 'images/icons/image.svg';
+import { ReactComponent as ImportIcon } from 'images/icons/import.svg';
+import { ReactComponent as InfoIcon } from 'images/icons/info.svg';
+import { ReactComponent as InfoSolidIcon } from 'images/icons/info-solid.svg';
+import { ReactComponent as InfoSolidSmallIcon } from 'images/icons/info_solid_small.svg';
+import { ReactComponent as JoinIcon } from 'images/icons/join.svg';
+import { ReactComponent as KeyboardIcon } from 'images/icons/keyboard.svg';
+import { ReactComponent as LayersIcon } from 'images/icons/layers.svg';
+import { ReactComponent as LightbulbIcon } from 'images/icons/lightbulb.svg';
+import { ReactComponent as LinkIcon } from 'images/icons/link.svg';
+import { ReactComponent as ListIcon } from 'images/icons/list.svg';
+import { ReactComponent as ListViewIcon } from 'images/icons/list_view.svg';
+import { ReactComponent as LocationIcon } from 'images/icons/location.svg';
+import { ReactComponent as LockLockedIcon } from 'images/icons/lock_locked.svg';
+import { ReactComponent as LockUnlockedIcon } from 'images/icons/lock_unlocked.svg';
+import { ReactComponent as MapIcon } from 'images/icons/map.svg';
+import { ReactComponent as MessageIcon } from 'images/icons/message.svg';
+import { ReactComponent as MinusIcon } from 'images/icons/minus.svg';
+import { ReactComponent as MinusSolidIcon } from 'images/icons/minus_solid.svg';
+import { ReactComponent as ModeHorizIcon } from 'images/icons/more_horiz.svg';
Review comment:
nit: this should probably be `MoreHorizIcon`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #12229:
URL: https://github.com/apache/superset/pull/12229#discussion_r566621125
##########
File path: superset-frontend/src/components/ListView/ActionsBar.tsx
##########
@@ -53,6 +54,7 @@ export default function ActionsBar({ actions }: ActionsBarProps) {
return (
<StyledActions className="actions">
{actions.map((action, index) => {
+ const ActionIcon = Icons[action.icon];
Review comment:
nifty!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
# [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=h1) Report
> Merging [#12229](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=desc) (0179487) into [master](https://codecov.io/gh/apache/superset/commit/b5b0c2c8a2a4300aa6f7a0f1972047fee5dedd08?el=desc) (b5b0c2c) will **decrease** coverage by `2.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12229 +/- ##
==========================================
- Coverage 68.98% 66.87% -2.11%
==========================================
Files 1025 489 -536
Lines 48765 28667 -20098
Branches 5188 0 -5188
==========================================
- Hits 33639 19171 -14468
+ Misses 14992 9496 -5496
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `66.87% <ø> (-0.48%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.50% <0.00%> (-25.07%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.85% <0.00%> (-6.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.07%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [533 more](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=footer). Last update [b5b0c2c...0179487](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #12229:
URL: https://github.com/apache/superset/pull/12229#discussion_r567102833
##########
File path: superset-frontend/src/components/Icons/index.ts
##########
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import AntdEnhancedIcons from './all/AntdEnhanced';
+import Trash from './all/Trash';
+import Alert from './all/Alert';
+import AlertSolid from './all/AlertSolid';
+import AlertSolidSmall from './all/AlertSolidSmall';
+import Binoculars from './all/Binoculars';
+import Bolt from './all/Bolt';
+import BoltSmall from './all/BoltSmall';
+import BoltSmallRun from './all/BoltSmallRun';
+
Review comment:
This is looking pretty good. It may get messy eventually, but that might just mean we need to clean up our icons. I think it's pretty clear what changes are needed to add a new icon from glancing at this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #12229:
URL: https://github.com/apache/superset/pull/12229#discussion_r566978714
##########
File path: superset-frontend/src/components/Icons/index.ts
##########
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import AntdEnhancedIcons from './all/AntdEnhanced';
+import Trash from './all/Trash';
+import Alert from './all/Alert';
+import AlertSolid from './all/AlertSolid';
+import AlertSolidSmall from './all/AlertSolidSmall';
+import Binoculars from './all/Binoculars';
+import Bolt from './all/Bolt';
+import BoltSmall from './all/BoltSmall';
+import BoltSmallRun from './all/BoltSmallRun';
+
Review comment:
@rusackas @nytai I tend to agree as well. I have made some changes and now the index imports, enhances, and exports everything back. This makes the file a bit lengthy but it keeps all the functionalities discussed plus what you want here. This is a work-in-progress and I still need to finish re-exporting all the existing icons, but I'd appreciate your feedback while I move forward with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #12229:
URL: https://github.com/apache/superset/pull/12229#discussion_r566620616
##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
##########
@@ -301,10 +302,7 @@ function DashboardList(props: DashboardListProps) {
className="action-button"
onClick={confirmDelete}
>
- <Icon
- data-test="dashboard-list-trash-icon"
- name="trash"
- />
+ <Icons.Trash data-test="dashboard-list-trash-icon" />
Review comment:
I really like this implementation, btw. Seems much cleaner/clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-781564115
@junlincc @eschutho @nytai
With concerns of stability in mind, does anyone see any reason to further hesitate on merging this one in (after a rebase)? It looks like a very positive code quality change to me, so I'm getting an itchy trigger finger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
# [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=h1) Report
> Merging [#12229](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=desc) (d2d9159) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **decrease** coverage by `14.51%`.
> The diff coverage is `18.70%`.
[](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12229 +/- ##
===========================================
- Coverage 72.29% 57.77% -14.52%
===========================================
Files 864 481 -383
Lines 44883 16120 -28763
Branches 5403 4124 -1279
===========================================
- Hits 32450 9314 -23136
+ Misses 12224 6806 -5418
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.77% <18.70%> (?)` | |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/components/ListViewCard/index.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL2luZGV4LnRzeA==) | `100.00% <ø> (+5.45%)` | :arrow_up: |
| [superset-frontend/src/components/Icons/index.ts](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaW5kZXgudHM=) | `4.76% <4.76%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | `70.83% <25.00%> (-1.39%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `76.00% <50.00%> (+0.32%)` | :arrow_up: |
| [...set-frontend/src/components/Icons/AntdEnhanced.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvQW50ZEVuaGFuY2VkLnRzeA==) | `75.00% <75.00%> (ø)` | |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <100.00%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `80.18% <100.00%> (+8.52%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `72.63% <100.00%> (-1.25%)` | :arrow_down: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `69.66% <100.00%> (-9.55%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [780 more](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=footer). Last update [9b5e66b...d2d9159](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
# [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=h1) Report
> Merging [#12229](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=desc) (ffff7e9) into [master](https://codecov.io/gh/apache/superset/commit/32f2c45f93693156f1cf88c2c5223684c31d3f20?el=desc) (32f2c45) will **increase** coverage by `3.87%`.
> The diff coverage is `58.23%`.
[](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12229 +/- ##
==========================================
+ Coverage 67.01% 70.89% +3.87%
==========================================
Files 1022 539 -483
Lines 50102 20354 -29748
Branches 5191 5193 +2
==========================================
- Hits 33574 14429 -19145
+ Misses 16397 5787 -10610
- Partials 131 138 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.10% <44.98%> (-0.83%)` | :arrow_down: |
| javascript | `61.76% <54.40%> (+0.02%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/CRUD/CollectionTable.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLnRzeA==) | `61.60% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
| [...rontend/src/SqlLab/components/SaveDatasetModal.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVEYXRhc2V0TW9kYWwudHN4) | `87.50% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `82.05% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `86.51% <ø> (ø)` | |
| [...perset-frontend/src/addSlice/AddSliceContainer.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLnRzeA==) | `75.86% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...src/components/ButtonGroup/ButtonGroup.stories.tsx](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uR3JvdXAvQnV0dG9uR3JvdXAuc3Rvcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
| ... and [568 more](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=footer). Last update [32f2c45...199e054](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] geido commented on pull request #12229: refactor: Custom icons to antd
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #12229:
URL: https://github.com/apache/incubator-superset/pull/12229#issuecomment-752688849
@rusackas @junlincc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12229: refactor: Trash icon enhanced to Antd Icon in lists
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767110060
Tested manually across browsers and looks fine 🟢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
# [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=h1) Report
> Merging [#12229](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=desc) (a2452c4) into [master](https://codecov.io/gh/apache/superset/commit/b5b0c2c8a2a4300aa6f7a0f1972047fee5dedd08?el=desc) (b5b0c2c) will **decrease** coverage by `2.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12229 +/- ##
==========================================
- Coverage 68.98% 66.87% -2.11%
==========================================
Files 1025 489 -536
Lines 48765 28669 -20096
Branches 5188 0 -5188
==========================================
- Hits 33639 19173 -14466
+ Misses 14992 9496 -5496
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `66.87% <ø> (-0.48%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.85% <0.00%> (-6.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.07%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [533 more](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=footer). Last update [b5b0c2c...a2452c4](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas edited a comment on pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-783633552
> cc @Steejay @mihir174
> Looks great. Only question I have is whether we can we still use custom icons when designers want something new or different?
Indeed! This is built specifically for that, so we can effectively extend/override the AntD icon set, rather than having custom icons that are a bit of an interface mismatch from the AntD icons we'd use elsewhere.
In fact, plans are underway to revamp our custom icons in the design system to better match the layout/sizing of the AntD icons. We'll get them all to play nicely together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #12229:
URL: https://github.com/apache/superset/pull/12229#discussion_r566619705
##########
File path: superset-frontend/src/components/Icons/index.ts
##########
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import AntdEnhancedIcons from './all/AntdEnhanced';
+import Trash from './all/Trash';
+import Alert from './all/Alert';
+import AlertSolid from './all/AlertSolid';
+import AlertSolidSmall from './all/AlertSolidSmall';
+import Binoculars from './all/Binoculars';
+import Bolt from './all/Bolt';
+import BoltSmall from './all/BoltSmall';
+import BoltSmallRun from './all/BoltSmallRun';
+
Review comment:
I think this PR is looking AMAZING, but there's one thing I'm trying to weigh (and I'm curious what you think).
Rather than having a whole bunch of small icon files, would it be easier to grow/maintain the icon set if we just made this file longer, doing all the VG imports and `<Icon ...>` composition in one place? ¯\\\_(ツ)_/¯
I think what you have done here is very clean and proper... I'm just wondering if the other way would make life easier. Kind of a nitpick, but now's the time to think about it I suppose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12229: refactor: Trash icon enhanced to Antd Icon in lists
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12229:
URL: https://github.com/apache/superset/pull/12229#issuecomment-767100556
# [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=h1) Report
> Merging [#12229](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=desc) (a2237cc) into [master](https://codecov.io/gh/apache/superset/commit/8c29ba88a48b8eabace9967b30eb33236748280f?el=desc) (8c29ba8) will **increase** coverage by `0.57%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12229 +/- ##
==========================================
+ Coverage 62.80% 63.37% +0.57%
==========================================
Files 1022 488 -534
Lines 49973 30106 -19867
Branches 4892 0 -4892
==========================================
- Hits 31385 19081 -12304
+ Misses 18388 11025 -7363
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.37% <ø> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [537 more](https://codecov.io/gh/apache/superset/pull/12229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=footer). Last update [8c29ba8...a2237cc](https://codecov.io/gh/apache/superset/pull/12229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org